[PATCH] Fix PR middle-end/32304 ICE with ipa-reference turning a variable needing constructing into a const variable

[PATCH] Fix PR middle-end/32304 ICE with ipa-reference turning a variable needing constructing into a const variable

[Andrew Pinski]

[-- Attachment #1: Type: text/plain, Size: 649 bytes --]

Hi,
  The problem here is that ipa-reference will not ignore decls' whos
types have TYPE_NEEDS_CONSTRUCTING set.  This showed only up after the
early optimization was added as the variable's address was taken
before.

This patch just adds the check for TYPE_NEEDS_CONSTRUCTING to
has_proper_scope_for_analysis so we don't run into an ICE in
set_mem_attributes_minus_bitpos.

OK? Bootstrapped and tested on i686-apple-darwin8.10 and with no regressions.

Thanks,
Andrew Pinski

ChangeLog:
* ipa-reference.c (has_proper_scope_for_analysis): Return false when
the decl's type has
TYPE_NEEDS_CONSTRUCTING set.

* g++.dg/torture/pr32304.C: New testcase.

[-- Attachment #2: fixpr32304.diff.txt --]
[-- Type: text/plain, Size: 959 bytes --]

Index: ipa-reference.c
===================================================================
--- ipa-reference.c	(revision 127176)
+++ ipa-reference.c	(working copy)
@@ -267,6 +267,10 @@ has_proper_scope_for_analysis (tree t)
   if (DECL_EXTERNAL (t) || TREE_PUBLIC (t))
     return false;
 
+  /* We cannot touch decls where the type needs constructing.  */
+  if (TYPE_NEEDS_CONSTRUCTING (TREE_TYPE (t)))
+    return false;
+
   /* This is a variable we care about.  Check if we have seen it
      before, and if not add it the set of variables we care about.  */
   if (!bitmap_bit_p (all_module_statics, DECL_UID (t)))
Index: testsuite/g++.dg/torture/pr32304.C
===================================================================
--- testsuite/g++.dg/torture/pr32304.C	(revision 0)
+++ testsuite/g++.dg/torture/pr32304.C	(revision 0)
@@ -0,0 +1,9 @@
+// { dg-do compile }
+
+struct S {
+        S() {}
+};
+S f() {
+        static S s;
+        return s;
+}

Re: [PATCH] Fix PR middle-end/32304 ICE with ipa-reference turning a variable needing constructing into a const variable

[Diego Novillo]

On 8/3/07 3:06 PM, Andrew Pinski wrote:

> * ipa-reference.c (has_proper_scope_for_analysis): Return false when
> the decl's type has
> TYPE_NEEDS_CONSTRUCTING set.
> 
> * g++.dg/torture/pr32304.C: New testcase.

OK.