From: "Andrew Pinski" <pinskia@gmail.com>
To: "David Edelsohn" <dje@watson.ibm.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [RFC] PowerPC processor and cache detection
Date: Mon, 06 Aug 2007 20:59:00 -0000 [thread overview]
Message-ID: <de8d50360708061359o7c9d2ac4w99b0523fed52252@mail.gmail.com> (raw)
In-Reply-To: <200708062045.l76KjhhY029738@makai.watson.ibm.com>
On 8/6/07, David Edelsohn <dje@watson.ibm.com> wrote:
> The appended patch implements -mcpu=native detecting the processor
> and cache on AIX, Darwin and Linux. Unfortunately, PPC Linux does not
> communicate any cache information, so it only selects the processor.
>
> I am not sure whether to protect the Linux code with __ELF__ or
> with __linux.
>
> +#ifdef GCC_VERSION
Even though I know this is copied from driver-i386.c, it is wrong (PR
32787 records that bug). GCC_VERSION is always defined via
ansidecl.h:
#ifndef GCC_VERSION
#define GCC_VERSION (__GNUC__ * 1000 + __GNUC_MINOR__)
#endif /* GCC_VERSION */
It would be better if you did:
#if GCC_VERSION >= 0
Thanks,
Andrew Pinski
next prev parent reply other threads:[~2007-08-06 20:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-06 20:45 David Edelsohn
2007-08-06 20:59 ` Andrew Pinski [this message]
2007-08-07 14:35 ` Michael Matz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de8d50360708061359o7c9d2ac4w99b0523fed52252@mail.gmail.com \
--to=pinskia@gmail.com \
--cc=dje@watson.ibm.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).