From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15984 invoked by alias); 10 Aug 2007 21:07:31 -0000 Received: (qmail 15936 invoked by uid 22791); 10 Aug 2007 21:07:31 -0000 X-Spam-Check-By: sourceware.org Received: from rv-out-0910.google.com (HELO rv-out-0910.google.com) (209.85.198.190) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 10 Aug 2007 21:07:27 +0000 Received: by rv-out-0910.google.com with SMTP id f5so680343rvb for ; Fri, 10 Aug 2007 14:07:25 -0700 (PDT) Received: by 10.142.77.11 with SMTP id z11mr148543wfa.1186780045726; Fri, 10 Aug 2007 14:07:25 -0700 (PDT) Received: by 10.142.99.11 with HTTP; Fri, 10 Aug 2007 14:07:25 -0700 (PDT) Message-ID: Date: Fri, 10 Aug 2007 21:07:00 -0000 From: "Andrew Pinski" To: "Daniel Berlin" Subject: Re: [PATCH]: Transform compute_may_aliases into a TODO Cc: "GCC Patches" , "Diego Novillo" In-Reply-To: <4aca3dc20708101355ked7fae4y2ed1cacbbb4f52d6@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <4aca3dc20708101355ked7fae4y2ed1cacbbb4f52d6@mail.gmail.com> X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2007-08/txt/msg00706.txt.bz2 On 8/10/07, Daniel Berlin wrote: > We often recompute aliases even when absolutely nothing has changed. > This is quite wasteful. > The attached changes compute_may_aliases into a TODO, and we now only > run it when we've changed things that could destroy aliases. You forgot to remove this comment which is no longer true: /* FIXME: May alias should a TODO but for 4.0.0, we add may_alias right after fold builtins which can create arbitrary GIMPLE. */ Thanks, Andrew Pinski