From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28679 invoked by alias); 8 Feb 2008 02:53:38 -0000 Received: (qmail 28671 invoked by uid 22791); 8 Feb 2008 02:53:38 -0000 X-Spam-Check-By: sourceware.org Received: from wa-out-1112.google.com (HELO wa-out-1112.google.com) (209.85.146.179) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 08 Feb 2008 02:53:21 +0000 Received: by wa-out-1112.google.com with SMTP id m16so167581waf.20 for ; Thu, 07 Feb 2008 18:53:18 -0800 (PST) Received: by 10.141.20.7 with SMTP id x7mr8114598rvi.255.1202439198746; Thu, 07 Feb 2008 18:53:18 -0800 (PST) Received: by 10.141.123.10 with HTTP; Thu, 7 Feb 2008 18:53:18 -0800 (PST) Message-ID: Date: Fri, 08 Feb 2008 03:04:00 -0000 From: "Andrew Pinski" To: "Sa Liu" Subject: Re: [PATCH, spu] fix wrong parameter type in spu intrinsics Cc: gcc-patches@gcc.gnu.org In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2008-02/txt/msg00244.txt.bz2 On 2/5/08, Sa Liu wrote: > The spu intrinsics spu_convtf, spu_convts and spu_convtu have parameter > scale of type unsigned int (7-bit literal). Values outside the range of > [0, 127] should be flagged as an error and compilation is terminated. > Currently the compiler doesn't output the error message, but terminates > with an internal compiler error. This has been fixed by specifying proper > argument type in the built-in defination. > > Ok for mainline? This is ok with testcases and a changelog entry. Thanks, Andrew Pinski