public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [PATCH, i386]: Committed: Define CMPtype as typedef using libgcc_cmp_return  mode.
@ 2008-02-15 18:30 Uros Bizjak
  2008-02-15 18:56 ` Andrew Pinski
  0 siblings, 1 reply; 2+ messages in thread
From: Uros Bizjak @ 2008-02-15 18:30 UTC (permalink / raw)
  To: GCC Patches

[-- Attachment #1: Type: text/plain, Size: 381 bytes --]

Hello!

This obvious patch somehow slipped through the cracks.
[The patch also fixes a few cosmetic issues in sfp-machine.c.]

2008-02-15  Uros Bizjak  <ubizjak@gmail.com>

        * config/i386/sfp-machine.h (CMPtype): Define as typedef using
        libgcc_cmp_return mode.

Patch was bootstrapped and regression tested on x86_64-pc-linux-gnu, 
committed to SVN mainline.

Uros.

[-- Attachment #2: p.diff.txt --]
[-- Type: text/plain, Size: 1450 bytes --]

Index: config/i386/sfp-machine.h
===================================================================
--- config/i386/sfp-machine.h	(revision 132345)
+++ config/i386/sfp-machine.h	(working copy)
@@ -3,15 +3,16 @@
 #define _FP_WS_TYPE		signed long
 #define _FP_I_TYPE		long
 
-typedef int TItype __attribute__((mode(TI)));
-typedef unsigned int UTItype __attribute__((mode(TI)));
+typedef int TItype __attribute__ ((mode (TI)));
+typedef unsigned int UTItype __attribute__ ((mode (TI)));
 
-#define TI_BITS			(__CHAR_BIT__ * (int)sizeof(TItype))
+#define TI_BITS (__CHAR_BIT__ * (int)sizeof(TItype))
 
-/* The type of the result of a floating point comparison.
-   This must match `word_mode' in GCC for the target.  */
-#define CMPtype			long
+/* The type of the result of a floating point comparison.  This must
+   match `__libgcc_cmp_return__' in GCC for the target.  */
 
+typedef int CMPtype __attribute__ ((mode (__libgcc_cmp_return__)));
+
 #define _FP_MUL_MEAT_Q(R,X,Y)                           \
   _FP_MUL_MEAT_2_wide(_FP_WFRACBITS_Q,R,X,Y,umul_ppmm)
 
@@ -30,8 +31,7 @@
 
 /* Here is something Intel misdesigned: the specs don't define
    the case where we have two NaNs with same mantissas, but
-   different sign. Different operations pick up different NaNs.
- */
+   different sign. Different operations pick up different NaNs.  */
 #define _FP_CHOOSENAN(fs, wc, R, X, Y, OP)			\
   do {								\
     if (_FP_FRAC_GT_##wc(X, Y)					\

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH, i386]: Committed: Define CMPtype as typedef using libgcc_cmp_return mode.
  2008-02-15 18:30 [PATCH, i386]: Committed: Define CMPtype as typedef using libgcc_cmp_return mode Uros Bizjak
@ 2008-02-15 18:56 ` Andrew Pinski
  0 siblings, 0 replies; 2+ messages in thread
From: Andrew Pinski @ 2008-02-15 18:56 UTC (permalink / raw)
  To: Uros Bizjak; +Cc: GCC Patches

On 2/15/08, Uros Bizjak <ubizjak@gmail.com> wrote:
> Hello!
>
>  This obvious patch somehow slipped through the cracks.
>  [The patch also fixes a few cosmetic issues in sfp-machine.c.]

Most likely because I did see the usage of CMPtype in i386/sfp-machine.h .

Sorry about that.

-- Pinski

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-02-15 18:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-02-15 18:30 [PATCH, i386]: Committed: Define CMPtype as typedef using libgcc_cmp_return mode Uros Bizjak
2008-02-15 18:56 ` Andrew Pinski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).