From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7132 invoked by alias); 21 Mar 2008 20:08:02 -0000 Received: (qmail 7122 invoked by uid 22791); 21 Mar 2008 20:08:02 -0000 X-Spam-Check-By: sourceware.org Received: from rv-out-0910.google.com (HELO rv-out-0910.google.com) (209.85.198.185) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 21 Mar 2008 20:07:35 +0000 Received: by rv-out-0910.google.com with SMTP id g11so898166rvb.56 for ; Fri, 21 Mar 2008 13:07:33 -0700 (PDT) Received: by 10.141.163.12 with SMTP id q12mr1595807rvo.260.1206130053778; Fri, 21 Mar 2008 13:07:33 -0700 (PDT) Received: by 10.141.123.10 with HTTP; Fri, 21 Mar 2008 13:07:33 -0700 (PDT) Message-ID: Date: Fri, 21 Mar 2008 20:24:00 -0000 From: "Andrew Pinski" To: "Paolo Carlini" Subject: Re: [C++ Patch] Rename IS_AGGR_TYPE & co Cc: "Gcc Patch List" , "Mark Mitchell" In-Reply-To: <47D9BB00.90905@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <47D9BB00.90905@suse.de> X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2008-03/txt/msg01294.txt.bz2 On Thu, Mar 13, 2008 at 4:38 PM, Paolo Carlini wrote: > Hi all, hi Mark, > > this is the patch which I finally regtested on x86_64-linux: supposedly, > it implements rather strictly all your suggestions (many thanks again > for those). > > I would ask you to specifically double check the make_class_type > (TREE_CODE (t)) call in begin_class_definition (semantics.c), that is, > that TREE_CODE can only boils down to either RECORD_TYPE or UNION_TYPE > in that case. This patch breaks Objective-C++ building, see http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35660 . Thanks, Andrew Pinski