public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: "Andrew Pinski" <pinskia@gmail.com>
To: "Gabor Loki" <loki@gcc.gnu.org>
Cc: "Jim Wilson" <wilson@tuliptree.org>,
	"GCC Patches" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Fix PR33642, unrecognizable insn for -frtl-abstract-sequences
Date: Tue, 08 Apr 2008 10:18:00 -0000	[thread overview]
Message-ID: <de8d50360804080315m363b9cadu372e9ce33fa8af25@mail.gmail.com> (raw)
In-Reply-To: <47FB4239.2090700@gcc.gnu.org>

On Tue, Apr 8, 2008 at 3:00 AM, Gabor Loki <loki@gcc.gnu.org> wrote:
>  Well, you are probably right. The sequence abstraction algorithm
>  cannot live without insn_*_length functions. I will add HAVE_ATTR_length
>  check.
>
>  BTW, why don't IA-64 have insn_default_length or something similar?
>  I am not familiar with IA64 port, but I guessed insn_*_length functions
>  are not negligible for code size optimization passes.

Well ia64 is not usually a target which you care much about code size.
 Also insn_*_length was only used for branch relaxation so it was not
needed for ia64 or some other targets.  And in some cases it can be
wrong for some targets.

>  Some years ago I used rtx_cost instead of insn_default_length.
>  Unfortunately many ports do not involve optimize_size check to
>  produce size related numbers in their PORT_rtx_cost* functions.
>  And the result wasn't optimal to decrease code size.

I think those targets should be considered broken and fix the issue
there instead of changing to use insn_default_length.

Thanks,
Andrew Pinski

  reply	other threads:[~2008-04-08 10:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-13 18:10 Gábor Lóki
2008-04-07 23:42 ` Jim Wilson
2008-04-08 10:06   ` Gabor Loki
2008-04-08 10:18     ` Andrew Pinski [this message]
2008-04-12 17:28     ` Jim Wilson
2008-04-17 16:22 ` Maxim Kuvyrkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=de8d50360804080315m363b9cadu372e9ce33fa8af25@mail.gmail.com \
    --to=pinskia@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=loki@gcc.gnu.org \
    --cc=wilson@tuliptree.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).