public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: "Andrew Pinski" <pinskia@gmail.com>
To: "Vladimir Makarov" <vmakarov@redhat.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: IRA has been merged into trunk
Date: Thu, 28 Aug 2008 19:58:00 -0000	[thread overview]
Message-ID: <de8d50360808271304o19531c65l2dd9b8029ab3ee31@mail.gmail.com> (raw)
In-Reply-To: <48B3F9C5.5090904@redhat.com>

On Tue, Aug 26, 2008 at 5:40 AM, Vladimir Makarov <vmakarov@redhat.com> wrote:
>  Recently I got an approval of the last part of IRA -- reload
> changes.  Therefore I've just merged IRA into mainline.

This causes the PowerPC64 testcase gcc.target/powerpc/ppc64-double-1.c
to fail.  This was added to make sure that the register allocator
would get the correct answer of using the floating point registers for
fix_truncdfdi2 and floatdidf2.
Which have the following constraints:
"!f#r"

Before the register allocator we have:
(insn:HI 6 7 12 2
gcc/gcc/testsuite/gcc.target/powerpc/ppc64-double-1.c:9 (set (reg:DI
122)
        (fix:DI (reg:DF 33 1 [ d ]))) 267 {fix_truncdfdi2}
(expr_list:REG_DEAD (reg:DF 33 1 [ d ])
        (nil)))

(insn:HI 12 6 18 2
gcc/gcc/testsuite/gcc.target/powerpc/ppc64-double-1.c:11 (set
(reg/i:DF 33 1)
        (float:DF (reg:DI 122))) 263 {floatdidf2} (expr_list:REG_DEAD
(reg:DI 122)
        (nil)))

IRA says:
Pass 0 for finding allocno costs

    a0 (r122,l0) best GENERAL_REGS, cover GENERAL_REGS

Which is wrong as FLOAT_REGS is still better as both instruction take
FLOAT_REGS but is discouraged.

Thanks,
Andrew Pinski

  parent reply	other threads:[~2008-08-27 20:05 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-26 15:45 Vladimir Makarov
2008-08-26 17:19 ` H.J. Lu
2008-08-26 17:41   ` H.J. Lu
2008-08-26 17:46   ` H.J. Lu
2008-08-26 19:34   ` H.J. Lu
2008-08-27  8:20   ` H.J. Lu
2008-08-27 17:39   ` H.J. Lu
2008-08-27 20:37   ` H.J. Lu
2008-08-26 19:20 ` Jeff Law
2008-08-28 17:22 ` Joseph S. Myers
2008-08-28 23:28   ` Vladimir Makarov
2008-08-31 10:37     ` Jeff Law
2008-08-31 10:42       ` David Daney
2008-08-31 15:49       ` DJ Delorie
2008-08-28 19:58 ` Andrew Pinski [this message]
2008-08-28 23:55   ` Andrew Pinski
2008-08-28 20:14 ` Andrew Pinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=de8d50360808271304o19531c65l2dd9b8029ab3ee31@mail.gmail.com \
    --to=pinskia@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=vmakarov@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).