From: Jeff Law <jeffreyalaw@gmail.com>
To: Jan-Benedict Glaw <jbglaw@lug-owl.de>,
Nick Clifton <nickc@redhat.com>,
gcc-patches@gcc.gnu.org
Subject: Re: [patch] mcore: Fix sprintf length warning
Date: Tue, 23 May 2023 12:11:49 -0600 [thread overview]
Message-ID: <de90f2d2-6b71-64e6-de22-e8eb6bcbc091@gmail.com> (raw)
In-Reply-To: <20230522235841.inxggcczfaatu6ct@lug-owl.de>
On 5/22/23 17:58, Jan-Benedict Glaw wrote:
> Hi!
>
> One of the supplied argument strings is unneccesarily long (c-sky, using
> basically the same code, fixed it to a shorter length) and this fixes overflow
> warnings, as GCC fails to deduce that the full 256 bytes for load_op[] are
> not used at all.
>
>
> make[1]: Entering directory '/var/lib/laminar/run/gcc-mcore-elf/38/toolchain-build/gcc'
> [...]
> /usr/lib/gcc-snapshot/bin/g++ -fno-PIE -c -g -O2 -DIN_GCC -DCROSS_DIRECTORY_STRUCTURE -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual -Wmissing-format-attribute -Wconditionally-supported -Woverloaded-virtual -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -Werror -fno-common -DHAVE_CONFIG_H -I. -I. -I../../gcc/gcc -I../../gcc/gcc/. -I../../gcc/gcc/../include -I../../gcc/gcc/../libcpp/include -I../../gcc/gcc/../libcody -I../../gcc/gcc/../libdecnumber -I../../gcc/gcc/../libdecnumber/dpd -I../libdecnumber -I../../gcc/gcc/../libbacktrace -o mcore.o -MT mcore.o -MMD -MP -MF ./.deps/mcore.TPo ../../gcc/gcc/config/mcore/mcore.cc
> ../../gcc/gcc/config/mcore/mcore.cc: In function 'const char* output_inline_const(machine_mode, rtx_def**)':
> ../../gcc/gcc/config/mcore/mcore.cc:1264:24: error: '
> ixw ' directive writing 6 bytes into a region of size between 1 and 256 [-Werror=format-overflow=]
> 1264 | sprintf (buf, "%s\n\tixw\t%s,%s\t// %ld 0x%lx", load_op, dst_fmt, dst_fmt, value, value);
> | ^~~~~~~~~
> ../../gcc/gcc/config/mcore/mcore.cc:1264:21: note: using the range [0, 18446744073709551615] for directive argument
> 1264 | sprintf (buf, "%s\n\tixw\t%s,%s\t// %ld 0x%lx", load_op, dst_fmt, dst_fmt, value, value);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../../gcc/gcc/config/mcore/mcore.cc:1264:15: note: 'sprintf' output between 21 and 310 bytes into a destination of size 256
> 1264 | sprintf (buf, "%s\n\tixw\t%s,%s\t// %ld 0x%lx", load_op, dst_fmt, dst_fmt, value, value);
> | ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../../gcc/gcc/config/mcore/mcore.cc:1261:24: error: '
> ixh ' directive writing 6 bytes into a region of size between 1 and 256 [-Werror=format-overflow=]
> 1261 | sprintf (buf, "%s\n\tixh\t%s,%s\t// %ld 0x%lx", load_op, dst_fmt, dst_fmt, value, value);
> | ^~~~~~~~~
> ../../gcc/gcc/config/mcore/mcore.cc:1261:21: note: using the range [0, 18446744073709551615] for directive argument
> 1261 | sprintf (buf, "%s\n\tixh\t%s,%s\t// %ld 0x%lx", load_op, dst_fmt, dst_fmt, value, value);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../../gcc/gcc/config/mcore/mcore.cc:1261:15: note: 'sprintf' output between 21 and 310 bytes into a destination of size 256
> 1261 | sprintf (buf, "%s\n\tixh\t%s,%s\t// %ld 0x%lx", load_op, dst_fmt, dst_fmt, value, value);
> | ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../../gcc/gcc/config/mcore/mcore.cc:1258:24: error: '
> lsli ' directive writing 7 bytes into a region of size between 1 and 256 [-Werror=format-overflow=]
> 1258 | sprintf (buf, "%s\n\tlsli\t%s,%%2\t// %ld 0x%lx", load_op, dst_fmt, value, value);
> | ^~~~~~~~~~
> ../../gcc/gcc/config/mcore/mcore.cc:1258:21: note: using the range [0, 18446744073709551615] for directive argument
> 1258 | sprintf (buf, "%s\n\tlsli\t%s,%%2\t// %ld 0x%lx", load_op, dst_fmt, value, value);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../../gcc/gcc/config/mcore/mcore.cc:1258:15: note: 'sprintf' output between 22 and 311 bytes into a destination of size 256
> 1258 | sprintf (buf, "%s\n\tlsli\t%s,%%2\t// %ld 0x%lx", load_op, dst_fmt, value, value);
> | ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../../gcc/gcc/config/mcore/mcore.cc:1255:24: error: '
> rotli ' directive writing 8 bytes into a region of size between 1 and 256 [-Werror=format-overflow=]
> 1255 | sprintf (buf, "%s\n\trotli\t%s,%%2\t// %ld 0x%lx", load_op, dst_fmt, value, value);
> | ^~~~~~~~~~~
> ../../gcc/gcc/config/mcore/mcore.cc:1255:21: note: using the range [0, 18446744073709551615] for directive argument
> 1255 | sprintf (buf, "%s\n\trotli\t%s,%%2\t// %ld 0x%lx", load_op, dst_fmt, value, value);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../../gcc/gcc/config/mcore/mcore.cc:1255:15: note: 'sprintf' output between 23 and 312 bytes into a destination of size 256
> 1255 | sprintf (buf, "%s\n\trotli\t%s,%%2\t// %ld 0x%lx", load_op, dst_fmt, value, value);
> | ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../../gcc/gcc/config/mcore/mcore.cc:1252:24: error: '
> bclri ' directive writing 8 bytes into a region of size between 1 and 256 [-Werror=format-overflow=]
> 1252 | sprintf (buf, "%s\n\tbclri\t%s,%%Q2\t// %ld 0x%lx", load_op, dst_fmt, value, value);
> | ^~~~~~~~~~~
> ../../gcc/gcc/config/mcore/mcore.cc:1252:21: note: using the range [0, 18446744073709551615] for directive argument
> 1252 | sprintf (buf, "%s\n\tbclri\t%s,%%Q2\t// %ld 0x%lx", load_op, dst_fmt, value, value);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../../gcc/gcc/config/mcore/mcore.cc:1252:15: note: 'sprintf' output between 24 and 313 bytes into a destination of size 256
> 1252 | sprintf (buf, "%s\n\tbclri\t%s,%%Q2\t// %ld 0x%lx", load_op, dst_fmt, value, value);
> | ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../../gcc/gcc/config/mcore/mcore.cc:1249:24: error: '
> bseti ' directive writing 8 bytes into a region of size between 1 and 256 [-Werror=format-overflow=]
> 1249 | sprintf (buf, "%s\n\tbseti\t%s,%%P2\t// %ld 0x%lx", load_op, dst_fmt, value, value);
> | ^~~~~~~~~~~
> ../../gcc/gcc/config/mcore/mcore.cc:1249:21: note: using the range [0, 18446744073709551615] for directive argument
> 1249 | sprintf (buf, "%s\n\tbseti\t%s,%%P2\t// %ld 0x%lx", load_op, dst_fmt, value, value);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../../gcc/gcc/config/mcore/mcore.cc:1249:15: note: 'sprintf' output between 24 and 313 bytes into a destination of size 256
> 1249 | sprintf (buf, "%s\n\tbseti\t%s,%%P2\t// %ld 0x%lx", load_op, dst_fmt, value, value);
> | ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../../gcc/gcc/config/mcore/mcore.cc:1246:24: error: '
> rsubi ' directive writing 8 bytes into a region of size between 1 and 256 [-Werror=format-overflow=]
> 1246 | sprintf (buf, "%s\n\trsubi\t%s,%%2\t// %ld 0x%lx", load_op, dst_fmt, value, value);
> | ^~~~~~~~~~~
> ../../gcc/gcc/config/mcore/mcore.cc:1246:21: note: using the range [0, 18446744073709551615] for directive argument
> 1246 | sprintf (buf, "%s\n\trsubi\t%s,%%2\t// %ld 0x%lx", load_op, dst_fmt, value, value);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../../gcc/gcc/config/mcore/mcore.cc:1246:15: note: 'sprintf' output between 23 and 312 bytes into a destination of size 256
> 1246 | sprintf (buf, "%s\n\trsubi\t%s,%%2\t// %ld 0x%lx", load_op, dst_fmt, value, value);
> | ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../../gcc/gcc/config/mcore/mcore.cc:1242:24: error: '
> subi ' directive writing 7 bytes into a region of size between 1 and 256 [-Werror=format-overflow=]
> 1242 | sprintf (buf, "%s\n\tsubi\t%s,%%2\t// %ld 0x%lx", load_op, dst_fmt, value, value);
> | ^~~~~~~~~~
> ../../gcc/gcc/config/mcore/mcore.cc:1242:21: note: using the range [0, 18446744073709551615] for directive argument
> 1242 | sprintf (buf, "%s\n\tsubi\t%s,%%2\t// %ld 0x%lx", load_op, dst_fmt, value, value);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../../gcc/gcc/config/mcore/mcore.cc:1242:15: note: 'sprintf' output between 22 and 311 bytes into a destination of size 256
> 1242 | sprintf (buf, "%s\n\tsubi\t%s,%%2\t// %ld 0x%lx", load_op, dst_fmt, value, value);
> | ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../../gcc/gcc/config/mcore/mcore.cc:1239:24: error: '
> addi ' directive writing 7 bytes into a region of size between 1 and 256 [-Werror=format-overflow=]
> 1239 | sprintf (buf, "%s\n\taddi\t%s,%%2\t// %ld 0x%lx", load_op, dst_fmt, value, value);
> | ^~~~~~~~~~
> ../../gcc/gcc/config/mcore/mcore.cc:1239:21: note: using the range [0, 18446744073709551615] for directive argument
> 1239 | sprintf (buf, "%s\n\taddi\t%s,%%2\t// %ld 0x%lx", load_op, dst_fmt, value, value);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../../gcc/gcc/config/mcore/mcore.cc:1239:15: note: 'sprintf' output between 22 and 311 bytes into a destination of size 256
> 1239 | sprintf (buf, "%s\n\taddi\t%s,%%2\t// %ld 0x%lx", load_op, dst_fmt, value, value);
> | ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../../gcc/gcc/config/mcore/mcore.cc:1236:24: error: '
> not ' directive writing 6 bytes into a region of size between 1 and 256 [-Werror=format-overflow=]
> 1236 | sprintf (buf, "%s\n\tnot\t%s\t// %ld 0x%lx", load_op, dst_fmt, value, value);
> | ^~~~~~~~~
> ../../gcc/gcc/config/mcore/mcore.cc:1236:21: note: using the range [0, 18446744073709551615] for directive argument
> 1236 | sprintf (buf, "%s\n\tnot\t%s\t// %ld 0x%lx", load_op, dst_fmt, value, value);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../../gcc/gcc/config/mcore/mcore.cc:1236:15: note: 'sprintf' output between 18 and 307 bytes into a destination of size 256
> 1236 | sprintf (buf, "%s\n\tnot\t%s\t// %ld 0x%lx", load_op, dst_fmt, value, value);
> | ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> cc1plus: all warnings being treated as errors
> make[1]: *** [Makefile:2461: mcore.o] Error 1
>
>
>
> gcc/ChangeLog:
>
> * config/mcore/mcore.cc (output_inline_const) Make buffer smaller to
> silence overflow warnings later on.
128 is probably still unnecessarily long, but OK.
jeff
prev parent reply other threads:[~2023-05-23 18:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-22 23:58 Jan-Benedict Glaw
2023-05-23 18:11 ` Jeff Law [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de90f2d2-6b71-64e6-de22-e8eb6bcbc091@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jbglaw@lug-owl.de \
--cc=nickc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).