* [PATCH] configure: deprecate --enable-link-mutex option
@ 2023-03-29 12:55 Martin Liška
2023-03-29 13:00 ` Jakub Jelinek
2023-03-29 13:02 ` Andreas Schwab
0 siblings, 2 replies; 6+ messages in thread
From: Martin Liška @ 2023-03-29 12:55 UTC (permalink / raw)
To: gcc-patches; +Cc: Jakub Jelinek
Ready to be installed?
Thanks,
Martin
PR bootstrap/109310
gcc/ChangeLog:
* configure.ac: Emit a warning for deprecated option
--enable-link-mutex.
* configure: Regenerate.
---
gcc/configure | 1 +
gcc/configure.ac | 1 +
2 files changed, 2 insertions(+)
diff --git a/gcc/configure b/gcc/configure
index 15086578533..09ae93ade1a 100755
--- a/gcc/configure
+++ b/gcc/configure
@@ -31468,6 +31468,7 @@ $as_echo "$do_link_mutex" >&6; }
if test "$do_link_mutex" = "yes"; then
DO_LINK_MUTEX=true
+ echo gcc/configure: WARNING: --enable-link-mutex is deprecated and will be removed in the next release, use --enable-link-serialization instead 1>&2
else
DO_LINK_MUTEX=false
fi
diff --git a/gcc/configure.ac b/gcc/configure.ac
index 120151c474a..13c1a85851c 100644
--- a/gcc/configure.ac
+++ b/gcc/configure.ac
@@ -7013,6 +7013,7 @@ AC_MSG_RESULT($do_link_mutex)
if test "$do_link_mutex" = "yes"; then
DO_LINK_MUTEX=true
+ echo gcc/configure: WARNING: --enable-link-mutex is deprecated and will be removed in the next release, use --enable-link-serialization instead 1>&2
else
DO_LINK_MUTEX=false
fi
--
2.40.0
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] configure: deprecate --enable-link-mutex option
2023-03-29 12:55 [PATCH] configure: deprecate --enable-link-mutex option Martin Liška
@ 2023-03-29 13:00 ` Jakub Jelinek
2023-03-29 13:05 ` Richard Biener
2023-03-29 13:02 ` Andreas Schwab
1 sibling, 1 reply; 6+ messages in thread
From: Jakub Jelinek @ 2023-03-29 13:00 UTC (permalink / raw)
To: Martin Liška; +Cc: gcc-patches
On Wed, Mar 29, 2023 at 02:55:01PM +0200, Martin Liška wrote:
> Ready to be installed?
> Thanks,
> Martin
>
> PR bootstrap/109310
>
> gcc/ChangeLog:
>
> * configure.ac: Emit a warning for deprecated option
> --enable-link-mutex.
> * configure: Regenerate.
LGTM.
> diff --git a/gcc/configure b/gcc/configure
> index 15086578533..09ae93ade1a 100755
> --- a/gcc/configure
> +++ b/gcc/configure
> @@ -31468,6 +31468,7 @@ $as_echo "$do_link_mutex" >&6; }
>
> if test "$do_link_mutex" = "yes"; then
> DO_LINK_MUTEX=true
> + echo gcc/configure: WARNING: --enable-link-mutex is deprecated and will be removed in the next release, use --enable-link-serialization instead 1>&2
> else
> DO_LINK_MUTEX=false
> fi
> diff --git a/gcc/configure.ac b/gcc/configure.ac
> index 120151c474a..13c1a85851c 100644
> --- a/gcc/configure.ac
> +++ b/gcc/configure.ac
> @@ -7013,6 +7013,7 @@ AC_MSG_RESULT($do_link_mutex)
>
> if test "$do_link_mutex" = "yes"; then
> DO_LINK_MUTEX=true
> + echo gcc/configure: WARNING: --enable-link-mutex is deprecated and will be removed in the next release, use --enable-link-serialization instead 1>&2
> else
> DO_LINK_MUTEX=false
> fi
> --
> 2.40.0
Jakub
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] configure: deprecate --enable-link-mutex option
2023-03-29 12:55 [PATCH] configure: deprecate --enable-link-mutex option Martin Liška
2023-03-29 13:00 ` Jakub Jelinek
@ 2023-03-29 13:02 ` Andreas Schwab
2023-03-29 13:05 ` Martin Liška
1 sibling, 1 reply; 6+ messages in thread
From: Andreas Schwab @ 2023-03-29 13:02 UTC (permalink / raw)
To: Martin Liška; +Cc: gcc-patches, Jakub Jelinek
On Mär 29 2023, Martin Liška wrote:
> diff --git a/gcc/configure.ac b/gcc/configure.ac
> index 120151c474a..13c1a85851c 100644
> --- a/gcc/configure.ac
> +++ b/gcc/configure.ac
> @@ -7013,6 +7013,7 @@ AC_MSG_RESULT($do_link_mutex)
>
> if test "$do_link_mutex" = "yes"; then
> DO_LINK_MUTEX=true
> + echo gcc/configure: WARNING: --enable-link-mutex is deprecated and will be removed in the next release, use --enable-link-serialization instead 1>&2
Please use AC_MSG_WARN.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] configure: deprecate --enable-link-mutex option
2023-03-29 13:02 ` Andreas Schwab
@ 2023-03-29 13:05 ` Martin Liška
0 siblings, 0 replies; 6+ messages in thread
From: Martin Liška @ 2023-03-29 13:05 UTC (permalink / raw)
To: Andreas Schwab; +Cc: gcc-patches, Jakub Jelinek
On 3/29/23 15:02, Andreas Schwab wrote:
> On Mär 29 2023, Martin Liška wrote:
>
>> diff --git a/gcc/configure.ac b/gcc/configure.ac
>> index 120151c474a..13c1a85851c 100644
>> --- a/gcc/configure.ac
>> +++ b/gcc/configure.ac
>> @@ -7013,6 +7013,7 @@ AC_MSG_RESULT($do_link_mutex)
>>
>> if test "$do_link_mutex" = "yes"; then
>> DO_LINK_MUTEX=true
>> + echo gcc/configure: WARNING: --enable-link-mutex is deprecated and will be removed in the next release, use --enable-link-serialization instead 1>&2
>
> Please use AC_MSG_WARN.
>
Good point Andreas, installed as 8b2766e87db.
Thanks,
Martin
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] configure: deprecate --enable-link-mutex option
2023-03-29 13:00 ` Jakub Jelinek
@ 2023-03-29 13:05 ` Richard Biener
2023-03-29 13:09 ` Martin Liška
0 siblings, 1 reply; 6+ messages in thread
From: Richard Biener @ 2023-03-29 13:05 UTC (permalink / raw)
To: Jakub Jelinek; +Cc: Martin Liška, gcc-patches
On Wed, Mar 29, 2023 at 3:01 PM Jakub Jelinek via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
> On Wed, Mar 29, 2023 at 02:55:01PM +0200, Martin Liška wrote:
> > Ready to be installed?
> > Thanks,
> > Martin
> >
> > PR bootstrap/109310
> >
> > gcc/ChangeLog:
> >
> > * configure.ac: Emit a warning for deprecated option
> > --enable-link-mutex.
> > * configure: Regenerate.
>
> LGTM.
I wonder if we can simply alias --enable-link-mutex to
--enable-link-serialization though.
> > diff --git a/gcc/configure b/gcc/configure
> > index 15086578533..09ae93ade1a 100755
> > --- a/gcc/configure
> > +++ b/gcc/configure
> > @@ -31468,6 +31468,7 @@ $as_echo "$do_link_mutex" >&6; }
> >
> > if test "$do_link_mutex" = "yes"; then
> > DO_LINK_MUTEX=true
> > + echo gcc/configure: WARNING: --enable-link-mutex is deprecated and will be removed in the next release, use --enable-link-serialization instead 1>&2
> > else
> > DO_LINK_MUTEX=false
> > fi
> > diff --git a/gcc/configure.ac b/gcc/configure.ac
> > index 120151c474a..13c1a85851c 100644
> > --- a/gcc/configure.ac
> > +++ b/gcc/configure.ac
> > @@ -7013,6 +7013,7 @@ AC_MSG_RESULT($do_link_mutex)
> >
> > if test "$do_link_mutex" = "yes"; then
> > DO_LINK_MUTEX=true
> > + echo gcc/configure: WARNING: --enable-link-mutex is deprecated and will be removed in the next release, use --enable-link-serialization instead 1>&2
> > else
> > DO_LINK_MUTEX=false
> > fi
> > --
> > 2.40.0
>
> Jakub
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] configure: deprecate --enable-link-mutex option
2023-03-29 13:05 ` Richard Biener
@ 2023-03-29 13:09 ` Martin Liška
0 siblings, 0 replies; 6+ messages in thread
From: Martin Liška @ 2023-03-29 13:09 UTC (permalink / raw)
To: Richard Biener, Jakub Jelinek; +Cc: gcc-patches
On 3/29/23 15:05, Richard Biener wrote:
> I wonder if we can simply alias --enable-link-mutex to
> --enable-link-serialization though.
Sure, we can. Do you want it for gcc-13 as well?
Cheers,
Martin
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-03-29 13:09 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-29 12:55 [PATCH] configure: deprecate --enable-link-mutex option Martin Liška
2023-03-29 13:00 ` Jakub Jelinek
2023-03-29 13:05 ` Richard Biener
2023-03-29 13:09 ` Martin Liška
2023-03-29 13:02 ` Andreas Schwab
2023-03-29 13:05 ` Martin Liška
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).