From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id 8B4053858CDB for ; Tue, 10 Jan 2023 08:32:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8B4053858CDB Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.cz Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 9AD3A67847; Tue, 10 Jan 2023 08:32:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1673339525; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nTxXZi5ApR+tXjN9RDtc/rolr0807Z7J6SojOu8l/Io=; b=Fcnr5mek1IDpCOztYQDh/4DATO4LP3Zhap6ehcQdNqkYDIwRugDwE1OihK6iLjXJhkTx5/ /2GPsg+Asi+tgJK0bacobWU23HAAloF684EcoX1aFBnb5LGJhNMWs04+V3slU0Rxzdny/O 2cTLEGawsfhjTtQdtHUYsEwmZgn0CyQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1673339525; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nTxXZi5ApR+tXjN9RDtc/rolr0807Z7J6SojOu8l/Io=; b=G0FBtyyI/ARVk2sbNNscJyUK91JIue9iJkVwQfGF4cMxpsq1PZckekI5OK2RaCvHqcyTjQ fP2MS/gK2t0HyQDg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 842E91358A; Tue, 10 Jan 2023 08:32:05 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 6LAsH4UivWN7FAAAMHmgww (envelope-from ); Tue, 10 Jan 2023 08:32:05 +0000 Message-ID: Date: Tue, 10 Jan 2023 09:32:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH] Remove legacy pre-C++ 11 definitions To: Jonathan Wakely Cc: Andrew Pinski , gcc-patches References: <6defa548-2da3-6cba-0372-f1e6c6b64c81@suse.cz> Content-Language: en-US From: =?UTF-8?Q?Martin_Li=c5=a1ka?= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 1/9/23 16:19, Jonathan Wakely wrote: > On Mon, 9 Jan 2023 at 15:17, Martin Liška wrote: >> >> On 1/6/23 19:23, Jonathan Wakely wrote: >>> Seems to me that GCC code should just use nullptr directly not redefine NULL. >> >> Sure, but that would lead to a huge patch which would rename NULL to nullptr, right? > > > Yeah, which can probably be done separately (or not done at all). That would be a massive patch affecting all targets and FEs. > I was just commenting on the comment that Andrew showed. That comment > explain that nullptr is better than 0 as a null pointer constant, > which is a good reason to prefer nullptr. But not a good reason to > redefine NULL; in code with a minimum requirement of C++11 you can > just use nullptr directly. Ok, so does it mean my patch addresses what can be easily adjusted? Thanks, Martin