Re: [PATCH] doc: Suggest fix for -Woverloaded-virtual warnings

[Jason Merrill <jason@redhat.com>]

On 2/15/23 05:37, Jonathan Wakely wrote:
> OK for trunk?

OK.

> -- >8 --
> 
> Users are confused about what this warning means, so add a suggested
> solution to the documentation.
> 
> gcc/ChangeLog:
> 
> 	* doc/invoke.texi (C++ Dialect Options): Suggest adding a
> 	using-declaration to unhide functions.
> ---
>   gcc/doc/invoke.texi | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi
> index 26de582e41e..6404ed5c4ff 100644
> --- a/gcc/doc/invoke.texi
> +++ b/gcc/doc/invoke.texi
> @@ -4282,6 +4282,10 @@ b->f();
>   @noindent
>   fails to compile.
>   
> +In cases where the different signatures are not an accident, the
> +simplest solution is to add a using-declaration to the derived class
> +to un-hide the base function, e.g. add @code{using A::f;} to @code{B}.
> +
>   The optional level suffix controls the behavior when all the
>   declarations in the derived class override virtual functions in the
>   base class, even if not all of the base functions are overridden: