From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 51EFE3858D37 for ; Wed, 20 Jul 2022 01:23:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 51EFE3858D37 Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 26K1Bt98001681; Wed, 20 Jul 2022 01:23:28 GMT Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3he7tyr8a8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 20 Jul 2022 01:23:28 +0000 Received: from m0098399.ppops.net (m0098399.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 26K1EkGs021942; Wed, 20 Jul 2022 01:23:28 GMT Received: from ppma06ams.nl.ibm.com (66.31.33a9.ip4.static.sl-reverse.com [169.51.49.102]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3he7tyr89e-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 20 Jul 2022 01:23:28 +0000 Received: from pps.filterd (ppma06ams.nl.ibm.com [127.0.0.1]) by ppma06ams.nl.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 26K1Klru007530; Wed, 20 Jul 2022 01:23:26 GMT Received: from b06cxnps4075.portsmouth.uk.ibm.com (d06relay12.portsmouth.uk.ibm.com [9.149.109.197]) by ppma06ams.nl.ibm.com with ESMTP id 3hbmkj4wx6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 20 Jul 2022 01:23:25 +0000 Received: from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com [9.149.105.62]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 26K1NNXm10813800 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 20 Jul 2022 01:23:23 GMT Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 579D2AE04D; Wed, 20 Jul 2022 01:23:23 +0000 (GMT) Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C5795AE045; Wed, 20 Jul 2022 01:23:21 +0000 (GMT) Received: from [9.197.246.191] (unknown [9.197.246.191]) by d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTP; Wed, 20 Jul 2022 01:23:21 +0000 (GMT) Message-ID: Date: Wed, 20 Jul 2022 09:23:20 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH, rs6000, v2] Additional cleanup of rs6000_builtin_mask Content-Language: en-US To: will schmidt Cc: David Edelsohn , Segher Boessenkool , GCC Patches References: From: "Kewen.Lin" In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: Ge_cVxzBnboA4umI4jMVCJnNaImeIJyL X-Proofpoint-GUID: sv4xzGXciyP9pjHxNIrEBPBhCARnTNaf X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-07-19_10,2022-07-19_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 malwarescore=0 suspectscore=0 spamscore=0 lowpriorityscore=0 mlxscore=0 mlxlogscore=999 impostorscore=0 adultscore=0 bulkscore=0 clxscore=1015 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000 definitions=main-2207200002 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Jul 2022 01:23:31 -0000 Hi Will, on 2022/7/20 04:15, will schmidt wrote: > [PATCH, rs6000, v2] Additional cleanup of rs6000_builtin_mask > > Hi, > Post the rs6000 builtins rewrite, some of the leftover builtin > code is redundant and can be removed. > This replaces the usage of bu_mask in rs6000_target_modify_macros > with checks against the rs6000_isa_flags equivalent directly. Thusly > the bu_mask variable can be removed. After this update there > are no other uses of rs6000_builtin_mask_calculate, so that function > can also be safely removed. > > No functional change, though some output under debug has been removed. > > [V2] > Per patch review and subsequent investigations, the > rs6000_builtin_mask and x_rs6000_builtin_mask can also be removed, as > well as the entirety of the rs6000_builtin_mask_names table. > I assumed this has been tested as before, so this patch is OK. Thanks! > gcc/ > * config/rs6000/rs6000-c.cc: Update comments. > (rs6000_target_modify_macros): Remove bu_mask references. > (rs6000_define_or_undefine_macro): Replace bu_mask reference > with a rs6000_cpu value check. > (rs6000_cpu_cpp_builtins): Remove rs6000_builtin_mask_calculate() > parameter from call to rs6000_target_modify_macros. > * config/rs6000/rs6000-protos.h (rs6000_target_modify_macros, > rs6000_target_modify_macros_ptr): Remove parameter from extern > for the prototype. > * config/rs6000/rs6000.cc (rs6000_target_modify_macros_ptr): Remove > parameter from prototype, update calls to this function. > (rs6000_print_builtin_options): Remove prototype, call and function. > (rs6000_builtin_mask_calculate): Remove function. > (rs6000_debug_reg_global): Remove call to rs6000_print_builtin_options. > (rs6000_option_override_internal): Remove rs6000_builtin_mask var > and builtin_mask debug output. > (rs6000_builtin_mask_names): Remove. > (rs6000_pragma_target_parse): Remove prev_bumask, cur_bumask, > diff_bumask references; Update calls to > rs6000_target_modify_ptr. Nit: this "rs6000_target_modify_ptr" seems not necessarily to start one new line. :) BR, Kewen > * config/rs6000/rs6000.opt (rs6000_builtin_mask): Remove. >