From: Bill Schmidt <wschmidt@linux.ibm.com>
To: Segher Boessenkool <segher@kernel.crashing.org>, gcc-patches@gcc.gnu.org
Cc: dje.gcc@gmail.com
Subject: Re: [PATCH 2/2] rs6000: Update darn testcases
Date: Fri, 17 Dec 2021 12:21:26 -0600 [thread overview]
Message-ID: <ded96ef2-336b-93ff-8b61-969249c35faf@linux.ibm.com> (raw)
In-Reply-To: <0f580655c2110d5258b202cb1d11cdb8f3f8589e.1639760570.git.segher@kernel.crashing.org>
Hi!
On 12/17/21 11:36 AM, Segher Boessenkool wrote:
> Make the darn testcases work (and be tested) in 32-bit mode as well.
> They used to ICE, but they no longer do.
>
>
> 2021-12-17 Segher Boessenkool <segher@kernel.crashing.org>
>
> gcc/testsuite/
> PR target/103624
> * gcc.target/powerpc/darn-0.c: Remove target clause.
> * gcc.target/powerpc/darn-1.c: Remove target clause. Remove lp64
> requirement. Change return type to long.
> * gcc.target/powerpc/darn-2.c: Ditto.
> * gcc.target/powerpc/darn-3.c: Remove target clause.
LGTM.
Thanks!
Bill
>
> ---
> gcc/testsuite/gcc.target/powerpc/darn-0.c | 2 +-
> gcc/testsuite/gcc.target/powerpc/darn-1.c | 5 ++---
> gcc/testsuite/gcc.target/powerpc/darn-2.c | 5 ++---
> gcc/testsuite/gcc.target/powerpc/darn-3.c | 2 +-
> 4 files changed, 6 insertions(+), 8 deletions(-)
>
> diff --git a/gcc/testsuite/gcc.target/powerpc/darn-0.c b/gcc/testsuite/gcc.target/powerpc/darn-0.c
> index f446f494b06d..64d98f5f91d7 100644
> --- a/gcc/testsuite/gcc.target/powerpc/darn-0.c
> +++ b/gcc/testsuite/gcc.target/powerpc/darn-0.c
> @@ -1,4 +1,4 @@
> -/* { dg-do compile { target { powerpc*-*-* } } } */
> +/* { dg-do compile } */
> /* { dg-require-effective-target powerpc_p9vector_ok } */
> /* { dg-skip-if "" { powerpc*-*-aix* } } */
> /* { dg-options "-mdejagnu-cpu=power9" } */
> diff --git a/gcc/testsuite/gcc.target/powerpc/darn-1.c b/gcc/testsuite/gcc.target/powerpc/darn-1.c
> index 0938718a5ad6..f483a89862d0 100644
> --- a/gcc/testsuite/gcc.target/powerpc/darn-1.c
> +++ b/gcc/testsuite/gcc.target/powerpc/darn-1.c
> @@ -1,12 +1,11 @@
> -/* { dg-do compile { target { powerpc*-*-* } } } */
> +/* { dg-do compile } */
> /* { dg-require-effective-target powerpc_p9vector_ok } */
> -/* { dg-require-effective-target lp64 } */
> /* { dg-skip-if "" { powerpc*-*-aix* } } */
> /* { dg-options "-mdejagnu-cpu=power9" } */
>
> #include <altivec.h>
>
> -long long get_conditioned_random ()
> +long get_conditioned_random ()
> {
> return __builtin_darn ();
> }
> diff --git a/gcc/testsuite/gcc.target/powerpc/darn-2.c b/gcc/testsuite/gcc.target/powerpc/darn-2.c
> index 64e44b244c4b..56a9ffb677b4 100644
> --- a/gcc/testsuite/gcc.target/powerpc/darn-2.c
> +++ b/gcc/testsuite/gcc.target/powerpc/darn-2.c
> @@ -1,12 +1,11 @@
> -/* { dg-do compile { target { powerpc*-*-* } } } */
> +/* { dg-do compile } */
> /* { dg-require-effective-target powerpc_p9vector_ok } */
> -/* { dg-require-effective-target lp64 } */
> /* { dg-skip-if "" { powerpc*-*-aix* } } */
> /* { dg-options "-mdejagnu-cpu=power9" } */
>
> #include <altivec.h>
>
> -long long get_raw_random ()
> +long get_raw_random ()
> {
> return __builtin_darn_raw ();
> }
> diff --git a/gcc/testsuite/gcc.target/powerpc/darn-3.c b/gcc/testsuite/gcc.target/powerpc/darn-3.c
> index 477901fde70d..4c68fad80d5d 100644
> --- a/gcc/testsuite/gcc.target/powerpc/darn-3.c
> +++ b/gcc/testsuite/gcc.target/powerpc/darn-3.c
> @@ -1,4 +1,4 @@
> -/* { dg-do compile { target { powerpc*-*-* } } } */
> +/* { dg-do compile } */
> /* { dg-skip-if "" { powerpc*-*-aix* } } */
> /* { dg-options "-O2 -mdejagnu-cpu=power9" } */
>
next prev parent reply other threads:[~2021-12-17 18:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-17 17:36 [PATCH 1/2] rs6000: Redo darn (PR103624) Segher Boessenkool
2021-12-17 17:36 ` [PATCH 2/2] rs6000: Update darn testcases Segher Boessenkool
2021-12-17 18:21 ` Bill Schmidt [this message]
2021-12-17 18:20 ` [PATCH 1/2] rs6000: Redo darn (PR103624) Bill Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ded96ef2-336b-93ff-8b61-969249c35faf@linux.ibm.com \
--to=wschmidt@linux.ibm.com \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).