From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tom@honermann.net>
Received: from smtp70.ord1c.emailsrvr.com (smtp70.ord1c.emailsrvr.com
 [108.166.43.70])
 by sourceware.org (Postfix) with ESMTPS id D9E45385829C
 for <gcc-patches@gcc.gnu.org>; Tue,  2 Aug 2022 18:02:49 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D9E45385829C
X-Auth-ID: tom@honermann.net
Received: by smtp9.relay.ord1c.emailsrvr.com (Authenticated sender:
 tom-AT-honermann.net) with ESMTPSA id 4C89420143; 
 Tue,  2 Aug 2022 14:02:46 -0400 (EDT)
Message-ID: <dee6ff9a-f13c-fa6a-1a9f-b1d4de17d91f@honermann.net>
Date: Tue, 2 Aug 2022 14:02:45 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH 2/3 v3] testsuite: Add tests for C2X N2653 char8_t and
 UTF-8 string literal changes
Content-Language: en-US
To: Joseph Myers <joseph@codesourcery.com>
Cc: gcc-patches@gcc.gnu.org
References: <20220725175948.1424695-3-tom@honermann.net>
 <20220801223945.1433166-1-tom@honermann.net>
 <alpine.DEB.2.22.394.2208021652220.861046@digraph.polyomino.org.uk>
From: Tom Honermann <tom@honermann.net>
In-Reply-To: <alpine.DEB.2.22.394.2208021652220.861046@digraph.polyomino.org.uk>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Classification-ID: 1ab51616-7e7a-46cb-9181-d1fa9f3174fc-1-1
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE,
 SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: gcc-patches@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 02 Aug 2022 18:02:50 -0000

On 8/2/22 12:53 PM, Joseph Myers wrote:
> On Mon, 1 Aug 2022, Tom Honermann via Gcc-patches wrote:
>
>> This change provides new tests for the core language and compiler
>> dependent library changes adopted for C2X via WG14 N2653.
> Could you please send a complete patch series?  I'm not sure what the
> matching patches 1 and 3 are.  Also, I don't generally find it helpful for
> tests to be separated from the patch making the changes they test, since
> tests are necessary to review of that code.

Absolutely. I'll merge the implementation and test commits, so the next 
series (v4) will have just two commits; one for the C2X N2653 
implementation and the other for the C++ u8 preprocessor string type 
fix. Coming right up.

Tom.