From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa1.mentor.iphmx.com (esa1.mentor.iphmx.com [68.232.129.153]) by sourceware.org (Postfix) with ESMTPS id 0AFEF3858D32 for ; Mon, 2 Jan 2023 10:20:43 +0000 (GMT) X-IronPort-AV: E=Sophos;i="5.96,293,1665475200"; d="scan'208";a="95128276" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa1.mentor.iphmx.com with ESMTP; 02 Jan 2023 02:20:41 -0800 IronPort-SDR: t9A2y06o9Li3LFo6DIXdt3Jcwe0xX62UjkRoEeUyqwLDsHSfgmsMZjWM1hbyzNb0PqlvgsoCWe HlUGcVucpRXANSJlx9j0W4ANqK0sozzvA0zjisBI9vUnBi5j+w6OsQXY+i+tMbkbnhp+CbvWiv XpqZ/1gUAXF+PjMT2gQDAMaZZc2cOpbUXeNRyMYooNEI0qGFqOqY3YpuuIBmx1A9zHmZI8S9O1 B/pQY0tMnlq4MnyYZjxY4PrhzAGsPxTEPfk8fyG6y459mAlGEIY10smiqR3qkf19/MsekmHLJh Q3M= Message-ID: Date: Mon, 2 Jan 2023 11:20:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH] [OpenMP] GC unused SIMD clones Content-Language: en-US To: Sandra Loosemore , "gcc-patches@gcc.gnu.org" CC: Jakub Jelinek References: From: Tobias Burnus In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-12.mgc.mentorg.com (139.181.222.12) To svr-ies-mbx-12.mgc.mentorg.com (139.181.222.12) X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,KAM_SHORT,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 25.11.22 03:13, Sandra Loosemore wrote: > This patch is a followup to my not-yet-reviewed patch > [PATCH v4] OpenMP: Generate SIMD clones for functions with "declare > target" That patch got reviewed and went into mainline on Nov 15, 2022 as https://gcc.gnu.org/r13-4309-g309e2d95e3b930c6f15c8a5346b913158404c76d > In comments on a previous iteration of that patch, I was asked to do > something to delete unused SIMD clones to avoid code bloat; this is it. > > I've implemented something like a simple mark-and-sweep algorithm. > Clones that are used are marked at the point where the call is > generated in the vectorizer. The loop that iterates over functions to > apply the passes after IPA is modified to defer processing of unmarked > clones, and anything left over is deleted. Jakub referred to Honza for the review, who wrote yesterday off list (to me and Sandra): > I am really sorry for taking so long time. It was busy month for me > and I was not very keen about the idea, since we had such logic > implemented many years ago but removed it to be able to determine > functions to be output early and optimize code layout. > > I see that this is not possible with current organization where > vectorization is run late, so I guess it does make sense to do what you > are doing. > > Patch is OK, > Honza Thanks for the review! (And to Sandra: thanks for the patch.) I leave it to Sandra to commit her patch and only want to update the gcc-patches@ email. However. I think we can expect a commit tomorrow. (Today is a holiday at her place - as new year's day fell on a Sunday.) Thanks and happy new year! Tobias ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe 201= , 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch=C3= =A4ftsf=C3=BChrer: Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellschaf= t: M=C3=BCnchen; Registergericht M=C3=BCnchen, HRB 106955