From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa2.mentor.iphmx.com (esa2.mentor.iphmx.com [68.232.141.98]) by sourceware.org (Postfix) with ESMTPS id 503DF3858CD1 for ; Thu, 23 Nov 2023 23:17:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 503DF3858CD1 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 503DF3858CD1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=68.232.141.98 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700781477; cv=none; b=FSFkbUJYQ+B6QHVlTGoepMB4uCyrguubev90dA7aKuIkCQVc9tAE7GarlI07p6KhNUqKecx3sENUgPY5MGwn59CCrFKWgzUsXoyvBkVvlvztTw1Fq+9C6W0eTdGSLHd/APoI8w936cbzkRUNR9THLvrMloeW+IYYpZgfHRNEMWg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700781477; c=relaxed/simple; bh=TFG6MOPatsZ7nljDu/uUYAM1nc6u3Joiq2LXvD4dir4=; h=Date:From:To:Subject:Message-ID:MIME-Version; b=tLs3oBuCLI6/LRrPavgnOSOvkIsVpFEr+LKKyzhtYjhESB60daOD9J2vhXwv9CK0eqvBAssQWqtYmfowpzRXybgDYLq4BePa5jBOoyBKYpiKR2zXvvi1iwpQ0JZuopjaEUyMrKLdI/AJ6qV3iPh+YDmc+qrdzt/7t0U+bmbnYjU= ARC-Authentication-Results: i=1; server2.sourceware.org X-CSE-ConnectionGUID: gygWadRRRWayZdlhy4RFsw== X-CSE-MsgGUID: e/f8LlfCSJ2Ulqbna8MZfQ== X-IronPort-AV: E=Sophos;i="6.04,222,1695715200"; d="scan'208";a="26389131" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa2.mentor.iphmx.com with ESMTP; 23 Nov 2023 15:17:55 -0800 IronPort-SDR: SX+IBuJX3pdBzBnVpeHqJYAQOdiHOypzyjOT9kJE9yCl7RDlMVYBk2qhunS8Ak9b33Myo52TMK gOe9lDbK+JrDUdFsfk6DVUxe8dDpkDcXe01ZLqZMhS214c9GXNb/27C7hRx2rn8qFNV9xSg+oh z1zXeLzdAq5oQlw99FBfF7TTewpWrsnyiJmxTFiCoWX4EX5XmC9YHxvxPhghTR99j91IUkyO3g DUo9H9xpP9sykpWBH48jcMyb7KUnkvpmZocZwEg50gDfEviBtn/qXE2YSYC91FKgZ/PeqVDPF3 0us= Date: Thu, 23 Nov 2023 23:17:50 +0000 From: Joseph Myers To: Martin Uecker CC: Subject: Re: [PATCH 1/4] c23: tag compatibility rules for struct and unions In-Reply-To: <3e5e3ecbfd65851bbee77c7c70644b50d3d0895a.camel@tugraz.at> Message-ID: References: <02a9b94e4d653b6f1b9f89a1b62187f46e871738.camel@tugraz.at> <3e5e3ecbfd65851bbee77c7c70644b50d3d0895a.camel@tugraz.at> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-13.mgc.mentorg.com (139.181.222.13) To svr-ies-mbx-10.mgc.mentorg.com (139.181.222.10) X-Spam-Status: No, score=-3103.1 required=5.0 tests=BAYES_00,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, 16 Nov 2023, Martin Uecker wrote: > * c-decl.cc (previous_tag): New function. > (get_parm_info): Turn off warning for C2X. C23 now, not C2X. > (comptypes_internal): Activate comparison of tagged > types (convert_for_assignment): Ingore qualifiers. This still has the "Ingore" typo. Also, add '.' and start a new line before "(convert_for_assignment)". > + /* Check for consistency with previous definition */ Missing '.' at end of comment. OK with those fixes. -- Joseph S. Myers joseph@codesourcery.com