public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* rs6000: Require ELFv2 ABI for ROP test (PR100750)
@ 2021-06-01 16:18 Bill Schmidt
  2021-06-02  0:44 ` Segher Boessenkool
  0 siblings, 1 reply; 3+ messages in thread
From: Bill Schmidt @ 2021-06-01 16:18 UTC (permalink / raw)
  To: GCC Patches; +Cc: Segher Boessenkool

Hi!  PR100750 reports a failure on my part to require the ELFv2 ABI for
one of the ROP tests.  This fixes that.

Tested on powerpc64-linux-gnu, committed as obvious.

Thanks!
Bill


PR100750: Require ELFv2 ABI for ROP test

2021-06-01  Bill Schmidt  <wschmidt@linux.ibm.com>

gcc/testsuite/
	PR testsuite/100750
	* gcc.target/powerpc/rop-5.c: Require ELFv2 ABI.

diff --git a/gcc/testsuite/gcc.target/powerpc/rop-5.c b/gcc/testsuite/gcc.target/powerpc/rop-5.c
index cf04ea90eeb..f2594df8a44 100644
--- a/gcc/testsuite/gcc.target/powerpc/rop-5.c
+++ b/gcc/testsuite/gcc.target/powerpc/rop-5.c
@@ -1,4 +1,5 @@
  /* { dg-do compile } */
+/* { dg-require-effective-target powerpc_elfv2 } */
  /* { dg-options "-O2 -mdejagnu-cpu=power10 -mrop-protect" } */
  
  /* Verify that __ROP_PROTECT__ is predefined for -mrop-protect.  */


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: rs6000: Require ELFv2 ABI for ROP test (PR100750)
  2021-06-01 16:18 rs6000: Require ELFv2 ABI for ROP test (PR100750) Bill Schmidt
@ 2021-06-02  0:44 ` Segher Boessenkool
  2021-06-03 14:40   ` Bill Schmidt
  0 siblings, 1 reply; 3+ messages in thread
From: Segher Boessenkool @ 2021-06-02  0:44 UTC (permalink / raw)
  To: Bill Schmidt; +Cc: GCC Patches

On Tue, Jun 01, 2021 at 11:18:05AM -0500, Bill Schmidt wrote:
> Hi!  PR100750 reports a failure on my part to require the ELFv2 ABI for
> one of the ROP tests.  This fixes that.

It would be nice if we had a selector for when we can use -mrop-protect,
instead of assuming it is only for ELFv2.


Segher

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: rs6000: Require ELFv2 ABI for ROP test (PR100750)
  2021-06-02  0:44 ` Segher Boessenkool
@ 2021-06-03 14:40   ` Bill Schmidt
  0 siblings, 0 replies; 3+ messages in thread
From: Bill Schmidt @ 2021-06-03 14:40 UTC (permalink / raw)
  To: Segher Boessenkool; +Cc: GCC Patches

On 6/1/21 7:44 PM, Segher Boessenkool wrote:
> It would be nice if we had a selector for when we can use -mrop-protect,
> instead of assuming it is only for ELFv2.
>
Agreed -- I'll take a note and try to get to this sometime.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-06-03 14:40 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-01 16:18 rs6000: Require ELFv2 ABI for ROP test (PR100750) Bill Schmidt
2021-06-02  0:44 ` Segher Boessenkool
2021-06-03 14:40   ` Bill Schmidt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).