From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x22e.google.com (mail-oi1-x22e.google.com [IPv6:2607:f8b0:4864:20::22e]) by sourceware.org (Postfix) with ESMTPS id 1308A3858C56 for ; Sun, 10 Dec 2023 20:43:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1308A3858C56 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1308A3858C56 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::22e ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702241007; cv=none; b=vk+t7cxNtNaN2lgde4OUSjC0jET/mOYZpBQlwSg98jZetF6IkuJq0AO2N2QRSJ9QywvV8U4ewVfRlNzl3h+/9LEfWATE+iMPLy55V5Cp2HI48DsN5LfRavW2LTxV6Xy9Utq9gNNvO1jauraI5m+aSeKBqtW9hn5zyXKTWbgKAMU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702241007; c=relaxed/simple; bh=IQsh4Xo9Jwe6FsioWt4F2XdIeJpZXAaPK/TL051ZwAE=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=dXNp+Cj8kBGCBiVS4w7g48QSMaLmKFCIPnywjV9DWF7hHg75eOuWHGhXR87DOFoxtMe9k9uO3eC7YmgODkwIMtII7ougjNYq5QJdiz4qRHg8BLHVlRESFHwyiCS5WE5G34F8h2NPZznL1CZVSHgPTp7Rwg8Fl/77axMyutIDRb0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-oi1-x22e.google.com with SMTP id 5614622812f47-3b9dbbaa9a9so3180868b6e.2 for ; Sun, 10 Dec 2023 12:43:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702241005; x=1702845805; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=RFWT1w8vK5mIm5NeXzmc20K5nNeX11JFIO08jG1+XFU=; b=H38goh4KVjW+OY3z2sNRtHbVHCmmCeOvcsX1Ws+a/us1+r8XcWheJCvPPDVWw05Ga9 q94s8DuYxLvHztS0VdiBsf9IZLL3ceICc0fGzJaEwJ7PE1oDFsQhjTGxmn1BktTyyCLr VD1es4w0lEw3qJg5peABgjner6ytVHyuNMLfH+pClQ4sBPdbaIXBe6dZTZ07evB0qYFR dpXJxe/HJMRxkipyJ3VZagWm4z4Bre0EtgiCdfv1KY1WWZT+v/17EiBdZMa3l9sCYi6F vrb+7ZBBiRZHT1XsVHjQ9EOEjEAMf2NmoKJpUtI0IcsyQaPZAH6qk8e0s8XvnBDbHcby /rqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702241005; x=1702845805; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RFWT1w8vK5mIm5NeXzmc20K5nNeX11JFIO08jG1+XFU=; b=Xop0JlFiSWhEkFx80w1bqsL7YzZ2wml72c5ur3dEypxlHHdqkr+sO0dlBYBwf84M06 vIXBLWKVUKQKinGHF+XvHXZ1n1Q5QWgckE/z4SM8mhLOECnCM0h9O64UVs8Wafrh9Xtr c6NYyuUH6I7Ng1hi1YgCQ0YdmosO/HwCPhl7acJSQv5bPMyPsUdDShkRQkqrgGot5PJJ blWiuAUbZ8VzMOVj7wPHXXnITzjw6RZYQ7LZgufUHUBlXGTUsAYAWll5xOFBW/k5Xjd8 +9YbIsFT2ZKzD9DR1fu2enXoknb+3NGCrIng9ZEUYV+n80i8tC8aqq8+RvIJhRHsE0Sj OAkg== X-Gm-Message-State: AOJu0YyeETrsQuuLrv8gfnoIkgM3SuYAavP4OKCUyNrgxz5HzyLI9zmF 4AYDQAXwaKyyGXfazHa0fIE= X-Google-Smtp-Source: AGHT+IEfp1pMnivB0MyllX7OSLG2GCZD5gzm/09jm1nnZJi1e0ZJu6mj04+opvNN/3y0fVrVE9PvlQ== X-Received: by 2002:a05:6808:e83:b0:3b9:e828:820 with SMTP id k3-20020a0568080e8300b003b9e8280820mr4266435oil.38.1702241005083; Sun, 10 Dec 2023 12:43:25 -0800 (PST) Received: from [172.31.0.109] ([136.36.72.243]) by smtp.gmail.com with ESMTPSA id g12-20020a056a0023cc00b006cde2889213sm5119913pfc.14.2023.12.10.12.43.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 10 Dec 2023 12:43:24 -0800 (PST) Message-ID: Date: Sun, 10 Dec 2023 13:43:18 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/5] [ifcvt] optimize x=c ? (y shift_op z):y by RISC-V Zicond like insns Content-Language: en-US To: Fei Gao , gcc-patches@gcc.gnu.org Cc: kito.cheng@gmail.com, palmer@dabbelt.com, zengxiao@eswincomputing.com References: <20231205081248.2106-1-gaofei@eswincomputing.com> <20231205081248.2106-2-gaofei@eswincomputing.com> From: Jeff Law In-Reply-To: <20231205081248.2106-2-gaofei@eswincomputing.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/5/23 01:12, Fei Gao wrote: > op=[ASHIFT, ASHIFTRT, LSHIFTRT, ROTATE, ROTATERT] > > Conditional op, if zero > rd = (rc == 0) ? (rs1 op rs2) : rs1 > --> > czero.nez rd, rs2, rc > op rd, rs1, rd > > Conditional op, if non-zero > rd = (rc != 0) ? (rs1 op rs2) : rs1 > --> > czero.eqz rd, rs2, rc > op rd, rs1, rd > > Co-authored-by: Xiao Zeng > > gcc/ChangeLog: > > * ifcvt.cc (noce_cond_zero_binary_op_supported): add support for shift like op. > (get_base_reg): add support for subreg to handle shift amount operand. > (noce_bbs_ok_for_cond_zero_arith): to replace shift amount operand. > > gcc/testsuite/ChangeLog: > > * gcc.target/riscv/zicond_ifcvt_opt.c: add TCs for shift like op. So I removed the SUBREG handling code which makes this patch merely an addition of the shift/rotate ops which trivally work just like PLUS, MINUS, IOR, XOR (by conditionally zero-ing the shift count) tested on x86 and pushed it to the trunk. As I noted before while I think handling SUBREGs is important, now is not the time to be adding that support. Thanks! jeff