From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by sourceware.org (Postfix) with ESMTP id D6538385DDDE for ; Tue, 11 Jun 2024 14:31:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D6538385DDDE Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D6538385DDDE Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=217.140.110.172 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718116296; cv=none; b=LKjYjkejh+6TZcvl5W9m64kaZy5Tu7lYWIHUrrHjm5TrHv3B0gik9N8T0XePgdw5LMsp5PXmnHyRM4+4ERuTOzqmnbeBsDrVGQx+BlZP1mCq4HgI9jVS5xcjK3UzDSONow1FPCIBxyWGnxfH9zc925IU0czTuZ/DIxXbeS7uIoU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718116296; c=relaxed/simple; bh=+iuEFKgDb4Szv5jdaNjMVMsRESp1fCEcTVVCMp/xPYE=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=inxbavNtPVBg+mE4GcKw6LjhPfF5SeXHjoqBhyEKqziyzRbGb8iVPMLQAhsjw04sD9GbScEIpRaJMY6R1GCrorHGWOX9zt2K+p/cktk69pwKTtL5zyd9Jm51FWHVrB/DJalB5HVCbDkc5LDh1Dzz4/o7eZatqjfUGx+ry1KB68E= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DCC27152B; Tue, 11 Jun 2024 07:31:58 -0700 (PDT) Received: from [10.1.32.72] (PW03YX1L.arm.com [10.1.32.72]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7068F3F5A1; Tue, 11 Jun 2024 07:31:33 -0700 (PDT) Message-ID: Date: Tue, 11 Jun 2024 15:31:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v3 1/2] arm: Zero/Sign extends for CMSE security on Armv8-M.baseline [PR115253] To: "Richard Earnshaw (lists)" , =?UTF-8?Q?Torbj=c3=b6rn_SVENSSON?= , gcc-patches@gcc.gnu.org Cc: Richard.Ball@arm.com, christophe.lyon@linaro.org, yvan.roux@foss.st.com References: <51e7905e-60da-27ae-19c1-286128899e93@arm.com> <20240610140437.966245-1-torbjorn.svensson@foss.st.com> <20240610140437.966245-2-torbjorn.svensson@foss.st.com> <526c9082-7e1e-492b-877b-52cac9d64353@arm.com> Content-Language: en-US From: "Andre Vieira (lists)" In-Reply-To: <526c9082-7e1e-492b-877b-52cac9d64353@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-8.4 required=5.0 tests=BAYES_00,KAM_DMARC_NONE,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,NICE_REPLY_A,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/06/2024 14:59, Richard Earnshaw (lists) wrote: > You effectively have an 'else if' split across a comment here, and the indentation looks weird. Either write 'else if' on one line (and re-indent accordingly) or put this entire block inside braces. Apologies here, Torbjorn had this as an else if before, but I found that structure slightly more difficult to read because it wasn't entirely clear the else if and else were both for the 'SIGNED' handling, so I have a small preference for the 'or put this entire block inside braces'. Kind Regards, Andre