Re: [PATCH] S/390: Fix PR91628

[Stefan Liebler <stli@linux.ibm.com>]

On 4/1/20 6:20 PM, Stefan Liebler wrote:
> On 4/1/20 12:50 PM, Iain Buclaw wrote:
>>
>>
>> On 01/04/2020 08:28, Stefan Liebler wrote:
>>> ping
>>>
>>
>> Hi Stefan,
>>
>> As I've already said, I think that the name should be 
>> __ibmz_get_tls_offset to make clear that it is an internal function.
>>
>> Other than that, looks good to me.
>>
>> Iain.
>>
> 
> Hi Iain,
> 
> Sorry. I've missed your comment in the bugzilla.
> I've updated the name to __ibmz_get_this_offset.
> Nothing else is changed in the attached patch.
> 
> Please commit the patch upstream.
> Do you also close the bugzilla as soon as committed?
> 
> Regarding the mentioned musl-patch in your bugzilla comment:
> Yes, the diff looks like not conflicting.
> 
> Thanks,
> Stefan

Hi Iain,

Andreas has just committed the other patch "S/390: Fix layout of struct 
sigaction_t" to gcc after your pull-request was merged 
(https://github.com/dlang/druntime/pull/3020).

To me it seems that this patch is not simply pull-request-able to 
https://github.com/dlang/druntime.
As you've already mentioned "Other than that, looks good to me.", is 
this gcc patch okay to commit from your side? Then Andreas can also 
commit it and we can close the bugzilla.

Bye,
Stefan