From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id C1480385DC0F for ; Tue, 7 Apr 2020 14:33:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org C1480385DC0F Received: from pps.filterd (m0098416.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 037EVjN6005764 for ; Tue, 7 Apr 2020 10:33:08 -0400 Received: from e06smtp03.uk.ibm.com (e06smtp03.uk.ibm.com [195.75.94.99]) by mx0b-001b2d01.pphosted.com with ESMTP id 306kuwksaj-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 07 Apr 2020 10:33:08 -0400 Received: from localhost by e06smtp03.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 7 Apr 2020 15:32:54 +0100 Received: from b06cxnps3075.portsmouth.uk.ibm.com (9.149.109.195) by e06smtp03.uk.ibm.com (192.168.101.133) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Tue, 7 Apr 2020 15:32:51 +0100 Received: from d06av23.portsmouth.uk.ibm.com (d06av23.portsmouth.uk.ibm.com [9.149.105.59]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 037EX2CZ62718002 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 7 Apr 2020 14:33:02 GMT Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 268D1A4057; Tue, 7 Apr 2020 14:33:02 +0000 (GMT) Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id EAAFAA4040; Tue, 7 Apr 2020 14:33:01 +0000 (GMT) Received: from oc4452167425.ibm.com (unknown [9.145.15.9]) by d06av23.portsmouth.uk.ibm.com (Postfix) with ESMTP; Tue, 7 Apr 2020 14:33:01 +0000 (GMT) Subject: Re: [PATCH] S/390: Fix PR91628 From: Stefan Liebler To: Iain Buclaw , GCC Patches References: <0afe1b58-2544-98c2-b056-a724f1a5fa6d@linux.ibm.com> <349a43fc-2a10-19ee-c7f0-ee18b29722e4@linux.ibm.com> <15b5b45f-de91-91df-3fb7-3befc0a6ffa4@gdcproject.org> <8c0973a2-58c6-fb2b-9511-406047001639@linux.ibm.com> Date: Tue, 7 Apr 2020 16:33:01 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <8c0973a2-58c6-fb2b-9511-406047001639@linux.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 20040714-0012-0000-0000-000003A00A2E X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 20040714-0013-0000-0000-000021DD2BD0 Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.676 definitions=2020-04-07_06:2020-04-07, 2020-04-07 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 adultscore=0 malwarescore=0 priorityscore=1501 impostorscore=0 suspectscore=0 phishscore=0 mlxlogscore=999 clxscore=1015 spamscore=0 lowpriorityscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2004070123 X-Spam-Status: No, score=-8.5 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, KAM_NUMSUBJECT, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Apr 2020 14:33:09 -0000 On 4/1/20 6:20 PM, Stefan Liebler wrote: > On 4/1/20 12:50 PM, Iain Buclaw wrote: >> >> >> On 01/04/2020 08:28, Stefan Liebler wrote: >>> ping >>> >> >> Hi Stefan, >> >> As I've already said, I think that the name should be >> __ibmz_get_tls_offset to make clear that it is an internal function. >> >> Other than that, looks good to me. >> >> Iain. >> > > Hi Iain, > > Sorry. I've missed your comment in the bugzilla. > I've updated the name to __ibmz_get_this_offset. > Nothing else is changed in the attached patch. > > Please commit the patch upstream. > Do you also close the bugzilla as soon as committed? > > Regarding the mentioned musl-patch in your bugzilla comment: > Yes, the diff looks like not conflicting. > > Thanks, > Stefan Hi Iain, Andreas has just committed the other patch "S/390: Fix layout of struct sigaction_t" to gcc after your pull-request was merged (https://github.com/dlang/druntime/pull/3020). To me it seems that this patch is not simply pull-request-able to https://github.com/dlang/druntime. As you've already mentioned "Other than that, looks good to me.", is this gcc patch okay to commit from your side? Then Andreas can also commit it and we can close the bugzilla. Bye, Stefan