From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id B713F3858D20; Thu, 31 Aug 2023 05:07:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B713F3858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0353725.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 37V472UV028191; Thu, 31 Aug 2023 05:07:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : in-reply-to : references : message-id : content-type : content-transfer-encoding : mime-version; s=pp1; bh=EWGDkHE3hdpZvxVJBCJMCtMhR4Js1WnFns99FaImWk0=; b=Rkb96M8bJYQepIeWOjhMKWKQZtfbZnaKkNBzERgZQr+UXzDXXK5UXr6aP7o8mPGNdjR+ 8PMXKJijAB/n6LCxJPMA8oVM1Z+4k4FkF5QCeepGk1sik3Uy66attwjFAGVh/xqpvDKt aRh8OnW7XEYJRqXhFXoF6Z6+XhRPZZ41HCOZEWfX1sqrd5zNMcOqoEhH1I+oyADg7s/G vRtc/berRK96lekh2tv3KRlt5ZNs2jsG575CrSLO+TLO/TKumb4mbS8Uf7BWzC1oooJV pF8Yrx04PLKYhcRc7gRikPQSXFLzP3Hnt98abc4OFj8uDSPXhy/EVxna2QgNo+YLU9UR lA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3stbexksuf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 31 Aug 2023 05:07:44 +0000 Received: from m0353725.ppops.net (m0353725.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 37V4wv1B024738; Thu, 31 Aug 2023 05:07:44 GMT Received: from ppma11.dal12v.mail.ibm.com (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3stbexkstu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 31 Aug 2023 05:07:44 +0000 Received: from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1]) by ppma11.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 37V3641k019188; Thu, 31 Aug 2023 05:07:43 GMT Received: from smtprelay05.wdc07v.mail.ibm.com ([172.16.1.72]) by ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 3sqxe213xx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 31 Aug 2023 05:07:43 +0000 Received: from smtpav03.dal12v.mail.ibm.com (smtpav03.dal12v.mail.ibm.com [10.241.53.102]) by smtprelay05.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 37V57gnd54329730 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 31 Aug 2023 05:07:42 GMT Received: from smtpav03.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5B5E15803F; Thu, 31 Aug 2023 05:07:42 +0000 (GMT) Received: from smtpav03.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id DE3F358064; Thu, 31 Aug 2023 05:07:41 +0000 (GMT) Received: from ltc.linux.ibm.com (unknown [9.5.196.140]) by smtpav03.dal12v.mail.ibm.com (Postfix) with ESMTP; Thu, 31 Aug 2023 05:07:41 +0000 (GMT) Date: Thu, 31 Aug 2023 13:07:41 +0800 From: guojiufu To: Andrew MacLeod Cc: gcc-patches@gcc.gnu.org, aldyh@redhat.com, rguenther@suse.de, jeffreyalaw@gmail.com, richard.sandiford@arm.com, segher@kernel.crashing.org, dje.gcc@gmail.com, linkw@gcc.gnu.org, bergner@linux.ibm.com Subject: Re: [PATCH V5 1/2] Add overflow API for plus minus mult on range In-Reply-To: References: <20230718140544.3497370-1-guojiufu@linux.ibm.com> <7n3510yila.fsf@ltcden2-lp1.aus.stglabs.ibm.com> Message-ID: X-Sender: guojiufu@linux.ibm.com Content-Type: text/plain; charset=US-ASCII; format=flowed X-TM-AS-GCONF: 00 X-Proofpoint-GUID: 9tRAUOr-JFJvCrbMgJ-n4BQeZVEgXoVv X-Proofpoint-ORIG-GUID: mXVNc1NH9ghHzMA2GOPU0ExL39Zxw1YS Content-Transfer-Encoding: 7bit X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.601,FMLib:17.11.176.26 definitions=2023-08-31_02,2023-08-29_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0 lowpriorityscore=0 adultscore=0 spamscore=0 mlxscore=0 clxscore=1015 priorityscore=1501 impostorscore=0 mlxlogscore=999 phishscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2308100000 definitions=main-2308310045 X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2023-08-03 21:18, Andrew MacLeod wrote: > This is OK. > Thanks a lot! Committed via r14-3582. BR, Jeff (Jiufu Guo) > > On 8/2/23 22:18, Jiufu Guo wrote: >> Hi, >> >> I would like to have a ping on this patch. >> >> BR, >> Jeff (Jiufu Guo) >> >> >> Jiufu Guo writes: >> >>> Hi, >>> >>> As discussed in previous reviews, adding overflow APIs to range-op >>> would be useful. Those APIs could help to check if overflow happens >>> when operating between two 'range's, like: plus, minus, and mult. >>> >>> Previous discussions are here: >>> https://gcc.gnu.org/pipermail/gcc-patches/2023-July/624067.html >>> https://gcc.gnu.org/pipermail/gcc-patches/2023-July/624701.html >>> >>> Bootstrap & regtest pass on ppc64{,le} and x86_64. >>> Is this patch ok for trunk? >>> >>> BR, >>> Jeff (Jiufu Guo) >>> >>> gcc/ChangeLog: >>> >>> * range-op-mixed.h (operator_plus::overflow_free_p): New declare. >>> (operator_minus::overflow_free_p): New declare. >>> (operator_mult::overflow_free_p): New declare. >>> * range-op.cc (range_op_handler::overflow_free_p): New function. >>> (range_operator::overflow_free_p): New default function. >>> (operator_plus::overflow_free_p): New function. >>> (operator_minus::overflow_free_p): New function. >>> (operator_mult::overflow_free_p): New function. >>> * range-op.h (range_op_handler::overflow_free_p): New declare. >>> (range_operator::overflow_free_p): New declare. >>> * value-range.cc (irange::nonnegative_p): New function. >>> (irange::nonpositive_p): New function. >>> * value-range.h (irange::nonnegative_p): New declare. >>> (irange::nonpositive_p): New declare. >>> >>> --- >>> gcc/range-op-mixed.h | 11 ++++ >>> gcc/range-op.cc | 124 >>> +++++++++++++++++++++++++++++++++++++++++++ >>> gcc/range-op.h | 5 ++ >>> gcc/value-range.cc | 12 +++++ >>> gcc/value-range.h | 2 + >>> 5 files changed, 154 insertions(+) >>> >>> diff --git a/gcc/range-op-mixed.h b/gcc/range-op-mixed.h >>> index 6944742ecbc..42157ed9061 100644 >>> --- a/gcc/range-op-mixed.h >>> +++ b/gcc/range-op-mixed.h >>> @@ -383,6 +383,10 @@ public: >>> relation_kind rel) const final override; >>> void update_bitmask (irange &r, const irange &lh, >>> const irange &rh) const final override; >>> + >>> + virtual bool overflow_free_p (const irange &lh, const irange &rh, >>> + relation_trio = TRIO_VARYING) const; >>> + >>> private: >>> void wi_fold (irange &r, tree type, const wide_int &lh_lb, >>> const wide_int &lh_ub, const wide_int &rh_lb, >>> @@ -446,6 +450,10 @@ public: >>> relation_kind rel) const final override; >>> void update_bitmask (irange &r, const irange &lh, >>> const irange &rh) const final override; >>> + >>> + virtual bool overflow_free_p (const irange &lh, const irange &rh, >>> + relation_trio = TRIO_VARYING) const; >>> + >>> private: >>> void wi_fold (irange &r, tree type, const wide_int &lh_lb, >>> const wide_int &lh_ub, const wide_int &rh_lb, >>> @@ -525,6 +533,9 @@ public: >>> const REAL_VALUE_TYPE &lh_lb, const REAL_VALUE_TYPE &lh_ub, >>> const REAL_VALUE_TYPE &rh_lb, const REAL_VALUE_TYPE &rh_ub, >>> relation_kind kind) const final override; >>> + virtual bool overflow_free_p (const irange &lh, const irange &rh, >>> + relation_trio = TRIO_VARYING) const; >>> + >>> }; >>> class operator_addr_expr : public range_operator >>> diff --git a/gcc/range-op.cc b/gcc/range-op.cc >>> index cb584314f4c..632b044331b 100644 >>> --- a/gcc/range-op.cc >>> +++ b/gcc/range-op.cc >>> @@ -366,6 +366,22 @@ range_op_handler::op1_op2_relation (const vrange >>> &lhs) const >>> } >>> } >>> +bool >>> +range_op_handler::overflow_free_p (const vrange &lh, >>> + const vrange &rh, >>> + relation_trio rel) const >>> +{ >>> + gcc_checking_assert (m_operator); >>> + switch (dispatch_kind (lh, lh, rh)) >>> + { >>> + case RO_III: >>> + return m_operator->overflow_free_p(as_a (lh), >>> + as_a (rh), >>> + rel); >>> + default: >>> + return false; >>> + } >>> +} >>> // Convert irange bitmasks into a VALUE MASK pair suitable for >>> calling CCP. >>> @@ -688,6 +704,13 @@ range_operator::op1_op2_relation_effect >>> (irange &lhs_range ATTRIBUTE_UNUSED, >>> return false; >>> } >>> +bool >>> +range_operator::overflow_free_p (const irange &, const irange &, >>> + relation_trio) const >>> +{ >>> + return false; >>> +} >>> + >>> // Apply any known bitmask updates based on this operator. >>> void >>> @@ -4311,6 +4334,107 @@ range_op_table::initialize_integral_ops () >>> } >>> +bool >>> +operator_plus::overflow_free_p (const irange &lh, const irange &rh, >>> + relation_trio) const >>> +{ >>> + if (lh.undefined_p () || rh.undefined_p ()) >>> + return false; >>> + >>> + tree type = lh.type (); >>> + if (TYPE_OVERFLOW_UNDEFINED (type)) >>> + return true; >>> + >>> + wi::overflow_type ovf; >>> + signop sgn = TYPE_SIGN (type); >>> + wide_int wmax0 = lh.upper_bound (); >>> + wide_int wmax1 = rh.upper_bound (); >>> + wi::add (wmax0, wmax1, sgn, &ovf); >>> + if (ovf != wi::OVF_NONE) >>> + return false; >>> + >>> + if (TYPE_UNSIGNED (type)) >>> + return true; >>> + >>> + wide_int wmin0 = lh.lower_bound (); >>> + wide_int wmin1 = rh.lower_bound (); >>> + wi::add (wmin0, wmin1, sgn, &ovf); >>> + if (ovf != wi::OVF_NONE) >>> + return false; >>> + >>> + return true; >>> +} >>> + >>> +bool >>> +operator_minus::overflow_free_p (const irange &lh, const irange &rh, >>> + relation_trio) const >>> +{ >>> + if (lh.undefined_p () || rh.undefined_p ()) >>> + return false; >>> + >>> + tree type = lh.type (); >>> + if (TYPE_OVERFLOW_UNDEFINED (type)) >>> + return true; >>> + >>> + wi::overflow_type ovf; >>> + signop sgn = TYPE_SIGN (type); >>> + wide_int wmin0 = lh.lower_bound (); >>> + wide_int wmax1 = rh.upper_bound (); >>> + wi::sub (wmin0, wmax1, sgn, &ovf); >>> + if (ovf != wi::OVF_NONE) >>> + return false; >>> + >>> + if (TYPE_UNSIGNED (type)) >>> + return true; >>> + >>> + wide_int wmax0 = lh.upper_bound (); >>> + wide_int wmin1 = rh.lower_bound (); >>> + wi::sub (wmax0, wmin1, sgn, &ovf); >>> + if (ovf != wi::OVF_NONE) >>> + return false; >>> + >>> + return true; >>> +} >>> + >>> +bool >>> +operator_mult::overflow_free_p (const irange &lh, const irange &rh, >>> + relation_trio) const >>> +{ >>> + if (lh.undefined_p () || rh.undefined_p ()) >>> + return false; >>> + >>> + tree type = lh.type (); >>> + if (TYPE_OVERFLOW_UNDEFINED (type)) >>> + return true; >>> + >>> + wi::overflow_type ovf; >>> + signop sgn = TYPE_SIGN (type); >>> + wide_int wmax0 = lh.upper_bound (); >>> + wide_int wmax1 = rh.upper_bound (); >>> + wi::mul (wmax0, wmax1, sgn, &ovf); >>> + if (ovf != wi::OVF_NONE) >>> + return false; >>> + >>> + if (TYPE_UNSIGNED (type)) >>> + return true; >>> + >>> + wide_int wmin0 = lh.lower_bound (); >>> + wide_int wmin1 = rh.lower_bound (); >>> + wi::mul (wmin0, wmin1, sgn, &ovf); >>> + if (ovf != wi::OVF_NONE) >>> + return false; >>> + >>> + wi::mul (wmin0, wmax1, sgn, &ovf); >>> + if (ovf != wi::OVF_NONE) >>> + return false; >>> + >>> + wi::mul (wmax0, wmin1, sgn, &ovf); >>> + if (ovf != wi::OVF_NONE) >>> + return false; >>> + >>> + return true; >>> +} >>> + >>> #if CHECKING_P >>> #include "selftest.h" >>> diff --git a/gcc/range-op.h b/gcc/range-op.h >>> index af94c2756a7..db3b03f28a5 100644 >>> --- a/gcc/range-op.h >>> +++ b/gcc/range-op.h >>> @@ -147,6 +147,9 @@ public: >>> virtual relation_kind op1_op2_relation (const irange &lhs) >>> const; >>> virtual relation_kind op1_op2_relation (const frange &lhs) const; >>> + >>> + virtual bool overflow_free_p (const irange &lh, const irange &rh, >>> + relation_trio = TRIO_VARYING) const; >>> protected: >>> // Perform an integral operation between 2 sub-ranges and return >>> it. >>> virtual void wi_fold (irange &r, tree type, >>> @@ -214,6 +217,8 @@ public: >>> const vrange &op2, >>> relation_kind = VREL_VARYING) const; >>> relation_kind op1_op2_relation (const vrange &lhs) const; >>> + bool overflow_free_p (const vrange &lh, const vrange &rh, >>> + relation_trio = TRIO_VARYING) const; >>> protected: >>> unsigned dispatch_kind (const vrange &lhs, const vrange &op1, >>> const vrange& op2) const; >>> diff --git a/gcc/value-range.cc b/gcc/value-range.cc >>> index 011bdbdeae6..5ae4e044194 100644 >>> --- a/gcc/value-range.cc >>> +++ b/gcc/value-range.cc >>> @@ -313,6 +313,18 @@ add_vrange (const vrange &v, inchash::hash >>> &hstate, >>> } //namespace inchash >>> +bool >>> +irange::nonnegative_p () const >>> +{ >>> + return wi::ge_p (lower_bound (), 0, TYPE_SIGN (type ())); >>> +} >>> + >>> +bool >>> +irange::nonpositive_p () const >>> +{ >>> + return wi::le_p (upper_bound (), 0, TYPE_SIGN (type ())); >>> +} >>> + >>> bool >>> irange::supports_type_p (const_tree type) const >>> { >>> diff --git a/gcc/value-range.h b/gcc/value-range.h >>> index 0170188201b..a12dea514e4 100644 >>> --- a/gcc/value-range.h >>> +++ b/gcc/value-range.h >>> @@ -280,6 +280,8 @@ public: >>> virtual bool singleton_p (tree *result = NULL) const override; >>> bool singleton_p (wide_int &) const; >>> bool contains_p (const wide_int &) const; >>> + bool nonnegative_p () const; >>> + bool nonpositive_p () const; >>> // In-place operators. >>> virtual bool union_ (const vrange &) override;