From: Jeff Law <law@redhat.com>
To: Richard Biener <richard.guenther@gmail.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [RFA] [PR tree-optimization/71661] Fix forwarder removal when new loops are exposed
Date: Thu, 06 Oct 2016 15:38:00 -0000 [thread overview]
Message-ID: <dfa64802-16cf-5c18-5774-0bd8af61fc93@redhat.com> (raw)
In-Reply-To: <CAFiYyc3ekEOE8QU-m72YE++CKLrqPnFyHzpaBmqoF3wmCvXHxw@mail.gmail.com>
On 10/06/2016 04:11 AM, Richard Biener wrote:
>
> The remove_forwarder_block hunk is redundant (I've fixed a similar bug there
> by checking in tree_forwarder_block_p). This function doesn't operate from
> a worklist and thus shouldn't have the issue.
Agreed. I hadn't really looked closely at remove_forwarder_block, but
it has the same check for newly exposed infinite loops so my patch added
the check for new loop headers in both places. But I agree it isn't
necessary here when I look at how remove_forwarder_block is used.
>
> The remove_forwarder_block_with_phi hunk is ok.
I'll extract/install just the remove_forwarder_block_with_phi hunk & the
testcase.
Thanks,
jeff
prev parent reply other threads:[~2016-10-06 15:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-05 15:59 Jeff Law
2016-10-06 10:11 ` Richard Biener
2016-10-06 15:38 ` Jeff Law [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dfa64802-16cf-5c18-5774-0bd8af61fc93@redhat.com \
--to=law@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=richard.guenther@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).