From: Nathan Sidwell <nathan@acm.org>
To: Jakub Jelinek <jakub@redhat.com>,
"Joseph S. Myers" <joseph@codesourcery.com>,
Marek Polacek <polacek@redhat.com>,
Jason Merrill <jason@redhat.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Reject too large string literals (PR middle-end/87854)
Date: Fri, 16 Nov 2018 12:06:00 -0000 [thread overview]
Message-ID: <dfd90e3c-6349-d058-c714-fbe873c2ece5@acm.org> (raw)
In-Reply-To: <20181116084325.GD11625@tucnak>
On 11/16/18 3:43 AM, Jakub Jelinek wrote:
> Hi!
>
> Both C and C++ FE diagnose arrays larger than half of the address space:
> /tmp/1.c:1:6: error: size of array ‘a’ is too large
> char a[__SIZE_MAX__ / 2 + 1];
> ^
> because one can't do pointer arithmetics on them. But we don't have
> anything similar for string literals. As internally we use host int
> as TREE_STRING_LENGTH, this is relevant to targets that have < 32-bit
> size_t only.
>
> The following patch adds that diagnostics and truncates the string literals.
Ok by me.
nathan
--
Nathan Sidwell
next prev parent reply other threads:[~2018-11-16 12:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-16 8:43 Jakub Jelinek
2018-11-16 12:06 ` Nathan Sidwell [this message]
2018-11-16 14:33 ` Marek Polacek
2018-11-16 17:35 ` Joseph Myers
2018-11-16 18:25 ` Martin Sebor
2018-11-16 18:31 ` Jakub Jelinek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dfd90e3c-6349-d058-c714-fbe873c2ece5@acm.org \
--to=nathan@acm.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=jason@redhat.com \
--cc=joseph@codesourcery.com \
--cc=polacek@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).