From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x534.google.com (mail-pg1-x534.google.com [IPv6:2607:f8b0:4864:20::534]) by sourceware.org (Postfix) with ESMTPS id 6330D3858D20 for ; Wed, 31 May 2023 16:28:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6330D3858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com Received: by mail-pg1-x534.google.com with SMTP id 41be03b00d2f7-5304d0d1eddso2947935a12.2 for ; Wed, 31 May 2023 09:28:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20221208.gappssmtp.com; s=20221208; t=1685550533; x=1688142533; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=4O0W9h9SlJOG1PuZ6n6kFVfP8Mjmzp39lh1HGbUZ46A=; b=v6A42j8l9jddaqqywAAgqL+iGQJ4sSML91zt7K85fVg6cSm8DYhfCMm8DP28/Th7lH NX9PSK3Y4F4knXxA3I4LscvtTUf5XDaNz4/n4fyD/Kwxj5wMhJ9FU1P3sry6d9U4BFbw aN4uK+MQb/jtYgZB/443IMHf+Pz0WzOMLrZO4t++ytK5JV+yLTOfAh/cGdwl+oVRDo1Q lPEgE0g9KREIviaLFfYB/yZQqG2DzgkAtbPQ9VTwZJsbzcfqIrU+15IEl1DA92AJkxTh ZA1pkZ9cWNNdzGmLIPELjFT1B/7px82c9WziYhYeEZZ9IB0zh6oBwngawNpzu2PtgpPz 5I7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685550533; x=1688142533; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4O0W9h9SlJOG1PuZ6n6kFVfP8Mjmzp39lh1HGbUZ46A=; b=fyowYz4/h4/g3/G8upFkVPmUd/F4GAKrM/S/m2I9VjoDzbiDXgFc5mrMd0sEDS25IH uBxEv9QdK+vCiiHqZ7LQrUKPidZsYAH6N50atv/+rs16DS2cKWnQcCbndEvhXhR+nMHO XOKUbtqwIy/ijjsKAlxo5U5GAA9GyxsPgmDBh3eSdXoizKvNA9sIYfnG/B52YkRs3A14 UgmdUCnhKTbyobvPoz1n4j/lxmZogvbO7G7eBlUL9hO5vxqd3e2t5fcjnz3/i6z4721M //JuGwP8ooQPSTArNuXiBVJYwMKCWreRdXHj9NVYC2rNRZS+cv5hB5gFuoJpDAC5PgYy 2HYg== X-Gm-Message-State: AC+VfDyLhWJKRESW8sJhNNKLPRXYdI0IyPl8R0dUkOoD7mlJp8PbRJWz FkxBuxOGxj+Hg6wmbq40vZs31g== X-Google-Smtp-Source: ACHHUZ5lVtv99FfXi+I2AAf8Vz2WgwEF72hy24lBvcXT4Wp2EwrLr7G86OSWcfUncrLdMAzYlbh5+Q== X-Received: by 2002:a17:902:ab8b:b0:1ae:6882:5bc4 with SMTP id f11-20020a170902ab8b00b001ae68825bc4mr4230746plr.64.1685550533218; Wed, 31 May 2023 09:28:53 -0700 (PDT) Received: from [192.168.50.116] ([71.202.114.183]) by smtp.gmail.com with ESMTPSA id b7-20020a170902650700b001b04dfbe5d0sm1558911plk.309.2023.05.31.09.28.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 31 May 2023 09:28:52 -0700 (PDT) Message-ID: Date: Wed, 31 May 2023 09:28:51 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH] RISC-V: Add missing torture-init and torture-finish for rvv.exp Content-Language: en-US From: Vineet Gupta To: Thomas Schwinge , Kito Cheng Cc: gcc-patches@gcc.gnu.org, kito.cheng@gmail.com, patrick@rivosinc.com, jlaw@ventanamicro.com, "Maciej W . Rozycki" , Palmer Dabbelt References: <20230522064138.74056-1-kito.cheng@sifive.com> <87jzwxsc3b.fsf@dem-tschwing-1.ger.mentorg.com> <5070d049-f3ee-e175-4bad-21cd2528e42b@rivosinc.com> <87sfbkqhrq.fsf@dem-tschwing-1.ger.mentorg.com> <7297b31f-2447-e4da-5b74-65cee515c7cd@rivosinc.com> <2c20cb10-e0d6-8591-b8f6-57ee9ba3bfa4@rivosinc.com> In-Reply-To: <2c20cb10-e0d6-8591-b8f6-57ee9ba3bfa4@rivosinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,KAM_SHORT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 5/30/23 11:43, Vineet Gupta wrote: > On 5/26/23 16:38, Vineet Gupta wrote: >> >> >> On 5/25/23 13:26, Thomas Schwinge wrote: >> >>>> I'm pasting a snippet of gcc.log. Issue is indeed triggered by rvv.exp >>>> which needs some love. >>> I'd intentionally asked to "see a complete 'gcc.log' file where the >>> ERRORs are visible". >> >> The full log files are humongous - even xz compressed is ~ 7 MB - how >> can I share that w/o the list dropping it. >> I guess I can try emailing it you directly on work email - if that's OK. >> >>>> The torture-{init,finish} needs to be in riscv.exp not rvv.exp >>>> Running full tests now. >>> I still don't understand this. >>> >>> My current theory would be that some other '*.exp' file runs >>> 'torture-init' and then prematurely ends without 'torture-finish', and >>> thus the torture testing state bleeds into the next '*.exp' >>> file(s).  I'd >>> hoped that I could pinpoint that via "a complete 'gcc.log' file >>> where the >>> ERRORs are visible". >> >> Seems likely. So back to good old printf style debugging: I added >> dumping of the dup options to see what exactly was leaking. >> >> setup #1 >>  - riscv.exp: Added torture-init/finish >>  - Deleted rvv.exp (to isolate the problem) >> >> ... >> >> Setup #2 >>  - riscv.exp: Added torture-init/finish >>  - riscv.exp: commented away ADDITIONAL_TORTURE_OPTIONS line >>  - rvv.exp remains, unchanged >> >> ... > > In the 3rd setup, I've removed riscv.exp and rvv.exp and running the > testsuite: errors still show. > > So we are iterating over multilib combinations. > Things are fine for the first one. The initial flags comprise of > DG_TORTURE_OPTIONS from gcc-dg.exp (-O0, -O1 ....) > However when the 2nd multilib runs, it seems the old ones are not > getting cleared, hence the splat. I've posted the fix [1] . printf/send_user() to the rescue ! @Thomas I fat fingered the send and missed CC'ing you on the patches. Thx, -Vineet [1] https://gcc.gnu.org/pipermail/gcc-patches/2023-May/620263.html