From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 95130388456D for ; Wed, 19 Jun 2024 12:42:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 95130388456D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 95130388456D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.156.1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718800938; cv=none; b=W9IOJbRVuuFGwV8/jGX2QpFQnehe20FRGLHeTw0VvEP672ab1NMB4e2A53MaAkRvM+Uqyr8ZoYDGZnZjp33Pv31UYYnvY7rltaIIynYNKi/2XpkM7qE0N4nN0gIGWrnlG06LizsH4rzDDDvuwD4od9X5tTvh5ilrIoZyLpAjzZo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718800938; c=relaxed/simple; bh=AqmKotT8pQ5BW1yARDaf0yUCNdvPjkCnWshWKUVqT6o=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:From:To; b=FTMBnT2jcWVEE0l5GyqMyZJGYQtHG7Gnw53NFF0lj8cQ7PPOtAkYE7pZs7NgrP6io4IbZ6PbVrZlwdf+KB5FWnbmVznHpFqwV6vBHioPFvwv31FC7s7yKRpo+4EImVuBUBbL60015zmm5MHiUpsl39xgr5io9O8Kgkj6/Nvj77Y= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0353726.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 45JCQJr3020829; Wed, 19 Jun 2024 12:42:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h= message-id:date:mime-version:subject:from:to:cc:references :in-reply-to:content-type:content-transfer-encoding; s=pp1; bh=N Bq7/1nrLEMqRL0rqBAysQrcyKj5G1x9ahwdGhrcVi4=; b=AZ/Hnrp/BixmbfUTh z2Ps+Wjg62q8h8baBgr/pgDX3TQvn4srOieZRM0MPORlmrcFp4eP7ha2aw3aY31T BlebM22/ji9Z3ZeKPIfjGaydA8R3R4ujtK8U5D+PK/M9CKYHApJcIkEqGi1LYFPd laaFVUaqBTHmm9vF8Dq511oC6wbSrO9EguIosc4m9FCr0siwC0x8N47PxBXY0cxb KxFpuqnGORqX3QaHdnfLywhnf6P3vhPszRcuQSoSMI0YcSt+HJSf8kU4BHz7NKag ky02MDlnKrBz4wGU6wnY03qVP7RZqJgYWskmwE+WlB0IrveceRv1C6ja1A/+1ExR 31dxw== Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3yuv9p8haw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 19 Jun 2024 12:42:15 +0000 (GMT) Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 45JCGSXW011442; Wed, 19 Jun 2024 12:42:14 GMT Received: from smtprelay05.wdc07v.mail.ibm.com ([172.16.1.72]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3yspsnc8dk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 19 Jun 2024 12:42:14 +0000 Received: from smtpav05.wdc07v.mail.ibm.com (smtpav05.wdc07v.mail.ibm.com [10.39.53.232]) by smtprelay05.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 45JCgB9K25035456 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 19 Jun 2024 12:42:13 GMT Received: from smtpav05.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0707C5805D; Wed, 19 Jun 2024 12:42:11 +0000 (GMT) Received: from smtpav05.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 7C3B45805F; Wed, 19 Jun 2024 12:42:09 +0000 (GMT) Received: from [9.109.208.217] (unknown [9.109.208.217]) by smtpav05.wdc07v.mail.ibm.com (Postfix) with ESMTP; Wed, 19 Jun 2024 12:42:09 +0000 (GMT) Message-ID: Date: Wed, 19 Jun 2024 18:12:07 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PING^3][PATCH v2] rs6000: Fix issue in specifying PTImode as an attribute [PR106895] From: jeevitha To: GCC Patches , "Kewen.Lin" , Segher Boessenkool Cc: Peter Bergner References: <9ea38d87-180f-46b5-a723-45061680980f@linux.vnet.ibm.com> <92507c51-9ff0-4e67-8a6c-7ffb58bc8537@linux.vnet.ibm.com> <67c3e4d1-d507-4dd1-be2d-3469927d1482@linux.vnet.ibm.com> <10a5ebae-8fb0-4017-9279-c60ec6f0d104@linux.ibm.com> <29544069-fe4e-4ddc-a0cc-f3582ec26b6a@linux.ibm.com> Content-Language: en-US In-Reply-To: <29544069-fe4e-4ddc-a0cc-f3582ec26b6a@linux.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: uEhB7Oe4stI2psQ9oxh0rkE95Is3ljKz X-Proofpoint-ORIG-GUID: uEhB7Oe4stI2psQ9oxh0rkE95Is3ljKz X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-06-19_02,2024-06-19_01,2024-05-17_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 mlxscore=0 phishscore=0 lowpriorityscore=0 impostorscore=0 suspectscore=0 spamscore=0 bulkscore=0 mlxlogscore=999 clxscore=1015 priorityscore=1501 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2405170001 definitions=main-2406190092 X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Ping! Please review. Are there any more changes required? Thanks & Regards Jeevitha On 21/05/24 10:28 am, jeevitha wrote: > Ping! > > please review. > > Thanks & Regards > Jeevitha > > > On 17/04/24 2:44 pm, jeevitha wrote: >> Ping! >> >> I've incorporated all the suggested changes. Please review. >> >> Thanks & Regards >> Jeevitha >> >> On 21/03/24 6:21 pm, jeevitha wrote: >>> Hi All, >>> >>> The following patch has been bootstrapped and regtested on powerpc64le-linux. >>> >>> PTImode assists in generating even/odd register pairs on 128 bits. When the user >>> specifies PTImode as an attribute, it breaks because there is no internal type >>> to handle this mode. To address this, we have created a tree node with dummy type >>> to handle PTImode. We are not documenting this dummy type since users are not >>> allowed to use this type externally. >>> >>> 2024-03-21 Jeevitha Palanisamy >>> >>> gcc/ >>> PR target/110411 >>> * config/rs6000/rs6000.h (enum rs6000_builtin_type_index): Add >>> RS6000_BTI_INTPTI. >>> * config/rs6000/rs6000-builtin.cc (rs6000_init_builtins): Add node >>> for PTImode type. >>> >>> gcc/testsuite/ >>> PR target/106895 >>> * gcc.target/powerpc/pr106895.c: New testcase. >>> >>> diff --git a/gcc/config/rs6000/rs6000-builtin.cc b/gcc/config/rs6000/rs6000-builtin.cc >>> index 6698274031b..f553c72779e 100644 >>> --- a/gcc/config/rs6000/rs6000-builtin.cc >>> +++ b/gcc/config/rs6000/rs6000-builtin.cc >>> @@ -756,6 +756,15 @@ rs6000_init_builtins (void) >>> else >>> ieee128_float_type_node = NULL_TREE; >>> >>> + /* PTImode to get even/odd register pairs. */ >>> + intPTI_type_internal_node = make_node(INTEGER_TYPE); >>> + TYPE_PRECISION (intPTI_type_internal_node) = GET_MODE_BITSIZE (PTImode); >>> + layout_type (intPTI_type_internal_node); >>> + SET_TYPE_MODE (intPTI_type_internal_node, PTImode); >>> + t = build_qualified_type (intPTI_type_internal_node, TYPE_QUAL_CONST); >>> + lang_hooks.types.register_builtin_type (intPTI_type_internal_node, >>> + "__dummypti"); >>> + >>> /* Vector pair and vector quad support. */ >>> vector_pair_type_node = make_node (OPAQUE_TYPE); >>> SET_TYPE_MODE (vector_pair_type_node, OOmode); >>> diff --git a/gcc/config/rs6000/rs6000.h b/gcc/config/rs6000/rs6000.h >>> index 68bc45d65ba..b6078077b20 100644 >>> --- a/gcc/config/rs6000/rs6000.h >>> +++ b/gcc/config/rs6000/rs6000.h >>> @@ -2302,6 +2302,7 @@ enum rs6000_builtin_type_index >>> RS6000_BTI_ptr_vector_quad, >>> RS6000_BTI_ptr_long_long, >>> RS6000_BTI_ptr_long_long_unsigned, >>> + RS6000_BTI_INTPTI, >>> RS6000_BTI_MAX >>> }; >>> >>> @@ -2346,6 +2347,7 @@ enum rs6000_builtin_type_index >>> #define uintDI_type_internal_node (rs6000_builtin_types[RS6000_BTI_UINTDI]) >>> #define intTI_type_internal_node (rs6000_builtin_types[RS6000_BTI_INTTI]) >>> #define uintTI_type_internal_node (rs6000_builtin_types[RS6000_BTI_UINTTI]) >>> +#define intPTI_type_internal_node (rs6000_builtin_types[RS6000_BTI_INTPTI]) >>> #define float_type_internal_node (rs6000_builtin_types[RS6000_BTI_float]) >>> #define double_type_internal_node (rs6000_builtin_types[RS6000_BTI_double]) >>> #define long_double_type_internal_node (rs6000_builtin_types[RS6000_BTI_long_double]) >>> diff --git a/gcc/testsuite/gcc.target/powerpc/pr106895.c b/gcc/testsuite/gcc.target/powerpc/pr106895.c >>> new file mode 100644 >>> index 00000000000..56547b7fa9d >>> --- /dev/null >>> +++ b/gcc/testsuite/gcc.target/powerpc/pr106895.c >>> @@ -0,0 +1,15 @@ >>> +/* PR target/106895 */ >>> +/* { dg-require-effective-target int128 } */ >>> +/* { dg-options "-O2" } */ >>> + >>> +/* Verify the following generates even/odd register pairs. */ >>> + >>> +typedef __int128 pti __attribute__((mode(PTI))); >>> + >>> +void >>> +set128 (pti val, pti *mem) >>> +{ >>> + asm("stq %1,%0" : "=m"(*mem) : "r"(val)); >>> +} >>> + >>> +/* { dg-final { scan-assembler "stq \[123\]?\[02468\]" } } */ >>> >>>