From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21206 invoked by alias); 1 Dec 2016 12:40:06 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 21176 invoked by uid 89); 1 Dec 2016 12:40:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.4 required=5.0 tests=BAYES_00,MEDICAL_SUBJECT,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=readmdc, read-md.c, errorsc, sk:reimple X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 01 Dec 2016 12:40:03 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A89B980518 for ; Thu, 1 Dec 2016 12:40:02 +0000 (UTC) Received: from localhost.localdomain (vpn1-7-50.ams2.redhat.com [10.36.7.50]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uB1Ce1xT022552; Thu, 1 Dec 2016 07:40:01 -0500 Subject: Re: [PATCH] Minimal reimplementation of errors.c within read-md.c To: David Malcolm , gcc-patches@gcc.gnu.org References: <6dd1c122-29bc-cd0b-51eb-8d0b83d3f08d@redhat.com> <1480537449-64700-1-git-send-email-dmalcolm@redhat.com> From: Bernd Schmidt Message-ID: Date: Thu, 01 Dec 2016 12:40:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1480537449-64700-1-git-send-email-dmalcolm@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2016-12/txt/msg00061.txt.bz2 On 11/30/2016 09:24 PM, David Malcolm wrote: > gcc/ChangeLog: > * read-md.c (have_error): New global, copied from errors.c. > (fatal): New function, copied from errors.c. I would have expected the function to go into diagnostic.c, but actually there are already various functions of this sort in read-md. I'd request you place it near fatal_at, and maybe add this to errors.h: inline bool seen_error () { return have_error; } and replace explicit uses of have_error with that to unify things a bit. Bernd