From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 429693858C5E for ; Thu, 3 Aug 2023 13:18:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 429693858C5E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1691068704; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=b6QRyUdGiFz+iAdD/L/calmULM6t8BNIJhgYiYJfkCI=; b=FCckTkuj2Jr/7FQIyX2efUgaeSnEGVguk7qi7lLQ5tbULyPzEN8mUwM+3ybLh0MR+XAvTX P3nUZhgB9C+NswN/7ZmeS1AulR++G93KgVwIf8fO3r+30CiTHCWzBW9bjdpOcsazqr5Epc s66yEASC6t3hThkubp/ZjKtREZ9NmcU= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-590-mFrMWs-jMv24C-oGLw0XCA-1; Thu, 03 Aug 2023 09:18:21 -0400 X-MC-Unique: mFrMWs-jMv24C-oGLw0XCA-1 Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-767b778582eso127802485a.2 for ; Thu, 03 Aug 2023 06:18:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691068700; x=1691673500; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=b6QRyUdGiFz+iAdD/L/calmULM6t8BNIJhgYiYJfkCI=; b=MKEPPKsLIFPleDMbP/oHGEAxdd5l6Y1TbJw1U3K1XZHqm5xruACWsJC/YZNCxuNTqy 6aeSH5g8t5xuf/po0xYEACqQRDSS/E9mNryZdf1WXwuRrorNv+7aFWhNqleeJaGFA9VN GftLCXSvGtJkz5XHXAhuyQ6Wt7rzjZMw18DNcEWWXn7ERhNBwve/fYhMgRAD9Iy/ROuE yoD3psOt7bfH72ivHInjvE5epwCN6Tm+Ys5XoL3JFe0dUU0CxBbosUyW/nOXNGb7HMRg NknZG/Xn0fDlRmVwIMkaHhEGDyUhDbZB0NcTSFk8EsoSLbUNaWeZ69w/WcMe9nTx2L5h wWug== X-Gm-Message-State: AOJu0Yy2SMz75wepHMItTo44PV+O3PT7iZZ+QAc0ZBT7kYvWAMK48qUw Sohutcb1e7tDglw+xxbJ8tKGFZLj6aMCCXfTZQx2SolSN9HOl8tvybgkAv4yuhPJUQLgUuSczY8 wDfxhk0Z/w9eORFUNDw== X-Received: by 2002:a05:620a:8d7:b0:76c:e63b:3102 with SMTP id z23-20020a05620a08d700b0076ce63b3102mr1132972qkz.40.1691068700421; Thu, 03 Aug 2023 06:18:20 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHcnrlCiRutvQzdUFhVyD/nPvFUEhKHoBdhfFeNtGkILooZz0/ktUkmpZfDpxMsghsZ+yYM/w== X-Received: by 2002:a05:620a:8d7:b0:76c:e63b:3102 with SMTP id z23-20020a05620a08d700b0076ce63b3102mr1132948qkz.40.1691068700081; Thu, 03 Aug 2023 06:18:20 -0700 (PDT) Received: from [192.168.0.174] ([104.219.124.192]) by smtp.gmail.com with ESMTPSA id e2-20020a05620a12c200b0076cb3690ae7sm3199263qkl.68.2023.08.03.06.18.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Aug 2023 06:18:19 -0700 (PDT) Message-ID: Date: Thu, 3 Aug 2023 09:18:18 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH V5 1/2] Add overflow API for plus minus mult on range To: Jiufu Guo , gcc-patches@gcc.gnu.org Cc: aldyh@redhat.com, rguenther@suse.de, jeffreyalaw@gmail.com, richard.sandiford@arm.com, segher@kernel.crashing.org, dje.gcc@gmail.com, linkw@gcc.gnu.org, bergner@linux.ibm.com References: <20230718140544.3497370-1-guojiufu@linux.ibm.com> <7n3510yila.fsf@ltcden2-lp1.aus.stglabs.ibm.com> From: Andrew MacLeod In-Reply-To: <7n3510yila.fsf@ltcden2-lp1.aus.stglabs.ibm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is OK. On 8/2/23 22:18, Jiufu Guo wrote: > Hi, > > I would like to have a ping on this patch. > > BR, > Jeff (Jiufu Guo) > > > Jiufu Guo writes: > >> Hi, >> >> As discussed in previous reviews, adding overflow APIs to range-op >> would be useful. Those APIs could help to check if overflow happens >> when operating between two 'range's, like: plus, minus, and mult. >> >> Previous discussions are here: >> https://gcc.gnu.org/pipermail/gcc-patches/2023-July/624067.html >> https://gcc.gnu.org/pipermail/gcc-patches/2023-July/624701.html >> >> Bootstrap & regtest pass on ppc64{,le} and x86_64. >> Is this patch ok for trunk? >> >> BR, >> Jeff (Jiufu Guo) >> >> gcc/ChangeLog: >> >> * range-op-mixed.h (operator_plus::overflow_free_p): New declare. >> (operator_minus::overflow_free_p): New declare. >> (operator_mult::overflow_free_p): New declare. >> * range-op.cc (range_op_handler::overflow_free_p): New function. >> (range_operator::overflow_free_p): New default function. >> (operator_plus::overflow_free_p): New function. >> (operator_minus::overflow_free_p): New function. >> (operator_mult::overflow_free_p): New function. >> * range-op.h (range_op_handler::overflow_free_p): New declare. >> (range_operator::overflow_free_p): New declare. >> * value-range.cc (irange::nonnegative_p): New function. >> (irange::nonpositive_p): New function. >> * value-range.h (irange::nonnegative_p): New declare. >> (irange::nonpositive_p): New declare. >> >> --- >> gcc/range-op-mixed.h | 11 ++++ >> gcc/range-op.cc | 124 +++++++++++++++++++++++++++++++++++++++++++ >> gcc/range-op.h | 5 ++ >> gcc/value-range.cc | 12 +++++ >> gcc/value-range.h | 2 + >> 5 files changed, 154 insertions(+) >> >> diff --git a/gcc/range-op-mixed.h b/gcc/range-op-mixed.h >> index 6944742ecbc..42157ed9061 100644 >> --- a/gcc/range-op-mixed.h >> +++ b/gcc/range-op-mixed.h >> @@ -383,6 +383,10 @@ public: >> relation_kind rel) const final override; >> void update_bitmask (irange &r, const irange &lh, >> const irange &rh) const final override; >> + >> + virtual bool overflow_free_p (const irange &lh, const irange &rh, >> + relation_trio = TRIO_VARYING) const; >> + >> private: >> void wi_fold (irange &r, tree type, const wide_int &lh_lb, >> const wide_int &lh_ub, const wide_int &rh_lb, >> @@ -446,6 +450,10 @@ public: >> relation_kind rel) const final override; >> void update_bitmask (irange &r, const irange &lh, >> const irange &rh) const final override; >> + >> + virtual bool overflow_free_p (const irange &lh, const irange &rh, >> + relation_trio = TRIO_VARYING) const; >> + >> private: >> void wi_fold (irange &r, tree type, const wide_int &lh_lb, >> const wide_int &lh_ub, const wide_int &rh_lb, >> @@ -525,6 +533,9 @@ public: >> const REAL_VALUE_TYPE &lh_lb, const REAL_VALUE_TYPE &lh_ub, >> const REAL_VALUE_TYPE &rh_lb, const REAL_VALUE_TYPE &rh_ub, >> relation_kind kind) const final override; >> + virtual bool overflow_free_p (const irange &lh, const irange &rh, >> + relation_trio = TRIO_VARYING) const; >> + >> }; >> >> class operator_addr_expr : public range_operator >> diff --git a/gcc/range-op.cc b/gcc/range-op.cc >> index cb584314f4c..632b044331b 100644 >> --- a/gcc/range-op.cc >> +++ b/gcc/range-op.cc >> @@ -366,6 +366,22 @@ range_op_handler::op1_op2_relation (const vrange &lhs) const >> } >> } >> >> +bool >> +range_op_handler::overflow_free_p (const vrange &lh, >> + const vrange &rh, >> + relation_trio rel) const >> +{ >> + gcc_checking_assert (m_operator); >> + switch (dispatch_kind (lh, lh, rh)) >> + { >> + case RO_III: >> + return m_operator->overflow_free_p(as_a (lh), >> + as_a (rh), >> + rel); >> + default: >> + return false; >> + } >> +} >> >> // Convert irange bitmasks into a VALUE MASK pair suitable for calling CCP. >> >> @@ -688,6 +704,13 @@ range_operator::op1_op2_relation_effect (irange &lhs_range ATTRIBUTE_UNUSED, >> return false; >> } >> >> +bool >> +range_operator::overflow_free_p (const irange &, const irange &, >> + relation_trio) const >> +{ >> + return false; >> +} >> + >> // Apply any known bitmask updates based on this operator. >> >> void >> @@ -4311,6 +4334,107 @@ range_op_table::initialize_integral_ops () >> >> } >> >> +bool >> +operator_plus::overflow_free_p (const irange &lh, const irange &rh, >> + relation_trio) const >> +{ >> + if (lh.undefined_p () || rh.undefined_p ()) >> + return false; >> + >> + tree type = lh.type (); >> + if (TYPE_OVERFLOW_UNDEFINED (type)) >> + return true; >> + >> + wi::overflow_type ovf; >> + signop sgn = TYPE_SIGN (type); >> + wide_int wmax0 = lh.upper_bound (); >> + wide_int wmax1 = rh.upper_bound (); >> + wi::add (wmax0, wmax1, sgn, &ovf); >> + if (ovf != wi::OVF_NONE) >> + return false; >> + >> + if (TYPE_UNSIGNED (type)) >> + return true; >> + >> + wide_int wmin0 = lh.lower_bound (); >> + wide_int wmin1 = rh.lower_bound (); >> + wi::add (wmin0, wmin1, sgn, &ovf); >> + if (ovf != wi::OVF_NONE) >> + return false; >> + >> + return true; >> +} >> + >> +bool >> +operator_minus::overflow_free_p (const irange &lh, const irange &rh, >> + relation_trio) const >> +{ >> + if (lh.undefined_p () || rh.undefined_p ()) >> + return false; >> + >> + tree type = lh.type (); >> + if (TYPE_OVERFLOW_UNDEFINED (type)) >> + return true; >> + >> + wi::overflow_type ovf; >> + signop sgn = TYPE_SIGN (type); >> + wide_int wmin0 = lh.lower_bound (); >> + wide_int wmax1 = rh.upper_bound (); >> + wi::sub (wmin0, wmax1, sgn, &ovf); >> + if (ovf != wi::OVF_NONE) >> + return false; >> + >> + if (TYPE_UNSIGNED (type)) >> + return true; >> + >> + wide_int wmax0 = lh.upper_bound (); >> + wide_int wmin1 = rh.lower_bound (); >> + wi::sub (wmax0, wmin1, sgn, &ovf); >> + if (ovf != wi::OVF_NONE) >> + return false; >> + >> + return true; >> +} >> + >> +bool >> +operator_mult::overflow_free_p (const irange &lh, const irange &rh, >> + relation_trio) const >> +{ >> + if (lh.undefined_p () || rh.undefined_p ()) >> + return false; >> + >> + tree type = lh.type (); >> + if (TYPE_OVERFLOW_UNDEFINED (type)) >> + return true; >> + >> + wi::overflow_type ovf; >> + signop sgn = TYPE_SIGN (type); >> + wide_int wmax0 = lh.upper_bound (); >> + wide_int wmax1 = rh.upper_bound (); >> + wi::mul (wmax0, wmax1, sgn, &ovf); >> + if (ovf != wi::OVF_NONE) >> + return false; >> + >> + if (TYPE_UNSIGNED (type)) >> + return true; >> + >> + wide_int wmin0 = lh.lower_bound (); >> + wide_int wmin1 = rh.lower_bound (); >> + wi::mul (wmin0, wmin1, sgn, &ovf); >> + if (ovf != wi::OVF_NONE) >> + return false; >> + >> + wi::mul (wmin0, wmax1, sgn, &ovf); >> + if (ovf != wi::OVF_NONE) >> + return false; >> + >> + wi::mul (wmax0, wmin1, sgn, &ovf); >> + if (ovf != wi::OVF_NONE) >> + return false; >> + >> + return true; >> +} >> + >> #if CHECKING_P >> #include "selftest.h" >> >> diff --git a/gcc/range-op.h b/gcc/range-op.h >> index af94c2756a7..db3b03f28a5 100644 >> --- a/gcc/range-op.h >> +++ b/gcc/range-op.h >> @@ -147,6 +147,9 @@ public: >> >> virtual relation_kind op1_op2_relation (const irange &lhs) const; >> virtual relation_kind op1_op2_relation (const frange &lhs) const; >> + >> + virtual bool overflow_free_p (const irange &lh, const irange &rh, >> + relation_trio = TRIO_VARYING) const; >> protected: >> // Perform an integral operation between 2 sub-ranges and return it. >> virtual void wi_fold (irange &r, tree type, >> @@ -214,6 +217,8 @@ public: >> const vrange &op2, >> relation_kind = VREL_VARYING) const; >> relation_kind op1_op2_relation (const vrange &lhs) const; >> + bool overflow_free_p (const vrange &lh, const vrange &rh, >> + relation_trio = TRIO_VARYING) const; >> protected: >> unsigned dispatch_kind (const vrange &lhs, const vrange &op1, >> const vrange& op2) const; >> diff --git a/gcc/value-range.cc b/gcc/value-range.cc >> index 011bdbdeae6..5ae4e044194 100644 >> --- a/gcc/value-range.cc >> +++ b/gcc/value-range.cc >> @@ -313,6 +313,18 @@ add_vrange (const vrange &v, inchash::hash &hstate, >> >> } //namespace inchash >> >> +bool >> +irange::nonnegative_p () const >> +{ >> + return wi::ge_p (lower_bound (), 0, TYPE_SIGN (type ())); >> +} >> + >> +bool >> +irange::nonpositive_p () const >> +{ >> + return wi::le_p (upper_bound (), 0, TYPE_SIGN (type ())); >> +} >> + >> bool >> irange::supports_type_p (const_tree type) const >> { >> diff --git a/gcc/value-range.h b/gcc/value-range.h >> index 0170188201b..a12dea514e4 100644 >> --- a/gcc/value-range.h >> +++ b/gcc/value-range.h >> @@ -280,6 +280,8 @@ public: >> virtual bool singleton_p (tree *result = NULL) const override; >> bool singleton_p (wide_int &) const; >> bool contains_p (const wide_int &) const; >> + bool nonnegative_p () const; >> + bool nonpositive_p () const; >> >> // In-place operators. >> virtual bool union_ (const vrange &) override;