From: Jason Merrill <jason@redhat.com>
To: Lewis Hyatt <lhyatt@gmail.com>,
gcc-patches List <gcc-patches@gcc.gnu.org>
Subject: Re: Ping^2: [PATCH v2] diagnostics: Honor #pragma GCC diagnostic in the preprocessor [PR53431]
Date: Wed, 29 Jun 2022 12:59:11 -0400 [thread overview]
Message-ID: <e11517fd-3327-6ff7-b7ff-23d7ee688f05@redhat.com> (raw)
In-Reply-To: <CAA_5UQ7CEwy6KOW-Czr3V99se2+XniY-O0M1c7oAt3OrcFsr1g@mail.gmail.com>
On 6/23/22 13:03, Lewis Hyatt via Gcc-patches wrote:
> Hello-
>
> https://gcc.gnu.org/pipermail/gcc-patches/2022-May/595556.html
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=53431#c49
>
> Would a C++ maintainer have some time to take a look at this patch
> please? I feel like the PR is still worth resolving. If this doesn't
> seem like a good way, I am happy to try another -- would really
> appreciate any feedback. Thanks!
Thanks for your persistence, I'll take a look now.
Incidentally, when pinging it's often useful to ping someone from
MAINTAINERS directly, as well as the list. I think your last ping got
eaten by some trouble Red Hat email was having at the time.
The cp_token_is_module_directive cleanup is OK.
> + bool skip_this_pragma;
This member seems to be equivalent to
in_pragma && !should_output_pragmas ()
Maybe it could be a member function instead of a data member?
More soon.
Jason
next prev parent reply other threads:[~2022-06-29 16:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-23 17:03 Lewis Hyatt
2022-06-29 16:59 ` Jason Merrill [this message]
2022-07-01 19:59 ` Jason Merrill
2022-07-01 22:05 ` Lewis Hyatt
2022-07-02 0:23 ` Jason Merrill
2022-07-06 14:23 ` Lewis Hyatt
2022-07-06 18:17 ` Jason Merrill
2022-07-06 19:41 ` Lewis Hyatt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e11517fd-3327-6ff7-b7ff-23d7ee688f05@redhat.com \
--to=jason@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=lhyatt@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).