From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 126987 invoked by alias); 2 May 2016 15:10:33 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 126910 invoked by uid 89); 2 May 2016 15:10:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:841 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 02 May 2016 15:10:27 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 989A9C01AA44; Mon, 2 May 2016 15:10:26 +0000 (UTC) Received: from localhost.localdomain (ovpn-113-69.phx2.redhat.com [10.3.113.69]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u42FAQvG008470; Mon, 2 May 2016 11:10:26 -0400 Subject: Re: [PATCH] Drop excess size used for run time allocated stack variables. To: vogt@linux.vnet.ibm.com, gcc-patches@gcc.gnu.org, Andreas Krebbel References: <20160429221242.GA2205@linux.vnet.ibm.com> From: Jeff Law Message-ID: Date: Mon, 02 May 2016 15:10:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <20160429221242.GA2205@linux.vnet.ibm.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2016-05/txt/msg00102.txt.bz2 On 04/29/2016 04:12 PM, Dominik Vogt wrote: > The attached patch removes excess stack space allocation with > alloca in some situations. Plese check the commit message in the > patch for details. > > Ciao > > Dominik ^_^ ^_^ > > -- Dominik Vogt IBM Germany > > > 0001-ChangeLog > > > gcc/ChangeLog > > * explow.c (round_push): Use know adjustment. > (allocate_dynamic_stack_space): Pass known adjustment to round_push. If I understand the state of this patch correctly, you're working on another iteration, so I'm not going to dig into this version. However, I would strongly recommend some tests, even if they are target specific. You can always copy pr36728-1 into the s390x directory and look at size of the generated stack. Simliarly for pr50938 for x86. jeff