From: mliska <mliska@suse.cz>
To: gcc-patches@gcc.gnu.org
Subject: [PATCH 35/35] Remove old pool allocator.
Date: Wed, 27 May 2015 14:17:00 -0000 [thread overview]
Message-ID: <e13003538bef99b1665e144ad23e986a1bc1fcc7.1432735040.git.mliska@suse.cz> (raw)
In-Reply-To: <83d59ba92a3c4b3ba831ebc2fce325f0416848d0.1432735040.git.mliska@suse.cz>
gcc/ChangeLog:
2015-04-30 Martin Liska <mliska@suse.cz>
* alloc-pool.c (create_alloc_pool): Remove.
(empty_alloc_pool): Likewise.
(free_alloc_pool): Likewise.
(free_alloc_pool_if_empty): Likewise.
(pool_alloc): Likewise.
(pool_free): Likewise.
* alloc-pool.h: Remove old declarations.
---
gcc/alloc-pool.c | 274 -------------------------------------------------------
gcc/alloc-pool.h | 56 ------------
2 files changed, 330 deletions(-)
diff --git a/gcc/alloc-pool.c b/gcc/alloc-pool.c
index 0bea7a6..78bc305 100644
--- a/gcc/alloc-pool.c
+++ b/gcc/alloc-pool.c
@@ -27,39 +27,6 @@ along with GCC; see the file COPYING3. If not see
ALLOC_POOL_ID_TYPE last_id;
-#define align_eight(x) (((x+7) >> 3) << 3)
-
-/* The internal allocation object. */
-typedef struct allocation_object_def
-{
-#ifdef ENABLE_CHECKING
- /* The ID of alloc pool which the object was allocated from. */
- ALLOC_POOL_ID_TYPE id;
-#endif
-
- union
- {
- /* The data of the object. */
- char data[1];
-
- /* Because we want any type of data to be well aligned after the ID,
- the following elements are here. They are never accessed so
- the allocated object may be even smaller than this structure.
- We do not care about alignment for floating-point types. */
- char *align_p;
- int64_t align_i;
- } u;
-} allocation_object;
-
-/* Convert a pointer to allocation_object from a pointer to user data. */
-#define ALLOCATION_OBJECT_PTR_FROM_USER_PTR(X) \
- ((allocation_object *) (((char *) (X)) \
- - offsetof (allocation_object, u.data)))
-
-/* Convert a pointer to user data from a pointer to allocation_object. */
-#define USER_PTR_FROM_ALLOCATION_OBJECT_PTR(X) \
- ((void *) (((allocation_object *) (X))->u.data))
-
/* Hashtable mapping alloc_pool names to descriptors. */
hash_map<const char *, alloc_pool_descriptor> *alloc_pool_hash;
@@ -72,247 +39,6 @@ allocate_pool_descriptor (const char *name)
return &alloc_pool_hash->get_or_insert (name);
}
-
-/* Create a pool of things of size SIZE, with NUM in each block we
- allocate. */
-
-alloc_pool
-create_alloc_pool (const char *name, size_t size, size_t num)
-{
- alloc_pool pool;
- size_t header_size;
-
- gcc_checking_assert (name);
-
- /* Make size large enough to store the list header. */
- if (size < sizeof (alloc_pool_list))
- size = sizeof (alloc_pool_list);
-
- /* Now align the size to a multiple of 4. */
- size = align_eight (size);
-
-#ifdef ENABLE_CHECKING
- /* Add the aligned size of ID. */
- size += offsetof (allocation_object, u.data);
-#endif
-
- /* Um, we can't really allocate 0 elements per block. */
- gcc_checking_assert (num);
-
- /* Allocate memory for the pool structure. */
- pool = XNEW (struct alloc_pool_def);
-
- /* Now init the various pieces of our pool structure. */
- pool->name = /*xstrdup (name)*/name;
- pool->elt_size = size;
- pool->elts_per_block = num;
-
- if (GATHER_STATISTICS)
- {
- struct alloc_pool_descriptor *desc = allocate_pool_descriptor (name);
- desc->elt_size = size;
- desc->created++;
- }
-
- /* List header size should be a multiple of 8. */
- header_size = align_eight (sizeof (struct alloc_pool_list_def));
-
- pool->block_size = (size * num) + header_size;
- pool->returned_free_list = NULL;
- pool->virgin_free_list = NULL;
- pool->virgin_elts_remaining = 0;
- pool->elts_allocated = 0;
- pool->elts_free = 0;
- pool->blocks_allocated = 0;
- pool->block_list = NULL;
-
-#ifdef ENABLE_CHECKING
- /* Increase the last used ID and use it for this pool.
- ID == 0 is used for free elements of pool so skip it. */
- last_id++;
- if (last_id == 0)
- last_id++;
-
- pool->id = last_id;
-#endif
-
- return (pool);
-}
-
-/* Free all memory allocated for the given memory pool. */
-void
-empty_alloc_pool (alloc_pool pool)
-{
- alloc_pool_list block, next_block;
-
- gcc_checking_assert (pool);
-
- /* Free each block allocated to the pool. */
- for (block = pool->block_list; block != NULL; block = next_block)
- {
- next_block = block->next;
- free (block);
- }
-
- if (GATHER_STATISTICS)
- {
- struct alloc_pool_descriptor *desc = allocate_pool_descriptor (pool->name);
- desc->current -= (pool->elts_allocated - pool->elts_free) * pool->elt_size;
- }
-
- pool->returned_free_list = NULL;
- pool->virgin_free_list = NULL;
- pool->virgin_elts_remaining = 0;
- pool->elts_allocated = 0;
- pool->elts_free = 0;
- pool->blocks_allocated = 0;
- pool->block_list = NULL;
-}
-
-/* Free all memory allocated for the given memory pool and the pool itself. */
-void
-free_alloc_pool (alloc_pool pool)
-{
- /* First empty the pool. */
- empty_alloc_pool (pool);
-#ifdef ENABLE_CHECKING
- memset (pool, 0xaf, sizeof (*pool));
-#endif
- /* Lastly, free the pool. */
- free (pool);
-}
-
-/* Frees the alloc_pool, if it is empty and zero *POOL in this case. */
-void
-free_alloc_pool_if_empty (alloc_pool *pool)
-{
- if ((*pool)->elts_free == (*pool)->elts_allocated)
- {
- free_alloc_pool (*pool);
- *pool = NULL;
- }
-}
-
-/* Allocates one element from the pool specified. */
-void *
-pool_alloc (alloc_pool pool)
-{
- alloc_pool_list header;
-#ifdef ENABLE_VALGRIND_ANNOTATIONS
- int size;
-#endif
-
- if (GATHER_STATISTICS)
- {
- struct alloc_pool_descriptor *desc = allocate_pool_descriptor (pool->name);
-
- desc->allocated += pool->elt_size;
- desc->current += pool->elt_size;
- if (desc->peak < desc->current)
- desc->peak = desc->current;
- }
-
- gcc_checking_assert (pool);
-#ifdef ENABLE_VALGRIND_ANNOTATIONS
- size = pool->elt_size - offsetof (allocation_object, u.data);
-#endif
-
- /* If there are no more free elements, make some more!. */
- if (!pool->returned_free_list)
- {
- char *block;
- if (!pool->virgin_elts_remaining)
- {
- alloc_pool_list block_header;
-
- /* Make the block. */
- block = XNEWVEC (char, pool->block_size);
- block_header = (alloc_pool_list) block;
- block += align_eight (sizeof (struct alloc_pool_list_def));
-
- /* Throw it on the block list. */
- block_header->next = pool->block_list;
- pool->block_list = block_header;
-
- /* Make the block available for allocation. */
- pool->virgin_free_list = block;
- pool->virgin_elts_remaining = pool->elts_per_block;
-
- /* Also update the number of elements we have free/allocated, and
- increment the allocated block count. */
- pool->elts_allocated += pool->elts_per_block;
- pool->elts_free += pool->elts_per_block;
- pool->blocks_allocated += 1;
- }
-
-
- /* We now know that we can take the first elt off the virgin list and
- put it on the returned list. */
- block = pool->virgin_free_list;
- header = (alloc_pool_list) USER_PTR_FROM_ALLOCATION_OBJECT_PTR (block);
- header->next = NULL;
-#ifdef ENABLE_CHECKING
- /* Mark the element to be free. */
- ((allocation_object *) block)->id = 0;
-#endif
- VALGRIND_DISCARD (VALGRIND_MAKE_MEM_NOACCESS (header,size));
- pool->returned_free_list = header;
- pool->virgin_free_list += pool->elt_size;
- pool->virgin_elts_remaining--;
-
- }
-
- /* Pull the first free element from the free list, and return it. */
- header = pool->returned_free_list;
- VALGRIND_DISCARD (VALGRIND_MAKE_MEM_DEFINED (header, sizeof (*header)));
- pool->returned_free_list = header->next;
- pool->elts_free--;
-
-#ifdef ENABLE_CHECKING
- /* Set the ID for element. */
- ALLOCATION_OBJECT_PTR_FROM_USER_PTR (header)->id = pool->id;
-#endif
- VALGRIND_DISCARD (VALGRIND_MAKE_MEM_UNDEFINED (header, size));
-
- return ((void *) header);
-}
-
-/* Puts PTR back on POOL's free list. */
-void
-pool_free (alloc_pool pool, void *ptr)
-{
- alloc_pool_list header;
-#if defined(ENABLE_VALGRIND_ANNOTATIONS) || defined(ENABLE_CHECKING)
- int size;
- size = pool->elt_size - offsetof (allocation_object, u.data);
-#endif
-
-#ifdef ENABLE_CHECKING
- gcc_assert (ptr
- /* Check if we free more than we allocated, which is Bad (TM). */
- && pool->elts_free < pool->elts_allocated
- /* Check whether the PTR was allocated from POOL. */
- && pool->id == ALLOCATION_OBJECT_PTR_FROM_USER_PTR (ptr)->id);
-
- memset (ptr, 0xaf, size);
-
- /* Mark the element to be free. */
- ALLOCATION_OBJECT_PTR_FROM_USER_PTR (ptr)->id = 0;
-#endif
-
- header = (alloc_pool_list) ptr;
- header->next = pool->returned_free_list;
- pool->returned_free_list = header;
- VALGRIND_DISCARD (VALGRIND_MAKE_MEM_NOACCESS (ptr, size));
- pool->elts_free++;
-
- if (GATHER_STATISTICS)
- {
- struct alloc_pool_descriptor *desc = allocate_pool_descriptor (pool->name);
- desc->current -= pool->elt_size;
- }
-}
-
/* Output per-alloc_pool statistics. */
/* Used to accumulate statistics about alloc_pool sizes. */
diff --git a/gcc/alloc-pool.h b/gcc/alloc-pool.h
index 8fd664f..a934303 100644
--- a/gcc/alloc-pool.h
+++ b/gcc/alloc-pool.h
@@ -22,48 +22,6 @@ along with GCC; see the file COPYING3. If not see
#include "hash-map.h"
-typedef unsigned long ALLOC_POOL_ID_TYPE;
-
-typedef struct alloc_pool_list_def
-{
- struct alloc_pool_list_def *next;
-}
- *alloc_pool_list;
-
-typedef struct alloc_pool_def
-{
- const char *name;
-#ifdef ENABLE_CHECKING
- ALLOC_POOL_ID_TYPE id;
-#endif
- size_t elts_per_block;
-
- /* These are the elements that have been allocated at least once and freed. */
- alloc_pool_list returned_free_list;
-
- /* These are the elements that have not yet been allocated out of
- the last block obtained from XNEWVEC. */
- char* virgin_free_list;
-
- /* The number of elements in the virgin_free_list that can be
- allocated before needing another block. */
- size_t virgin_elts_remaining;
-
- size_t elts_allocated;
- size_t elts_free;
- size_t blocks_allocated;
- alloc_pool_list block_list;
- size_t block_size;
- size_t elt_size;
-}
- *alloc_pool;
-
-extern alloc_pool create_alloc_pool (const char *, size_t, size_t);
-extern void free_alloc_pool (alloc_pool);
-extern void empty_alloc_pool (alloc_pool);
-extern void free_alloc_pool_if_empty (alloc_pool *);
-extern void *pool_alloc (alloc_pool) ATTRIBUTE_MALLOC;
-extern void pool_free (alloc_pool, void *);
extern void dump_alloc_pool_statistics (void);
typedef unsigned long ALLOC_POOL_ID_TYPE;
@@ -73,26 +31,12 @@ template <typename T>
class pool_allocator
{
public:
- /* Default constructor for pool allocator called NAME. Each block
- has NUM elements. The allocator support EXTRA_SIZE and can
- potentially IGNORE_TYPE_SIZE. */
pool_allocator (const char *name, size_t num, size_t extra_size = 0,
bool ignore_type_size = false);
-
- /* Default destuctor. */
~pool_allocator ();
-
- /* Release internal data structures. */
void release ();
-
- /* Release internal data structures if the pool has not allocated
- an object. */
void release_if_empty ();
-
- /* Allocate a new object. */
T *allocate () ATTRIBUTE_MALLOC;
-
- /* Release OBJECT that must come from the pool. */
void remove (T *object);
private:
--
2.1.4
next prev parent reply other threads:[~2015-05-27 14:17 UTC|newest]
Thread overview: 108+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-27 14:09 [PATCH 01/35] Introduce new type-based " mliska
2015-05-27 14:00 ` [PATCH 09/35] Change use to type-based pool allocator in c-format.c mliska
2015-05-27 14:16 ` Jakub Jelinek
2015-05-27 18:01 ` Jeff Law
2015-05-29 13:35 ` Martin Liška
2015-05-27 14:00 ` [PATCH 06/35] Change use to type-based pool allocator in ira-color.c mliska
2015-05-27 14:00 ` [PATCH 12/35] Change use to type-based pool allocator in cselib.c mliska
2015-05-29 13:38 ` Martin Liška
2015-05-27 14:00 ` [PATCH 10/35] Change use to type-based pool allocator in cfg.c mliska
2015-05-27 18:01 ` Jeff Law
2015-05-29 13:34 ` Martin Liška
2015-05-27 14:00 ` [PATCH 04/35] Change use to type-based pool allocator in lra.c mliska
2015-05-27 17:55 ` Jeff Law
2015-05-29 13:34 ` Martin Liška
2015-05-27 14:00 ` [PATCH 03/35] Change use to type-based pool allocator in lra-lives.c mliska
2015-05-27 17:53 ` Jeff Law
2015-05-29 13:34 ` Martin Liška
2015-05-28 0:48 ` Trevor Saunders
2015-05-27 14:07 ` [PATCH 19/35] Change use to type-based pool allocator in sel-sched-ir.c mliska
2015-05-27 18:12 ` Jeff Law
2015-05-29 13:40 ` Martin Liška
2015-05-27 14:09 ` [PATCH 02/35] Change use to type-based pool allocator in et-forest.c mliska
2015-05-27 17:50 ` Jeff Law
2015-05-29 13:33 ` Martin Liška
2015-05-27 14:15 ` [PATCH 05/35] Change use to type-based pool allocator in ira-color.c mliska
2015-05-27 17:59 ` Jeff Law
2015-05-29 13:34 ` Martin Liška
2015-05-27 14:17 ` [PATCH 34/35] Change use to type-based pool allocator in ira-build.c mliska
2015-05-27 14:17 ` [PATCH 32/35] " mliska
2015-05-27 19:34 ` Jeff Law
2015-05-29 13:44 ` Martin Liška
2015-05-27 14:17 ` mliska [this message]
2015-05-27 19:40 ` [PATCH 35/35] Remove old pool allocator Jeff Law
2015-05-29 14:11 ` Martin Liška
2015-05-27 14:17 ` [PATCH 28/35] Change use to type-based pool allocator in ipa-profile.c mliska
2015-05-27 18:18 ` Jeff Law
2015-05-29 13:42 ` Martin Liška
2015-05-27 14:17 ` [PATCH 21/35] Change use to type-based pool allocator in regcprop.c mliska
2015-05-27 18:14 ` Jeff Law
2015-05-29 13:40 ` Martin Liška
2015-05-27 14:17 ` [PATCH 23/35] Change use to type-based pool allocator in tree-ssa-pre.c mliska
2015-05-27 18:59 ` Jeff Law
2015-05-29 13:41 ` Martin Liška
2015-05-27 14:18 ` [PATCH 27/35] Change use to type-based pool allocator in tree-ssa-structalias.c mliska
2015-05-27 18:20 ` Jeff Law
2015-05-29 13:42 ` Martin Liška
2015-05-27 14:19 ` [PATCH 11/35] Change use to type-based pool allocator in sh.c mliska
2015-05-27 18:03 ` Jeff Law
2015-05-29 13:37 ` Martin Liška
2015-05-27 14:19 ` [PATCH 25/35] Change use to type-based pool allocator in tree-ssa-sccvn.c mliska
2015-05-27 18:16 ` Jeff Law
2015-05-29 13:41 ` Martin Liška
2015-05-27 14:19 ` [PATCH 08/35] Change use to type-based pool allocator in asan.c mliska
2015-05-27 18:01 ` Jeff Law
2015-05-27 14:19 ` [PATCH 14/35] Change use to type-based pool allocator in df-scan.c mliska
2015-05-29 13:38 ` Martin Liška
2015-05-27 14:20 ` [PATCH 07/35] Change use to type-based pool allocator in var-tracking.c mliska
2015-05-29 13:34 ` Martin Liška
2015-05-27 14:20 ` [PATCH 29/35] Change use to type-based pool allocator in ipa-prop.c mliska
2015-05-27 18:22 ` Jeff Law
2015-05-29 13:42 ` Martin Liška
2015-05-27 14:20 ` [PATCH 31/35] Change use to type-based pool allocator in ipa-prop.c and ipa-cp.c mliska
2015-05-29 14:09 ` Martin Liška
2015-05-27 14:21 ` [PATCH 26/35] Change use to type-based pool allocator in tree-ssa-strlen.c mliska
2015-05-27 18:17 ` Jeff Law
2015-05-29 13:42 ` Martin Liška
2015-05-27 14:21 ` [PATCH 18/35] Change use to type-based pool allocator in stmt.c mliska
2015-05-27 18:13 ` Jeff Law
2015-05-29 13:39 ` Martin Liška
2015-05-27 14:21 ` [PATCH 15/35] Change use to type-based pool allocator in dse.c mliska
2015-05-29 13:38 ` Martin Liška
2015-05-27 14:21 ` [PATCH 16/35] Change use to type-based pool allocator in tree-sra.c mliska
2015-05-27 18:11 ` Jeff Law
2015-05-29 13:39 ` Martin Liška
2015-05-27 14:21 ` [PATCH 20/35] Change use to type-based pool allocator in ira-build.c mliska
2015-05-27 18:15 ` Jeff Law
2015-05-29 13:39 ` Martin Liška
2015-05-27 14:21 ` [PATCH 30/35] Change use to type-based pool allocator in ipa-inline-analysis.c mliska
2015-05-29 14:06 ` Martin Liška
2015-05-27 14:21 ` [PATCH 24/35] Change use to type-based pool allocator in tree-ssa-reassoc.c mliska
2015-05-27 18:15 ` Jeff Law
2015-05-29 13:41 ` Martin Liška
2015-05-27 14:42 ` [PATCH 22/35] Change use to type-based pool allocator in sched-deps.c mliska
2015-05-27 18:16 ` Jeff Law
2015-05-29 13:40 ` Martin Liška
2015-05-27 14:55 ` [PATCH 17/35] Change use to type-based pool allocator in tree-ssa-math-opts.c mliska
2015-05-27 18:12 ` Jeff Law
2015-05-29 13:39 ` Martin Liška
2015-05-27 14:58 ` [PATCH 33/35] Change use to type-based pool allocator in ira-color.c mliska
2015-05-27 18:24 ` Jeff Law
2015-05-28 11:23 ` Statically-allocated objects with non-trivial ctors (was Re: [PATCH 33/35] Change use to type-based pool allocator in ira-color.c.) David Malcolm
2015-05-28 17:38 ` Jeff Law
2015-05-28 18:30 ` Richard Biener
2015-05-28 18:34 ` Jakub Jelinek
2015-05-28 19:25 ` Martin Liška
2015-05-28 20:42 ` Trevor Saunders
2015-05-29 5:16 ` Trevor Saunders
2015-05-27 15:04 ` [PATCH 13/35] Change use to type-based pool allocator in df-problems.c mliska
2015-05-27 18:05 ` Jeff Law
2015-05-29 13:37 ` Martin Liška
2015-05-27 17:50 ` [PATCH 01/35] Introduce new type-based pool allocator Jeff Law
2015-05-28 13:27 ` Martin Liška
2015-05-28 18:04 ` Jeff Law
2015-05-29 13:33 ` Martin Liška
2015-05-30 5:14 ` Jeff Law
2015-06-02 10:10 ` Andreas Schwab
2015-06-02 13:57 ` Martin Liška
2015-06-02 14:00 ` Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e13003538bef99b1665e144ad23e986a1bc1fcc7.1432735040.git.mliska@suse.cz \
--to=mliska@suse.cz \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).