From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com [IPv6:2607:f8b0:4864:20::62e]) by sourceware.org (Postfix) with ESMTPS id B8FFE3AA9400 for ; Wed, 28 Apr 2021 15:55:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org B8FFE3AA9400 Received: by mail-pl1-x62e.google.com with SMTP id b21so4580427plz.0 for ; Wed, 28 Apr 2021 08:55:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=UMzv4tXgNx0hyfJS2RWzAmSZQCWHkeL62rH54tWWGW8=; b=XW8qo5hW4Vs88aHjgtrrAUA3Shh9Yupcau9JuTOQbNiuHcaGwDy7rvasFAR0w+EQCN LxyyCdt2UOUI5eW6AFnCKg1xtovVaHM/CYL0Llx22u7cWhLLlAMvoT7in08fAI+hTePi 3ygL3l5S7aaOMkSGOKeD3tHVoQRqVsLNueBzGewN73Bw6rv9kuRqv0JEtl9I2rsk6G4N YXG0ROa7/04MqdRYq+5Kg+6TqZVfQGCW4GhILWbwgrQWvyZKGbAt55jmU3lBGSOt+xkF TXoudRgY03SH5aH5Bcb4IzIIHNInRFecGBmgoUsfgcfEUkDtN4AlGPcptio4++SDHDQV DaYA== X-Gm-Message-State: AOAM5333sVkZmWVlKbQN3dud9GBK+j2FF1ImdnjFBQ+dnRLAPWtug3OH fuhLZvGQy1bbQZSEqne7X01M/SCEzI90yA== X-Google-Smtp-Source: ABdhPJztQKesmda73EurRXr1FqUDlhwUfNQkUVjaKCf4+qFvw2CeENsKZg9xGnDJtDRZ91JjSBtEKA== X-Received: by 2002:a17:902:bd0c:b029:ed:7018:4daf with SMTP id p12-20020a170902bd0cb02900ed70184dafmr4259159pls.67.1619625301704; Wed, 28 Apr 2021 08:55:01 -0700 (PDT) Received: from [192.168.1.29] (65-130-82-141.slkc.qwest.net. [65.130.82.141]) by smtp.gmail.com with ESMTPSA id j29sm139840pgl.30.2021.04.28.08.55.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Apr 2021 08:55:01 -0700 (PDT) Subject: Re: [PATCH v2 04/21] libcc1: delete copy constructor and assignment operators To: Tom Tromey , gcc-patches@gcc.gnu.org References: <20210428010119.806184-1-tom@tromey.com> <20210428010119.806184-5-tom@tromey.com> From: Jeff Law Message-ID: Date: Wed, 28 Apr 2021 09:55:00 -0600 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.1 MIME-Version: 1.0 In-Reply-To: <20210428010119.806184-5-tom@tromey.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, URIBL_CSS, URIBL_CSS_A autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Apr 2021 15:55:04 -0000 On 4/27/2021 7:01 PM, Tom Tromey wrote: > Change libcc1 to use "= delete" for the copy constructor and > assignment operator, rather than the old approach of private methods > that are nowhere defined. > > libcc1/ChangeLog > 2021-04-27 Tom Tromey > > * rpc.hh (argument_wrapper): Use delete for copy constructor. > * connection.hh (class connection): Use delete for copy > constructor. > * callbacks.hh (class callbacks): Use delete for copy constructor. OK jeff