From: Jeff Law <law@redhat.com>
To: John David Anglin <dave.anglin@bell.net>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Fix PR libgcc/92988
Date: Wed, 15 Jan 2020 23:51:00 -0000 [thread overview]
Message-ID: <e15b7f8607cc6f124b4f7790815a70a1aa489935.camel@redhat.com> (raw)
In-Reply-To: <614b0f9f-e7de-c75a-bd8b-60c4d62aa006@bell.net>
On Wed, 2020-01-15 at 17:27 -0500, John David Anglin wrote:
> On 2020-01-15 3:45 p.m., Jeff Law wrote:
> > On Mon, 2019-12-30 at 14:23 -0500, John David Anglin wrote:
> > > Tested on hppa64-hp-hpux11.11.
> > >
> > > Okay?
> > >
> > > Dave
> > >
> > > 2019-12-30 John David Anglin <danglin@gcc.gnu.org>
> > >
> > > PR libgcc/92988
> > > * crtstuff.c (__do_global_dtors_aux): Only call __cxa_finalize if
> > > DEFAULT_USE_CXA_ATEXIT is true.
> > Who is supposed to define DEFAULT_USE_CXA_ATEXIT? I can't seem to find
> > any references to it within GCC itself.
> >
> > I don't doubt there's a problem, I'm just not sure we've got the right
> > #ifdef around the code in question.
> It is defined by configure. In gcc/defaults.h:
>
> /* Determine whether __cxa_atexit, rather than atexit, is used to
> register C++ destructors for local statics and global objects. */
> #ifndef DEFAULT_USE_CXA_ATEXIT
> #define DEFAULT_USE_CXA_ATEXIT 0
> #endif
Uber-weird. I grepped for it more than once and didn't see anything.
Thanks. OK for the trunk.
jeff
prev parent reply other threads:[~2020-01-15 22:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-30 20:26 John David Anglin
2020-01-01 17:23 ` John David Anglin
2020-01-15 21:40 ` Jeff Law
2020-01-15 23:17 ` John David Anglin
2020-01-15 23:51 ` Jeff Law [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e15b7f8607cc6f124b4f7790815a70a1aa489935.camel@redhat.com \
--to=law@redhat.com \
--cc=dave.anglin@bell.net \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).