From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 118108 invoked by alias); 19 Dec 2017 20:41:55 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 118088 invoked by uid 89); 19 Dec 2017 20:41:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.5 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_1,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 spammy=mature, HContent-Transfer-Encoding:8bit X-HELO: mail-qt0-f195.google.com Received: from mail-qt0-f195.google.com (HELO mail-qt0-f195.google.com) (209.85.216.195) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 19 Dec 2017 20:41:53 +0000 Received: by mail-qt0-f195.google.com with SMTP id u10so25841755qtg.2 for ; Tue, 19 Dec 2017 12:41:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=5Pv63KRIovAc9mWpVNYS2yWgAEY8lfOjPcBo+o/ucrQ=; b=pcDHg+meLLaWPnyF/et8Fc3pM5lM6L5dTmTQ57VYP4cxpSTnvAfdLR9pPg1bRrfXPd AJQuHSvKPpKvcOIDM/gEeJI5n0VNKOOXZ9NIIeYgLnvhA+HHIAba7yhofU4CRISth3YZ cTBJ0aMIX+y0s4wjfTN3pHLHc3gk5T1PSbfmW5IkM9kh4TQRxYPLC7kviIiUmm9tFr9W iufxsFsj1okBo59FGwX/dCNRfhQStLnwMJ+SOQp1yygYtm3o9XPu1XEfDWcJwBlR3GBW YjJWKegr+hfBTWEHjwi5BNuo5pshbBdThyTwqYkEWNh6kj1FIhOUpx9puBpGZtPlINVo oynw== X-Gm-Message-State: AKGB3mKyr3KUFgPgPfHByLdjkAqiXpDFBTl1EqbfSXWf2Di4ch+nmr6g CzOdQBxhoK3M97r8FVG6xA8eGA== X-Google-Smtp-Source: ACJfBouFnRlAAOPild1V+prX4UGS1zlPjYVOZ4Cu22DMsiyVFJregk50sUAKs5A3cB6TxrBWu2mq4Q== X-Received: by 10.200.36.9 with SMTP id c9mr7465501qtc.182.1513716111544; Tue, 19 Dec 2017 12:41:51 -0800 (PST) Received: from [192.168.1.132] (209-6-90-240.s1774.c3-0.smr-ubr1.sbo-smr.ma.cable.rcncustomer.com. [209.6.90.240]) by smtp.gmail.com with ESMTPSA id z40sm10222401qtj.30.2017.12.19.12.41.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 19 Dec 2017 12:41:50 -0800 (PST) Subject: Re: [C++ PING] Re: [C++ Patch, V2] PR 82593 ("Internal compiler error: in process_init_constructor_array, at cp/typeck2.c:1294") To: Paolo Carlini , "gcc-patches@gcc.gnu.org" Cc: Nathan Sidwell References: <44bdbaa0-35f1-7f0c-85aa-b603939d016e@oracle.com> <44c93777-3841-e600-441d-0d616c357e0b@oracle.com> From: Jason Merrill Message-ID: Date: Tue, 19 Dec 2017 20:41:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <44c93777-3841-e600-441d-0d616c357e0b@oracle.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2017-12/txt/msg01309.txt.bz2 On 11/30/2017 01:19 PM, Paolo Carlini wrote: > On 17/11/2017 15:09, Paolo Carlini wrote: >> Hi again, >> >> I managed to spend much more time on the issue and I'm starting a new >> thread with a mature - IMHO - proposal: the big thing is the use of >> the existing check_array_designated_initializer in >> process_init_constructor_array,  which calls maybe_constant_value, as >> we want, and covers all the ill-formed cases which I can imagine. I'm >> also tweaking a bit the parser to check the return value of >> require_potential_rvalue_constant_expression in order to avoid >> redundant diagnostic in some cases. Also, a couple more testcases >> beyond the bug report. > I'm gently pinging this. I rebased it vs a very minor conflict due to > Jakub's implementation of P0329R4. While I was at it, I'm also proposing > a small tweak vs the previous version in the way > check_array_designated_initializer is used: only if ce->index is > non-null, more consistently with the current code. OK. Jason