From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [IPv6:2607:f8b0:4864:20::102b]) by sourceware.org (Postfix) with ESMTPS id C77243858D1E for ; Sun, 12 Mar 2023 01:54:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C77243858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pj1-x102b.google.com with SMTP id o4so1733500pjq.4 for ; Sat, 11 Mar 2023 17:54:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678586069; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=UPLU5FfklUFhYYsVMulpqeyVZ6y9BUR5npIaovj2OG0=; b=hcWU+Orgg3A+5HmwYRwWCPIitqaJdby+p1RFuUF/MHnjfxOJX9gdw0v5cnNxzwMPIG Uzv4UCD9hJnDCXqKF/pSXM23GMHxt8PtLRjuJw+VipSxwSax8GzfZgXmAnQ3VD2k0Gk5 PZCIl0lAR3z3PTdTpv/QZwOj7IocpACFk8lYXJ3fWCziRgG/X5rOId5TM0ERtmFrb+/0 wjb9duhmSa0oXaRPNi5zFaAbbJxGuM+7rTvPG0+mYyyzi/sxPCX/PEENopU5I7Qo2GxN lCXthW/CAvmdJvjzop8yIs/lGeTwTAkysQYGiPlwSDvOrmgkZ0MULGLuws9s0W4XoSVy Z46A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678586069; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UPLU5FfklUFhYYsVMulpqeyVZ6y9BUR5npIaovj2OG0=; b=PkZsGmcek3Q1TbTOd6E7NXH7D0XYXxaa7Ux6N9LkQ11EbCx8T8QWN6gVgKzwkQFydS A3QzBw6jcliCbr7J8aaYPMnbN12normZ1FIdH1eFBc1x44O7vPuQyu85c010STNbQCa2 81UJfdcDIUz4Qq5uPRsYHuP4KQs+oRd2OzRN3qKoX/p7sBmSKln+Oe5Z7zdgqT0vAZiP BHeLLmj7NeDbeYz5gvIaw8rv79LA4/OWfZSZ6WLrR7dgK1GbSHvL8Ptv3wvi0wTVq1mQ qA3hvuOUn/Spseope6QCrJlBViwQpfxFv7G2nGCK8ZmJTZy5nR+YqfH5L42Dss4F9hmC AN0A== X-Gm-Message-State: AO0yUKWZ06flzxVCStRJDoGMYuQnO5qkg5Wq9FMHLLJVxMtORBSgZFlp xEDWZyoXpTnsSgnJJRTYlWY= X-Google-Smtp-Source: AK7set/W1aYrafxTGg1Ys4XzsXPkl6JUM6gdqgIF4juWc68tHprbCaSN12YeC9ArGnlDiacZOKuxjw== X-Received: by 2002:a17:90b:1c87:b0:234:d78:9b4c with SMTP id oo7-20020a17090b1c8700b002340d789b4cmr30642616pjb.18.1678586068694; Sat, 11 Mar 2023 17:54:28 -0800 (PST) Received: from [202.190.72.126] ([202.190.72.126]) by smtp.gmail.com with ESMTPSA id l10-20020a635b4a000000b004dff15fc121sm2045356pgm.36.2023.03.11.17.54.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 11 Mar 2023 17:54:28 -0800 (PST) Message-ID: Date: Sun, 12 Mar 2023 01:54:25 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [Patch] More LLP64 fixes and __PIC__ values fixes for PE targets Content-Language: en-US To: Jeff Law , Gcc Patch List , NightStrike References: <8edbefac-5151-9ee8-4f86-439503c3d962@gmail.com> From: Jonathan Yong <10walls@gmail.com> In-Reply-To: <8edbefac-5151-9ee8-4f86-439503c3d962@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3031.1 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 3/11/23 17:29, Jeff Law wrote: > > > On 2/14/23 03:42, Jonathan Yong via Gcc-patches wrote: >> Attached patches OK? >> >> 0002-gcc-testsuite-gcc.dg-fix-pic-test-case-for-PE-target.patch >> >>  From 616e43ac41879040e73a266065874148553cddcc Mon Sep 17 00:00:00 2001 >> From: Jonathan Yong<10walls@gmail.com> >> Date: Tue, 14 Feb 2023 10:37:03 +0000 >> Subject: [PATCH 2/2] gcc/testsuite/gcc.dg: fix pic test case for PE >> targets >> >> gcc/testsuite/ChangeLog: >> >>     * pic-2.c: fix expected __PIC__ value. >>     * pic-3.c: ditto. >>     * pic-4.c: ditto. > Please adjust your ChangeLog entries slightly, in particular, please > capitalize the first letter in each ChangeLog entry.  ie, fix->Fix, > ditto->Ditto. > > Presumably the windows platforms are not always PIC and thus should not > be handled in a manner similar to MIPS? > > Assuming that's the case, then this patch is OK with the trivial > ChangeLog fixes. > > Windows code is effectively always PIC, since the PE loader can relocate it anywhere if the preferred address is already occupied. Patch still OK? >> >> >> 0001-gcc-testsuite-gcc.dg-fix-LLP64-targets.patch >> >>  From a1fafc5a3c70684e843f5f0b6cf392ce349cb6b0 Mon Sep 17 00:00:00 2001 >> From: Jonathan Yong<10walls@gmail.com> >> Date: Tue, 14 Feb 2023 10:29:05 +0000 >> Subject: [PATCH 1/2] gcc/testsuite/gcc.dg: fix LLP64 targets >> >> gcc/testsuite/ChangeLog: >> >>     * gcc.dg/builtins-69.c: Use (long )*regex pattern to >>     allow long long instead of just long. >>     * gcc.dg/pr80163.c: use __INTPTR_TYPE__ for LLP64 tagets. > OK with the trivial ChangeLog fix use->Use for the change to pr80163.c. > > jeff OK.