From: Gerald Pfeifer <gerald@pfeifer.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH 0/2] libsanitizer: Merge with upstream commit fdf4c035225d
Date: Thu, 7 Oct 2021 23:40:55 +0200 (CEST) [thread overview]
Message-ID: <e1ca1a49-4711-a3bb-bf88-2118efecf45@pfeifer.com> (raw)
In-Reply-To: <20211006200732.1857173-1-hjl.tools@gmail.com>
On Wed, 6 Oct 2021, H.J. Lu via Gcc-patches wrote:
> I am checking in these patches to merge with upstream commit:
Thus breaking bootstrap on FreeBSD:
GCC-HEAD/libsanitizer/sanitizer_common/sanitizer_platform_limits_freebsd.cpp:370:36: error: 'MD5_CTX' was not declared in this scope
370 | const unsigned MD5_CTX_sz = sizeof(MD5_CTX);
| ^~~~~~~
GCC-HEAD/libsanitizer/sanitizer_common/sanitizer_platform_limits_freebsd.cpp:371:36: error:
'MD5_DIGEST_STRING_LENGTH' was not declared in this scope; did you mean
'SHA256_DIGEST_STRING_LENGTH'?
371 | const unsigned MD5_return_length = MD5_DIGEST_STRING_LENGTH;
| ^~~~~~~~~~~~~~~~~~~~~~~~
| SHA256_DIGEST_STRING_LENGTH
I stared the the sources for minutes and FreeBSD include files and could
not find what was wrong.
Then I realized: GCC has its own include/md5 which misses some of these!
Looking how old md5 is (and deprecated) I cannot help wonder whether you
merged something that wasn't new, but intentionally left out originally?
Or include paths are broken.
Gerald
PS: At this point I am counting about *seven* distinct bootstrap
breakages on my nightly testers in the last six weeks or so. :-(
next prev parent reply other threads:[~2021-10-07 21:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-06 20:07 H.J. Lu
2021-10-06 20:07 ` [PATCH 1/2] libsanitizer: Merge with upstream H.J. Lu
2021-10-06 20:07 ` [PATCH 2/2] libsanitizer: Apply local patches H.J. Lu
2021-10-07 21:40 ` Gerald Pfeifer [this message]
2021-10-07 21:56 ` [PATCH 0/2] libsanitizer: Merge with upstream commit fdf4c035225d H.J. Lu
2021-10-09 22:28 ` Gerald Pfeifer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1ca1a49-4711-a3bb-bf88-2118efecf45@pfeifer.com \
--to=gerald@pfeifer.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hjl.tools@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).