Re: [PING][PATCH][GCC][ARM] Arm generates out of range conditional branches in Thumb2 (PR91816)

[Kyrill Tkachov <kyrylo.tkachov@foss.arm.com>]

On 1/30/20 2:42 PM, Stam Markianos-Wright wrote:
>
>
> On 1/28/20 10:35 AM, Kyrill Tkachov wrote:
>> Hi Stam,
>>
>> On 1/8/20 3:18 PM, Stam Markianos-Wright wrote:
>>>
>>> On 12/10/19 5:03 PM, Kyrill Tkachov wrote:
>>>> Hi Stam,
>>>>
>>>> On 11/15/19 5:26 PM, Stam Markianos-Wright wrote:
>>>>> Pinging with more correct maintainers this time :)
>>>>>
>>>>> Also would need to backport to gcc7,8,9, but need to get this 
>>>>> approved
>>>>> first!
>>>>>
>>>> Sorry for the delay.
>>> Same here now! Sorry totally forget about this in the lead up to Xmas!
>>>
>>> Done the changes marked below and also removed the unnecessary extra 
>>> #defines
>>> from the test.
>>
>>
>> This is ok with a nit on the testcase...
>>
>>
>> diff --git a/gcc/testsuite/gcc.target/arm/pr91816.c 
>> b/gcc/testsuite/gcc.target/arm/pr91816.c
>> new file mode 100644
>> index 
>> 0000000000000000000000000000000000000000..757c897e9c0db32709227b3fdf1b4a8033428232
>> --- /dev/null
>> +++ b/gcc/testsuite/gcc.target/arm/pr91816.c
>> @@ -0,0 +1,61 @@
>> +/* { dg-do compile } */
>> +/* { dg-options "-march=armv7-a -mthumb -mfpu=vfpv3-d16" }  */
>> +int printf(const char *, ...);
>> +
>>
>> I think this needs a couple of effective target checks like 
>> arm_hard_vfp_ok and arm_thumb2_ok. See other tests in gcc.target/arm 
>> that add -mthumb to the options.
>
> Hmm, looking back at this now, is there any reason why it can't just be:
>
> /* { dg-do compile } */
> /* { dg-require-effective-target arm_thumb2_ok } */
> /* { dg-additional-options "-mthumb" }  */
>
> were we don't override the march or fpu options at all, but just use 
> `require-effective-target arm_thumb2_ok` to make sure that thumb2 is 
> supported?
>
> The attached new diff does just that.
>

Works for me, there are plenty of configurations run with fpu that it 
should get the right coverage.

Ok (make sure commit the updated, if needed, ChangeLog as well)

Thanks!

Kyrill


> Cheers :)
>
> Stam.
>
>>
>> Thanks,
>> Kyrill
>>
>