From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 3DDB53858D26 for ; Fri, 26 Jul 2024 18:17:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3DDB53858D26 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3DDB53858D26 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.156.1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1722017879; cv=none; b=ck4DpTqwnSsSpftkKLlQI6s4P867fdCTDdXzFcO4roKzjMSaabNBQGUGFQQyqKFnUhwUbMWzsD8XjSl6qPs5kPo6aQPrOLspSEKANNEQ2g7KLP858J0PIG3d0eO/W5lQ0HYVa/Xc/8CDoVhLKmPQ0XdpmLCxiaPLRAvWzkEN+6Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1722017879; c=relaxed/simple; bh=vwU5t3olfs808pxb0NReaptP40jFsLUoiYYibRlQefU=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=LU2XhjKM9ndrRrg7RKmzJNTFsGlakIbwaX2YokzoFsH5XGPcMAUaL1aUHNQVxTdDC3y2Bxa/Lz5mq6iwvDOdxy0Q1e/L/M7r6GmQbTMBl7SwEY83cPNtI6y6xtnmdELUrtzE/OHGNFlXV/+IMKM7FpKXzn3+pspggd2GPo4z+BQ= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0356517.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 46QETMtx018019; Fri, 26 Jul 2024 18:17:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h= message-id:date:mime-version:subject:to:cc:references:from :in-reply-to:content-type:content-transfer-encoding; s=pp1; bh=O 0uMRwA0TjGXGhtiJO2d1S1vCW7eZ8fjvJbf8K79IQE=; b=OB+tCLLdcn81z3J5t JMkgV7vISjFcOFQsOqU2BwmNT0H/uQTnRrGHMdKVLRI9C5drHbhi2rMs2ZlKIXpq 5EPdDqbJrdkVUpQSh11mUGw7C7VqzWCN/XUyMTb34CizgIQziEaI1krCpNNbyWCp iuKik2qJwByNGvyURaWlS2sQfx/3okTG02C/cdUVCwXNaEMn7BHuQFjR7FfmI/Xg rHG9WiGTA8wyf+Flez2U0nOySniD/P9vKTv6RhEiTNrI1azP1NjrkWEA8mh510SB XQD6btMPhRd+R3cEW5ZklGvRMr9fb626VYNT9GpMGPYqDyuvFqLY3pZ8PvowZzSC TFWIw== Received: from ppma11.dal12v.mail.ibm.com (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 40mdktrk6j-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 26 Jul 2024 18:17:55 +0000 (GMT) Received: from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1]) by ppma11.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 46QGriIN009106; Fri, 26 Jul 2024 18:17:55 GMT Received: from smtprelay07.dal12v.mail.ibm.com ([172.16.1.9]) by ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 40gt93wcxt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 26 Jul 2024 18:17:55 +0000 Received: from smtpav03.wdc07v.mail.ibm.com (smtpav03.wdc07v.mail.ibm.com [10.39.53.230]) by smtprelay07.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 46QIHq4u45547818 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 26 Jul 2024 18:17:54 GMT Received: from smtpav03.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0398C5806C; Fri, 26 Jul 2024 18:17:52 +0000 (GMT) Received: from smtpav03.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 70A5158066; Fri, 26 Jul 2024 18:17:51 +0000 (GMT) Received: from [9.61.81.209] (unknown [9.61.81.209]) by smtpav03.wdc07v.mail.ibm.com (Postfix) with ESMTP; Fri, 26 Jul 2024 18:17:51 +0000 (GMT) Message-ID: Date: Fri, 26 Jul 2024 13:17:50 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] rs6000, Add new overloaded vector shift builtin int128, varients To: Carl Love , Segher Boessenkool Cc: gcc-patches@gcc.gnu.org, Kewen References: <163c9a9d-6755-4fbc-9c5a-82475fd1d4b1@linux.ibm.com> <20240724170324.GD28254@gate.crashing.org> <5292bd19-4003-4ade-b66e-52ad3c38ac1d@linux.ibm.com> <20240724184753.GH28254@gate.crashing.org> Content-Language: en-US From: Peter Bergner In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: 4NXT-33-qe9ev7HTE8u-N9q14HSOR-cm X-Proofpoint-ORIG-GUID: 4NXT-33-qe9ev7HTE8u-N9q14HSOR-cm X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-07-26_12,2024-07-26_01,2024-05-17_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 bulkscore=0 malwarescore=0 mlxlogscore=999 spamscore=0 priorityscore=1501 clxscore=1015 mlxscore=0 phishscore=0 lowpriorityscore=0 adultscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2407110000 definitions=main-2407260120 X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 7/26/24 12:07 PM, Carl Love wrote: > On 7/24/24 11:47 AM, Segher Boessenkool wrote: >>>>> +/* { dg-do run { target { int128 } && { power10_hw } } } */ >>>> Everything power10 is int128 always. >>> OK, so don't need the power10_hw. Changed to just int128 for the target: >> No, the other way around: you cannot run the code on machines without >> these (ISA 3.1) instructions! > > OK, made it { dg-do run { target power10_hw } } */ >> >> But p10 always satisfies the int128 predicate. Although, hrm, how >> about -m32 :-) > > If I test with -m64 I get 8 passes: > > make -j 1 && make check-gcc RUNTESTFLAGS="-v -v powerpc.exp=vec-shift-double-runnable-int128.c --target_board=unix'{-m64}'" > # of expected passes 8 > > If I test with -m32 I get unsupported test, > > make -j 1 && make check-gcc RUNTESTFLAGS="-v -v powerpc.exp=vec-shift-double-runnable-int128.c --target_board=unix'{-m32}'" > # of unsupported tests 1 > > Looking further into the output the checks say: > Checking pattern "hppa*-*-hpux*" with powerpc64le-unknown-linux-gnu > compiler exited with status 1 > output is: > cc1: error: '-m32' not supported in this configuration^M > > check_cached_effective_target power10_hw_available: returning 0 for unix/-m32 > is-effective-target: power10_hw 0 > > Looks like the power10_hw is sufficient to prevent the test from running. Don't need to explicitly check for int128 as well. That's only because you're testing on LE where -m32 is a not supported configuration. If you tested on BE, you'd probably see a FAIL for -m32. I think your initial target tests with int128 and power10_hw is actually correct. We have an internal Power10 partition (ltcd97-lp7) running a BE distro you can test this on. Peter