Re: [PATCH] Makefile.tpl: Avoid race condition in generating site.exp from the top level

[Jeff Law <jeffreyalaw@gmail.com>]

On 11/17/23 15:19, Lewis Hyatt wrote:
> Hello-
> 
> I often find it convenient to run a new c-c++-common test from the
> main build dir like:
> 
> $ make -j 2 RUNTESTFLAGS=dg.exp=new-test.c check-gcc-{c,c++}
> 
> I noticed that sometimes this produces a corrupted site.exp and then no
> tests work until it is remade manually. To avoid the issue, it is necessary
> to do "cd gcc; make site.exp" before running a parallel make from the top
> level directory. The below patch fixes it by just making that dependency on
> site.exp explicit in the top level Makefile. Is it OK please? Thanks...
> 
> -Lewis
> 
> -- >8 --
> 
> A command like "make -j 2 check-gcc-c check-gcc-c++" run in the top level of
> a fresh build directory does not work reliably. That will spawn two
> independent make processes inside the "gcc" directory, and each of those
> will attempt to create site.exp if it doesn't exist and will interfere with
> each other, producing often a corrupted or empty site.exp. Resolve that by
> making these targets depend on a new phony target which makes sure site.exp
> is created first before starting the recursive makes.
> 
> ChangeLog:
> 
> 	* Makefile.in: Regenerate.
> 	* Makefile.tpl: Add dependency on site.exp to check-gcc-* targets
OK
jeff