From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 06CB53857711 for ; Thu, 14 Dec 2023 01:38:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 06CB53857711 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 06CB53857711 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702517897; cv=none; b=BZacbydORWVQv03bO9FDC9lrVhdZRiDDVSLd4g9zDiDdLMyXmH2zQqvuGEa0eQgUEqY9oAHySl7uxl1AQKM+pSxfnh1AwrpuLgt5hrcssStH/fuIFl5o8735pD3sA4NC5nTNmJQH4JZJ/L9L9gKcc2JDL/j479+a5wmIfbBKa5A= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702517897; c=relaxed/simple; bh=0eQ5lUVHFO+40RN6zhq2xHjhX3KqmezUDlRdeC4jWP0=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=vfIRYXFuAcCQI2oeN4HN2MQHhDdqEN9UxLngUp3EdYLKg4JAgPulO4BaE9OagcetiHBKZXe+b76Zj7Ax+ABdgF6cBw9P0t6IyXt2y4ANDqtQlP+mO7I0z3SUwhXsKVdJvEOFc/ZHE6eCaN2wcqznMNpuHJSRqJ2HhjrcfpdKydg= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1702517895; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=E9r+UYQxpsT9/wWluX5Bt5sIJ1BarJrfO8kBJaNOOnY=; b=JWznGeBqmZXN5xHat7MMXzTerbIm2n8SfWHjkkQeynCqm488MYZe4BVN1W/tzYIYzFKPsa GnPWNWGr0oGjmy2H/uQ7fPwbofNIHhBA/iaJyD1ietv9OfPNR1Gyacvkn2f4li97tNgl/T XXOWGipl6APKQQ2BBBDhhHzNonlE3jk= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-515-PtcHP_7LMhCw6JROgc5Qcg-1; Wed, 13 Dec 2023 20:38:13 -0500 X-MC-Unique: PtcHP_7LMhCw6JROgc5Qcg-1 Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-67ab7e9d393so105179376d6.1 for ; Wed, 13 Dec 2023 17:38:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702517893; x=1703122693; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=E9r+UYQxpsT9/wWluX5Bt5sIJ1BarJrfO8kBJaNOOnY=; b=aEhKJHi18TfUNryE1e09ZoqHTuecvHJZ27UHHOUjVjRGPO/8LgHxNhpOWO6JXuu7T7 rPlS9h7h1wU1W5XE4i7y8UoWhi+GdPI/e3RKAeh6i1b+IcRfI03+5Rwa5k3v9kWsEG/Z 9rxt+NqO1GxI1WVPo8riS3AzQGfbU/DZLVHbtlDVpSUAu4Q8emT5imVxHKSx4dg0yFbV rOMptfnbNZ9CF7lvjKX6EbPt1rCMAy3hD5KApVjBy+9AAEhjJiuObzgQXPhd50nPyRu+ 0EsMOz8VtWpQrJnhavKvCz80DoiCRlGWs0mtRCzMmqSEbCElVkvJfcfXbjN5feuwpULl 9CSQ== X-Gm-Message-State: AOJu0YxPbQVYv2hwXZHzkyvHFUkxNTQtgUQ8wpdtW/HgiphGRoZe+3J2 ihopBbz77Sk4cXAaJUlaX7EAB6nVELYCNwO/n4x6bIPnODgzvp8bTZB9SoW/pHFQ0zdRXKGxNAJ WQddkJ0kxmw7XE8Hsog== X-Received: by 2002:ad4:41d0:0:b0:67e:fd7f:38e1 with SMTP id a16-20020ad441d0000000b0067efd7f38e1mr1564954qvq.62.1702517893335; Wed, 13 Dec 2023 17:38:13 -0800 (PST) X-Google-Smtp-Source: AGHT+IFeZ6F3JHZU4dAG+GlYIikNIukhaRoulRcDRJfgxoNFomn/wunF1uEslcywCqbK1fO5ObiJsw== X-Received: by 2002:ad4:41d0:0:b0:67e:fd7f:38e1 with SMTP id a16-20020ad441d0000000b0067efd7f38e1mr1564949qvq.62.1702517893070; Wed, 13 Dec 2023 17:38:13 -0800 (PST) Received: from [192.168.1.146] (130-44-146-16.s12558.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com. [130.44.146.16]) by smtp.gmail.com with ESMTPSA id cz18-20020a056214089200b0067ef25773dfsm1363249qvb.122.2023.12.13.17.38.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Dec 2023 17:38:12 -0800 (PST) Message-ID: Date: Wed, 13 Dec 2023 20:38:12 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [pushed 1/4] c++: copy location to AGGR_INIT_EXPR To: Marek Polacek Cc: gcc-patches@gcc.gnu.org References: <20231213164740.1591535-1-jason@redhat.com> From: Jason Merrill In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,RCVD_IN_SORBS_WEB,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/13/23 19:00, Marek Polacek wrote: > On Wed, Dec 13, 2023 at 11:47:37AM -0500, Jason Merrill wrote: >> Tested x86_64-pc-linux-gnu, applying to trunk. >> >> -- 8< -- >> >> When building an AGGR_INIT_EXPR from a CALL_EXPR, we shouldn't lose location >> information. > > I think the following should be an obvious fix, so I'll check it in. Thanks, I wonder why I wasn't seeing that? > -- >8 -- > Since r14-6505 I see: > > FAIL: g++.dg/cpp0x/constexpr-ex1.C -std=c++23 at line 91 (test for errors, line 89) > FAIL: g++.dg/cpp0x/constexpr-ex1.C -std=c++23 (test for excess errors) > FAIL: g++.dg/cpp0x/constexpr-ex1.C -std=c++26 at line 91 (test for errors, line 89) > FAIL: g++.dg/cpp0x/constexpr-ex1.C -std=c++26 (test for excess errors) > > and it wasn't fixed by r14-6511. So I'm fixing it with the below. > > gcc/testsuite/ChangeLog: > > * g++.dg/cpp0x/constexpr-ex1.C: Adjust expected diagnostic line. > --- > gcc/testsuite/g++.dg/cpp0x/constexpr-ex1.C | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gcc/testsuite/g++.dg/cpp0x/constexpr-ex1.C b/gcc/testsuite/g++.dg/cpp0x/constexpr-ex1.C > index 383d38a42d4..b26eb5d0c90 100644 > --- a/gcc/testsuite/g++.dg/cpp0x/constexpr-ex1.C > +++ b/gcc/testsuite/g++.dg/cpp0x/constexpr-ex1.C > @@ -88,7 +88,7 @@ struct resource { > }; > constexpr resource f(resource d) > { return d; } // { dg-error "non-.constexpr." "" { target { { { ! implicit_constexpr } && c++20_down } || c++11_only } } } > -// { dg-error "non-.constexpr." "" { target { c++23 && { ! implicit_constexpr } } } .-2 } > +// { dg-error "non-.constexpr." "" { target { c++23 && { ! implicit_constexpr } } } .-1 } > constexpr resource d = f(9); // { dg-message ".constexpr." "" { target { { ! implicit_constexpr } || c++11_only } } } > > // 4.4 floating-point constant expressions > > base-commit: c535360788e142a92e1d8b1db25bf4452e26f5fb