From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id D63B1385841D for ; Thu, 28 Jul 2022 08:46:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D63B1385841D Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 26S8hsjI011985; Thu, 28 Jul 2022 08:46:07 GMT Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com (PPS) with ESMTPS id 3hkq6sr1y1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 28 Jul 2022 08:46:07 +0000 Received: from m0098420.ppops.net (m0098420.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 26S8iN9V017774; Thu, 28 Jul 2022 08:46:06 GMT Received: from ppma04ams.nl.ibm.com (63.31.33a9.ip4.static.sl-reverse.com [169.51.49.99]) by mx0b-001b2d01.pphosted.com (PPS) with ESMTPS id 3hkq6sr1wx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 28 Jul 2022 08:46:06 +0000 Received: from pps.filterd (ppma04ams.nl.ibm.com [127.0.0.1]) by ppma04ams.nl.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 26S8ZOIK009979; Thu, 28 Jul 2022 08:46:04 GMT Received: from b06cxnps4075.portsmouth.uk.ibm.com (d06relay12.portsmouth.uk.ibm.com [9.149.109.197]) by ppma04ams.nl.ibm.com with ESMTP id 3hg96wp46b-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 28 Jul 2022 08:46:04 +0000 Received: from d06av22.portsmouth.uk.ibm.com (d06av22.portsmouth.uk.ibm.com [9.149.105.58]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 26S8k2pL22479166 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 28 Jul 2022 08:46:02 GMT Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 40F394C046; Thu, 28 Jul 2022 08:46:02 +0000 (GMT) Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id CC3E34C044; Thu, 28 Jul 2022 08:46:00 +0000 (GMT) Received: from [9.197.237.12] (unknown [9.197.237.12]) by d06av22.portsmouth.uk.ibm.com (Postfix) with ESMTP; Thu, 28 Jul 2022 08:46:00 +0000 (GMT) Message-ID: Date: Thu, 28 Jul 2022 16:45:59 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: PING^3 [PATCH] rs6000: Handle unresolved overloaded builtin [PR105485] Content-Language: en-US To: GCC Patches Cc: Peter Bergner , David Edelsohn , Segher Boessenkool References: <340fcec1-eb5e-e0f6-e8d1-ea819d4fd165@linux.ibm.com> <79282dcf-cca9-7ff3-aa25-e0d380e3b185@linux.ibm.com> From: "Kewen.Lin" In-Reply-To: <79282dcf-cca9-7ff3-aa25-e0d380e3b185@linux.ibm.com> Content-Type: text/plain; charset=UTF-8 X-TM-AS-GCONF: 00 X-Proofpoint-GUID: 74AggFENzz9AOzAUq1aNcmEIVXRA3w42 X-Proofpoint-ORIG-GUID: t2B7kkyBgVbPEA0NieXQWomrkZAi2UcD Content-Transfer-Encoding: 7bit X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-07-28_01,2022-07-28_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 priorityscore=1501 clxscore=1015 bulkscore=0 spamscore=0 suspectscore=0 adultscore=0 phishscore=0 mlxlogscore=999 impostorscore=0 lowpriorityscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000 definitions=main-2207280036 X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Jul 2022 08:46:09 -0000 Hi, Gentle ping https://gcc.gnu.org/pipermail/gcc-patches/2022-May/594699.html BR, Kewen > >> on 2022/5/13 13:29, Kewen.Lin via Gcc-patches wrote: >>> Hi, >>> >>> PR105485 exposes that new builtin function framework doesn't handle >>> unresolved overloaded builtin function well. With new builtin >>> function support, we don't have builtin info for any overloaded >>> rs6000_gen_builtins enum, since they are expected to be resolved to >>> one specific instance. So when function rs6000_gimple_fold_builtin >>> faces one unresolved overloaded builtin, the access for builtin info >>> becomes out of bound and gets ICE then. >>> >>> We should not try to fold one unresolved overloaded builtin there >>> and as the previous support we should emit one error message during >>> expansion phase like "unresolved overload for builtin ...". >>> >>> Bootstrapped and regtested on powerpc64-linux-gnu P8 and >>> powerpc64le-linux-gnu P9 and P10. >>> >>> Is it ok for trunk? >>> >>> BR, >>> Kewen >>> ----- >>> PR target/105485 >>> >>> gcc/ChangeLog: >>> >>> * config/rs6000/rs6000-builtin.cc (rs6000_gimple_fold_builtin): Add >>> the handling for unresolved overloaded builtin function. >>> (rs6000_expand_builtin): Likewise. >>> >>> gcc/testsuite/ChangeLog: >>> >>> * g++.target/powerpc/pr105485.C: New test. >>> >>> --- >>> gcc/config/rs6000/rs6000-builtin.cc | 13 +++++++++++++ >>> gcc/testsuite/g++.target/powerpc/pr105485.C | 9 +++++++++ >>> 2 files changed, 22 insertions(+) >>> create mode 100644 gcc/testsuite/g++.target/powerpc/pr105485.C >>> >>> diff --git a/gcc/config/rs6000/rs6000-builtin.cc b/gcc/config/rs6000/rs6000-builtin.cc >>> index e925ba9fad9..e102305c90c 100644 >>> --- a/gcc/config/rs6000/rs6000-builtin.cc >>> +++ b/gcc/config/rs6000/rs6000-builtin.cc >>> @@ -1294,6 +1294,11 @@ rs6000_gimple_fold_builtin (gimple_stmt_iterator *gsi) >>> enum tree_code bcode; >>> gimple *g; >>> >>> + /* For an unresolved overloaded builtin, return early here since there >>> + is no builtin info for it and we are unable to fold it. */ >>> + if (fn_code > RS6000_OVLD_NONE) >>> + return false; >>> + >>> size_t uns_fncode = (size_t) fn_code; >>> enum insn_code icode = rs6000_builtin_info[uns_fncode].icode; >>> const char *fn_name1 = rs6000_builtin_info[uns_fncode].bifname; >>> @@ -3295,6 +3300,14 @@ rs6000_expand_builtin (tree exp, rtx target, rtx /* subtarget */, >>> tree fndecl = TREE_OPERAND (CALL_EXPR_FN (exp), 0); >>> enum rs6000_gen_builtins fcode >>> = (enum rs6000_gen_builtins) DECL_MD_FUNCTION_CODE (fndecl); >>> + >>> + /* Emit error message if it's an unresolved overloaded builtin. */ >>> + if (fcode > RS6000_OVLD_NONE) >>> + { >>> + error ("unresolved overload for builtin %qF", fndecl); >>> + return const0_rtx; >>> + } >>> + >>> size_t uns_fcode = (size_t)fcode; >>> enum insn_code icode = rs6000_builtin_info[uns_fcode].icode; >>> >>> diff --git a/gcc/testsuite/g++.target/powerpc/pr105485.C b/gcc/testsuite/g++.target/powerpc/pr105485.C >>> new file mode 100644 >>> index 00000000000..a3b8290df8c >>> --- /dev/null >>> +++ b/gcc/testsuite/g++.target/powerpc/pr105485.C >>> @@ -0,0 +1,9 @@ >>> +/* It's to verify no ICE here, ignore error/warning messages since >>> + they are not test points here. */ >>> +/* { dg-excess-errors "pr105485" } */ >>> + >>> +template void __builtin_vec_vslv(); >>> +typedef __attribute__((altivec(vector__))) char T; >>> +T b (T c, T d) { >>> + return __builtin_vec_vslv(c, d); >>> +}