Re: [PATCH] inline: do not inline when no_profile_instrument_function is different

[Jeff Law <jeffreyalaw@gmail.com>]

On 8/18/2021 2:38 AM, Martin Liška wrote:
> On 6/23/21 3:15 PM, Martin Liška wrote:
>> On 6/23/21 2:38 PM, Jan Hubicka wrote:
>>> Is there reason to prevent the inlining once instrumentation is done?
>>
>> No ;)
>>
>>> I think you can just block it for early inliner.
>>
>> Sure. Do you have a handy predicate function that tells if einliner 
>> is done?
>>
>> Thanks,
>> Martin
>
> Hello.
>
> There's updated version of that patch that blocks inlining only during 
> einline IPA pass.
>
> Patch can bootstrap on x86_64-linux-gnu and survives regression tests.
>
> Ready to be installed?
> Thanks,
> Martin
>
> 0001-inline-do-not-einline-when-no_profile_instrument_fun.patch
>
>  From e2adaff9ed92bcc380e1368418da5ad2801fef4e Mon Sep 17 00:00:00 2001
> From: Martin Liska <mliska@suse.cz>
> Date: Tue, 22 Jun 2021 10:09:01 +0200
> Subject: [PATCH] inline: do not einline when no_profile_instrument_function is
>   different
>
> 	PR gcov-profile/80223
>
> gcc/ChangeLog:
>
> 	* ipa-inline.c (can_inline_edge_p): Similarly to sanitizer
> 	options, do not inline when no_profile_instrument_function
> 	attributes are different in early inliner. It's fine to inline
> 	it after PGO instrumentation.
OK
jeff