From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 46969 invoked by alias); 7 Jun 2016 12:04:04 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 46949 invoked by uid 89); 7 Jun 2016 12:04:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.8 required=5.0 tests=AWL,BAYES_40,RCVD_IN_DNSWL_NONE,SPF_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy=chung-lin, Chung-Lin, U*cltang, sk:cltang X-Spam-User: qpsmtpd, 2 recipients X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 07 Jun 2016 12:03:53 +0000 Received: from svr-orw-fem-02x.mgc.mentorg.com ([147.34.96.206] helo=SVR-ORW-FEM-02.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1bAFjZ-0004X3-7n from ChungLin_Tang@mentor.com ; Tue, 07 Jun 2016 05:03:49 -0700 Received: from [0.0.0.0] (147.34.91.1) by svr-orw-fem-02.mgc.mentorg.com (147.34.96.168) with Microsoft SMTP Server id 14.3.224.2; Tue, 7 Jun 2016 05:03:48 -0700 Subject: Re: [PATCH, Fortran, OpenACC] Fix PR70598, Fortran host_data ICE To: Bernhard Reutner-Fischer , References: <2b4f59d5-be38-2814-27bb-73aa7ffb4b8f@codesourcery.com> CC: gcc-patches , Thomas Schwinge , Jakub Jelinek From: Chung-Lin Tang Message-ID: Date: Tue, 07 Jun 2016 12:04:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2016-06/txt/msg00479.txt.bz2 Ping. On 2016/5/11 02:57 AM, Bernhard Reutner-Fischer wrote: > On May 9, 2016 4:26:50 PM GMT+02:00, Chung-Lin Tang wrote: >> Hi, this patch resolves an ICE for Fortran when using the OpenACC >> host_data directive. Actually, rather than say resolve, it's more like >> adjusting the front-end to same middle-end restrictions as C/C++, >> namely that we only support pointers or arrays for host_data right now. >> >> This patch contains a little bit of adjustments in >> fortran/openmp.c:resolve_omp_clauses(), >> and some testcase adjustments. This has been tested without regressions >> for Fortran. >> >> Is this okay for trunk? >> >> Thanks, >> Chung-Lin >> >> 2015-05-09 Chung-Lin Tang >> >> gcc/ >> * fortran/openmp.c (resolve_omp_clauses): Adjust use_device clause >> handling to only allow pointers and arrays. > > Fortran has it's own ChangeLog. The patch itself looks somewhat plausible to me, fwiw, but Jakub or a FE maintainer has the say. >