From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30355 invoked by alias); 8 Feb 2018 19:58:07 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 30032 invoked by uid 89); 8 Feb 2018 19:58:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.1 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_NONE autolearn=no version=3.3.2 spammy=Hx-languages-length:347 X-HELO: mail-qt0-f177.google.com Received: from mail-qt0-f177.google.com (HELO mail-qt0-f177.google.com) (209.85.216.177) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 08 Feb 2018 19:58:05 +0000 Received: by mail-qt0-f177.google.com with SMTP id d14so7765694qtg.1 for ; Thu, 08 Feb 2018 11:58:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Dfq9QtIO938s2PokkECV748F0MjItERYzj8lJGZMXl0=; b=Q7/1KPGa8Eyz9Z1CsdoMVd+qZksWX4bkk5BFi8po8X7agvqVYqwR4f/OXiCQVXGRfh 8nKiACLvaI0hndYuFUW6aoPN3TAu5NH2E3EDbplpet9rciJQHGu7widgAURNiG4L8T6W hegDDDELilOPxJ3ogUopn8dSRXHF0uZPuVVjtxm9Mwed3FGd3dReEKUe1r+YjSmD7eAj ohDfb6ZI8Nykp7KpR6FJyg5h/1KXPHE+C+V1P4ARS4Uq4D/J3ZkP1aiSMo61GzkteAmj Hgvb/J0jQNx92ZPWktauHXf0nocGe9ROmRIZ8PDL7+qq2r2v8Nq8uuzCUPuPtW8Ehwfh FkAw== X-Gm-Message-State: APf1xPAsR6UIhdU4BGpf0jHg1YGFxv3sVFBXbfwSm0lSJxiFTq1f2qdk kBTwJZJ1JR82pBnNcOzbo1Zs0n2jegI= X-Google-Smtp-Source: AH8x226Y6pXEVgdkb8SCDaOEbaqIJxr5DkkXIFw5KsmB3pvLmRzu/BhWhAIsMytHtJtzun8UDNPVhg== X-Received: by 10.200.29.2 with SMTP id d2mr577843qtl.246.1518119883609; Thu, 08 Feb 2018 11:58:03 -0800 (PST) Received: from [192.168.1.132] (209-6-90-240.s1774.c3-0.smr-ubr1.sbo-smr.ma.cable.rcncustomer.com. [209.6.90.240]) by smtp.gmail.com with ESMTPSA id t22sm543982qtj.39.2018.02.08.11.58.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 08 Feb 2018 11:58:02 -0800 (PST) Subject: Re: [SFN+LVU+IEPM v4 7/9] [LVU] Introduce location views To: Alexandre Oliva Cc: Jeff Law , Richard Biener , Jakub Jelinek , gcc-patches References: <20171110023448.28164-7-aoliva@redhat.com> <7d731476-256b-28c3-69fe-e28c116281d1@redhat.com> <309c52a4-e2cb-2cc4-a31f-c57b717d10c3@redhat.com> From: Jason Merrill Message-ID: Date: Thu, 08 Feb 2018 19:58:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2018-02/txt/msg00460.txt.bz2 On 02/07/2018 02:36 AM, Alexandre Oliva wrote: > +/* Output symbol LAB1 as an unsigned LEB128 quantity. */ Let's mention here that the value of LAB1 must be an assemble-time constant (such as a view counter), since we can't have LEB128 relocations. With that, the patch looks OK. Jason