From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id C3477385842B for ; Wed, 1 Sep 2021 19:25:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C3477385842B Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-518-DtyAb8SJNEaPCSMCcKAHlw-1; Wed, 01 Sep 2021 15:25:20 -0400 X-MC-Unique: DtyAb8SJNEaPCSMCcKAHlw-1 Received: by mail-qk1-f197.google.com with SMTP id 70-20020a370b49000000b003d2f5f0dcc6so377786qkl.9 for ; Wed, 01 Sep 2021 12:25:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=mPJVhGEGYQUJy+tuVeAXisP8BC0bdd5UQPzTwzLGq/4=; b=JN/KlTbN8CVzCcBgmQfu5Isq7JS/Lmo8rcMQf3dmVW+Z343QMGVCHhDKo9xbToERPQ iWLfgCeO5D1YPj3FOy1rtWilEZqDu06JIr/4abCvCU16fWvlcBVkTRvia1l6L31WGqbA ZCyjxD4m3QQJBxsLljVUmR7UgQNPtcnMcJfh1oVFyKMs+T/a5Ok9KhzltbgxJHO25rQ+ 4iFaC62hIG/Q2azISZsx+pWNW8H1RzKRgoz3ByE1PLWcarlFUuSfae/rtADaT+DqqbL+ EU2cdkek7OQNTPlvoOVVXbqq0QMwDrBvdN9BAQnuksEJJlya4aeQWlgV2Nqes30UU2qE 1cyQ== X-Gm-Message-State: AOAM533VGuZ7G62SSdUP1QytGIxeYUg1gSof0cFu2+1r4uCRBMFDhb/o +VR1V8lvIHeM7SLIYa+vFWeay0O0EpNg7Y/2iWYASglbyi4JeNB/ENE8TWyC6nC5aWWdtXrWeqW Q3gP+15zG0GcKbI4UkJ+TOvbVjJ6dCjQoVQmA52RTzA8v4OVB21yzr038GWHENeIAFQ== X-Received: by 2002:a05:6214:54b:: with SMTP id ci11mr1415286qvb.24.1630524319313; Wed, 01 Sep 2021 12:25:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyhZ8NyHvg1xPnnzl0hDmxXmiucjEmNUknZhYxkShdoxEgZSI6veEtd046sCkgPaGuykWvnfQ== X-Received: by 2002:a05:6214:54b:: with SMTP id ci11mr1415266qvb.24.1630524319026; Wed, 01 Sep 2021 12:25:19 -0700 (PDT) Received: from [192.168.1.149] (130-44-159-43.s11817.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com. [130.44.159.43]) by smtp.gmail.com with ESMTPSA id d6sm323158qkn.119.2021.09.01.12.25.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Sep 2021 12:25:18 -0700 (PDT) Subject: Re: C++ patch ping To: Jakub Jelinek Cc: gcc-patches@gcc.gnu.org References: <20210830071140.GJ920497@tucnak> From: Jason Merrill Message-ID: Date: Wed, 1 Sep 2021 15:25:17 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210830071140.GJ920497@tucnak> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_SHORT, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Sep 2021 19:25:33 -0000 On 8/30/21 3:11 AM, Jakub Jelinek wrote: > Hi! > > I'd like to ping the following patches > > libcpp: __VA_OPT__ p1042r1 placemarker changes [PR101488] > https://gcc.gnu.org/pipermail/gcc-patches/2021-July/575621.html > together with your > https://gcc.gnu.org/pipermail/gcc-patches/2021-August/577602.html > incremental patch (successfully tested on x86_64-linux and i686-linux). OK, thanks. > libcpp, v2: Implement C++23 P1949R7 - C++ Identifier Syntax using Unicode Standard Annex 31 [PR100977] > https://gcc.gnu.org/pipermail/gcc-patches/2021-August/576854.html > The incremental patch for splitting tokens at unsupported characters > withdrawn, the above is the base patch. My reply to that patch approved it with a suggestion for a tweak to ucn_valid_in_identifier. Quoting it here: >> @@ -998,6 +998,28 @@ ucn_valid_in_identifier (cpp_reader *pfi >> nst->previous = c; >> nst->prev_class = ucnranges[mn].combine; >> + if (!CPP_PEDANTIC (pfile)) >> + { >> + /* If not -pedantic, accept as character that may >> + begin an identifier a union of characters allowed >> + at that position in each of the character sets. */ >> + if ((ucnranges[mn].flags & (C99 | N99)) == C99 >> + || (ucnranges[mn].flags & CXX) != 0 >> + || (ucnranges[mn].flags & (C11 | N11)) == C11 >> + || (ucnranges[mn].flags & (CXX23 | NXX23)) == CXX23) >> + return 1; >> + return 2; >> + } >> + >> + if (CPP_OPTION (pfile, cxx23_identifiers)) >> + invalid_start_flags = NXX23; >> + else if (CPP_OPTION (pfile, c11_identifiers)) >> + invalid_start_flags = N11; >> + else if (CPP_OPTION (pfile, c99)) >> + invalid_start_flags = N99; >> + else >> + invalid_start_flags = 0; >> + >> /* In C99, UCN digits may not begin identifiers. In C11 and C++11, >> UCN combining characters may not begin identifiers. */ >> if (ucnranges[mn].flags & invalid_start_flags) > > I might check invalid_start_flags first, and return 1 if not set, then check all the other flags when not pedantic, and finally return 2 if nothing matches. OK with or without this change. Jason