On 02/10/2017 10:32 AM, Uros Bizjak wrote: > On Tue, Feb 7, 2017 at 7:38 PM, Daniel Santos wrote: > >> Uros or Jan, >> Please take this as a ping, as I never bothered pinging after submitting v2 >> since I found a few more issues with it. :) Although I realize this would be >> a GCC 8 stage 1 item, I would like to try to get it finished up and >> tentatively approved as soon as I can. I have tried to summarize this patch >> set as clearly and succinctly below as possible. Thanks! > > You will need a sign-off from cygwin od mingw-w64 maintainer (CC'd). > While I can review the patch in the sense that it won't break generic > code, I don't know nothing about mingw-64 to give you any meaningful > advice. > > Uros. > Hi, Thanks for the code size reduction patch, I have a few questions: 1. How does code compiled with -moutline-msabi-xlogues interact with older code compiled without it? Are these only called on ABI transition? 2. Does this mean code compiled with -moutline-msabi-xlogues is not usable with older GCC? (no a problem, just something to note). 3. Is the old behavior (emit inline code) still default? mingw-w64 itself does not use any ms_abi/sysv_abi marked functions internally, so it should be unaffected. I don't think Cygwin uses any either, but I need to double check.