From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 96995 invoked by alias); 3 Mar 2020 12:26:15 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 70064 invoked by uid 89); 3 Mar 2020 12:26:02 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-21.6 required=5.0 tests=AWL,BAYES_20,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_MANYTO,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.1 spammy=growth, linkw@gcc.gnu.org, noones, optin X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0b-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.158.5) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 03 Mar 2020 12:26:00 +0000 Received: from pps.filterd (m0098417.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 023CKpGA048080 for ; Tue, 3 Mar 2020 07:25:58 -0500 Received: from e06smtp07.uk.ibm.com (e06smtp07.uk.ibm.com [195.75.94.103]) by mx0a-001b2d01.pphosted.com with ESMTP id 2yfmqb3efp-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 03 Mar 2020 07:25:58 -0500 Received: from localhost by e06smtp07.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 3 Mar 2020 12:25:56 -0000 Received: from b06avi18626390.portsmouth.uk.ibm.com (9.149.26.192) by e06smtp07.uk.ibm.com (192.168.101.137) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Tue, 3 Mar 2020 12:25:54 -0000 Received: from d06av22.portsmouth.uk.ibm.com (d06av22.portsmouth.uk.ibm.com [9.149.105.58]) by b06avi18626390.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 023COtcx41091406 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 3 Mar 2020 12:24:55 GMT Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 99C984C040; Tue, 3 Mar 2020 12:25:53 +0000 (GMT) Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1EFD84C04A; Tue, 3 Mar 2020 12:25:51 +0000 (GMT) Received: from KewenLins-MacBook-Pro.local (unknown [9.197.252.146]) by d06av22.portsmouth.uk.ibm.com (Postfix) with ESMTP; Tue, 3 Mar 2020 12:25:50 +0000 (GMT) Subject: Re: [PATCH 2/4 GCC11] Add target hook stride_dform_valid_p To: Segher Boessenkool , GCC Patches , Bill Schmidt , "bin.cheng" , Richard Guenther , richard.sandiford@arm.com References: <20200120131451.GX3191@gate.crashing.org> <555ba68c-140c-a263-86b6-c5ccf32d4752@linux.ibm.com> From: "Kewen.Lin" Date: Tue, 03 Mar 2020 12:26:00 -0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/mixed; boundary="------------B57843829A43F6FB9FDC26C3" x-cbid: 20030312-0028-0000-0000-000003E07384 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 20030312-0029-0000-0000-000024A59FA5 Message-Id: X-IsSubscribed: yes X-SW-Source: 2020-03/txt/msg00117.txt This is a multi-part message in MIME format. --------------B57843829A43F6FB9FDC26C3 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-length: 2116 >> Hi Segher and Richard S., >> >> Sorry for late response. Thanks for your comments on legitimate_address_p hook >> and function addr_offset_valid_p. I updated the IVOPTs part with >> addr_offset_valid_p, although rs6000_legitimate_offset_address_p doesn't check >> strictly all the time (like worst_case is false), it works well with SPEC2017. >> Based on it, the hook is simplified as attached patch. > > Thanks for the update. I think it would be better to add a --param > rather than a bool hook though. Targets can then change the default > (if necessary) using SET_OPTION_IF_UNSET. The user can override the > default if they want to. > > It might also be better to start with an opt-out rather than an opt-in > (i.e. with the default param value being true rather than false). > With a default-off option, it's much harder to tell whether something > has been deliberately turned off or whether no-one's thought about it > either way. We can always flip the default later if it turns out that > nothing other than rs6000 benefits. > > Richard > Hi Richard, Thanks for your comments! It's a good idea to use param due to the flexibility. And yes, it sounds good to have more targets to try and make it better. But I have a bit concern on turning it on by default. Since it replies on unroll factor estimation, as part 1/4 shows, it calls targetm.loop_unroll_adjust if target supports, which used to work on RTL level. To avoid possible ICE, I'm intended to turn it off for those targets (s390 & i386) with that hook, since without good understanding on those targets, it's hard for me to extend them with gimple level support. Does it make sense? The updated patch has been attached. BR, Kewen --------- gcc/ChangeLog 2020-03-03 Kewen Lin * doc/invoke.texi (iv-consider-reg-offset-for-unroll): Document new option. * params.opt (iv-consider-reg-offset-for-unroll): New. * config/s390/s390.c (s390_option_override_internal): Disable parameter iv-consider-reg-offset-for-unroll by default. * config/i386/i386-options.c (ix86_option_override_internal): Likewise. --------------B57843829A43F6FB9FDC26C3 Content-Type: text/plain; charset=UTF-8; x-mac-type="0"; x-mac-creator="0"; name="param.diff" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="param.diff" Content-length: 4384 ZGlmZiAtLWdpdCBhL2djYy9jb25maWcvaTM4Ni9pMzg2LW9wdGlvbnMuYyBi L2djYy9jb25maWcvaTM4Ni9pMzg2LW9wdGlvbnMuYwppbmRleCBlMGJlNDkz Li40MWM5OWIzIDEwMDY0NAotLS0gYS9nY2MvY29uZmlnL2kzODYvaTM4Ni1v cHRpb25zLmMKKysrIGIvZ2NjL2NvbmZpZy9pMzg2L2kzODYtb3B0aW9ucy5j CkBAIC0yOTAyLDYgKzI5MDIsMTIgQEAgaXg4Nl9vcHRpb25fb3ZlcnJpZGVf aW50ZXJuYWwgKGJvb2wgbWFpbl9hcmdzX3AsCiAgIGlmIChpeDg2X2luZGly ZWN0X2JyYW5jaCAhPSBpbmRpcmVjdF9icmFuY2hfa2VlcCkKICAgICBTRVRf T1BUSU9OX0lGX1VOU0VUIChvcHRzLCBvcHRzX3NldCwgZmxhZ19qdW1wX3Rh YmxlcywgMCk7CiAKKyAgLyogRGlzYWJsZSB0aGlzIGZvciBub3cgdGlsbCBs b29wX3Vucm9sbF9hZGp1c3Qgc3VwcG9ydHMgZ2ltcGxlIGxldmVsIGNoZWNr cywKKyAgICAgdG8gYXZvaWQgcG9zc2libGUgSUNFLiAgKi8KKyAgaWYgKG9w dHMtPnhfb3B0aW1pemUgPj0gMSkKKyAgICBTRVRfT1BUSU9OX0lGX1VOU0VU IChvcHRzLCBvcHRzX3NldCwKKwkJCSBwYXJhbV9pdl9jb25zaWRlcl9yZWdf b2Zmc2V0X2Zvcl91bnJvbGwsIDApOworCiAgIHJldHVybiB0cnVlOwogfQog CmRpZmYgLS1naXQgYS9nY2MvY29uZmlnL3MzOTAvczM5MC5jIGIvZ2NjL2Nv bmZpZy9zMzkwL3MzOTAuYwppbmRleCBlYmJhNjcwLi5hZTRjMmJkIDEwMDY0 NAotLS0gYS9nY2MvY29uZmlnL3MzOTAvczM5MC5jCisrKyBiL2djYy9jb25m aWcvczM5MC9zMzkwLmMKQEAgLTE1MzE4LDYgKzE1MzE4LDEyIEBAIHMzOTBf b3B0aW9uX292ZXJyaWRlX2ludGVybmFsIChzdHJ1Y3QgZ2NjX29wdGlvbnMg Km9wdHMsCiAgICAgIG5vdCB0aGUgY2FzZSB3aGVuIHRoZSBjb2RlIHJ1bnMg YmVmb3JlIHRoZSBwcm9sb2cuICovCiAgIGlmIChvcHRzLT54X2ZsYWdfZmVu dHJ5ICYmICFUQVJHRVRfNjRCSVQpCiAgICAgZXJyb3IgKCIlPC1tZmVudHJ5 JT4gaXMgc3VwcG9ydGVkIG9ubHkgZm9yIDY0LWJpdCBDUFVzIik7CisKKyAg LyogRGlzYWJsZSB0aGlzIGZvciBub3cgdGlsbCBsb29wX3Vucm9sbF9hZGp1 c3Qgc3VwcG9ydHMgZ2ltcGxlIGxldmVsIGNoZWNrcywKKyAgICAgdG8gYXZv aWQgcG9zc2libGUgSUNFLiAgKi8KKyAgaWYgKG9wdHMtPnhfb3B0aW1pemUg Pj0gMSkKKyAgICBTRVRfT1BUSU9OX0lGX1VOU0VUIChvcHRzLCBvcHRzX3Nl dCwKKwkJCSBwYXJhbV9pdl9jb25zaWRlcl9yZWdfb2Zmc2V0X2Zvcl91bnJv bGwsIDApOwogfQogCiBzdGF0aWMgdm9pZApkaWZmIC0tZ2l0IGEvZ2NjL2Rv Yy9pbnZva2UudGV4aSBiL2djYy9kb2MvaW52b2tlLnRleGkKaW5kZXggZmE5 OGUyZi4uNTAyMDMxYyAxMDA2NDQKLS0tIGEvZ2NjL2RvYy9pbnZva2UudGV4 aQorKysgYi9nY2MvZG9jL2ludm9rZS50ZXhpCkBAIC0xMjIyMCw2ICsxMjIy MCwxNSBAQCBJZiB0aGUgbnVtYmVyIG9mIGNhbmRpZGF0ZXMgaW4gdGhlIHNl dCBpcyBzbWFsbGVyIHRoYW4gdGhpcyB2YWx1ZSwKIGFsd2F5cyB0cnkgdG8g cmVtb3ZlIHVubmVjZXNzYXJ5IGl2cyBmcm9tIHRoZSBzZXQKIHdoZW4gYWRk aW5nIGEgbmV3IG9uZS4KIAorQGl0ZW0gaXYtY29uc2lkZXItcmVnLW9mZnNl dC1mb3ItdW5yb2xsCitXaGVuIFJUTCB1bnJvbGxpbmcgcGVyZm9ybXMgb24g YSBsb29wLCB0aGUgZHVwbGljYXRlZCBsb29wIGl0ZXJhdGlvbnMgaW50cm9k dWNlCithcHByb3ByaWF0ZSBpbmR1Y3Rpb24gdmFyaWFibGUgc3RlcCB1cGRh dGUgZXhwcmVzc2lvbnMuICBCdXQgaWYgYW4gaW5kdWN0aW9uCit2YXJpYWJs ZSBpcyBkZXJpdmVkIGZyb20gYWRkcmVzcyBvYmplY3QsIGl0IGlzIHByb2Zp dGFibGUgdG8gZmlsbCBpdHMgcmVxdWlyZWQKK29mZnNldCB1cGRhdGVzIGlu dG8gYXBwcm9wcmlhdGUgbWVtb3J5IGFjY2VzcyBleHByZXNzaW9ucyBpZiB0 YXJnZXQgbWVtb3J5CithY2Nlc3Npbmcgc3VwcG9ydHMgdGhlIHJlZ2lzdGVy IG9mZnNldCBtb2RlIGFuZCB0aGUgcmVzdWx0ZWQgb2Zmc2V0IGlzIGluIHRo ZQordmFsaWQgcmFuZ2UuICBUaGUgaW5kdWN0aW9uIHZhcmlhYmxlIG9wdGlt aXphdGlvbnMgY29uc2lkZXIgdGhpcyBpbmZvcm1hdGlvbgorZm9yIGJldHRl ciB1bnJvbGxpbmcgY29kZS4gIEl0IHJlcXVpcmVzIHVucm9sbCBmYWN0b3Ig ZXN0aW1hdGlvbiBpbiBtaWRkbGUtZW5kLgorCiBAaXRlbSBhdmctbG9vcC1u aXRlcgogQXZlcmFnZSBudW1iZXIgb2YgaXRlcmF0aW9ucyBvZiBhIGxvb3Au CiAKZGlmZiAtLWdpdCBhL2djYy9wYXJhbXMub3B0IGIvZ2NjL3BhcmFtcy5v cHQKaW5kZXggOGU0MjE3ZC4uMzE0MjRjZiAxMDA2NDQKLS0tIGEvZ2NjL3Bh cmFtcy5vcHQKKysrIGIvZ2NjL3BhcmFtcy5vcHQKQEAgLTI3MCw2ICsyNzAs MTAgQEAgQm91bmQgb24gbnVtYmVyIG9mIGNhbmRpZGF0ZXMgYmVsb3cgdGhh dCBhbGwgY2FuZGlkYXRlcyBhcmUgY29uc2lkZXJlZCBpbiBpdiBvcHQKIENv bW1vbiBKb2luZWQgVUludGVnZXIgVmFyKHBhcmFtX2l2X21heF9jb25zaWRl cmVkX3VzZXMpIEluaXQoMjUwKSBQYXJhbSBPcHRpbWl6YXRpb24KIEJvdW5k IG9uIG51bWJlciBvZiBpdiB1c2VzIGluIGxvb3Agb3B0aW1pemVkIGluIGl2 IG9wdGltaXphdGlvbnMuCiAKKy1wYXJhbT1pdi1jb25zaWRlci1yZWctb2Zm c2V0LWZvci11bnJvbGw9CitDb21tb24gSm9pbmVkIFVJbnRlZ2VyIFZhcihw YXJhbV9pdl9jb25zaWRlcl9yZWdfb2Zmc2V0X2Zvcl91bnJvbGwpIEluaXQo MSkgT3B0aW1pemF0aW9uIEludGVnZXJSYW5nZSgwLCAxKSBQYXJhbQorV2hl dGhlciBpdiBvcHRpbWl6YXRpb25zIG1hcmsgcmVnaXN0ZXIgb2Zmc2V0IHZh bGlkIGdyb3VwcyBhbmQgY29uc2lkZXIgdGhlaXIgZGVyaXZlZCBpdiBjYW5k aWRhdGVzIHdvdWxkIGJlIHByb2ZpdGFibGUgd2l0aCBlc3RpbWF0ZWQgdW5y b2xsIGZhY3RvciBjb25zaWRlcmF0aW9uLgorCiAtcGFyYW09anVtcC10YWJs ZS1tYXgtZ3Jvd3RoLXJhdGlvLWZvci1zaXplPQogQ29tbW9uIEpvaW5lZCBV SW50ZWdlciBWYXIocGFyYW1fanVtcF90YWJsZV9tYXhfZ3Jvd3RoX3JhdGlv X2Zvcl9zaXplKSBJbml0KDMwMCkgUGFyYW0gT3B0aW1pemF0aW9uCiBUaGUg bWF4aW11bSBjb2RlIHNpemUgZ3Jvd3RoIHJhdGlvIHdoZW4gZXhwYW5kaW5n IGludG8gYSBqdW1wIHRhYmxlIChpbiBwZXJjZW50KS4gIFRoZSBwYXJhbWV0 ZXIgaXMgdXNlZCB3aGVuIG9wdGltaXppbmcgZm9yIHNpemUuCg== --------------B57843829A43F6FB9FDC26C3--