From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 0FB723838002 for ; Tue, 24 May 2022 13:15:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0FB723838002 Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-26-r3A0z7oINUaUge0I-EH8kQ-1; Tue, 24 May 2022 09:15:15 -0400 X-MC-Unique: r3A0z7oINUaUge0I-EH8kQ-1 Received: by mail-qk1-f200.google.com with SMTP id j12-20020ae9c20c000000b0069e8ac6b244so13482331qkg.1 for ; Tue, 24 May 2022 06:15:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=x/Ngb5MVaQWn5lDR0x2UWXlRGKZBc5O2PlJQkOePHsw=; b=bDK0dpIDPvLmdTzsWFlEFwsuxtYKxE4a+oi/oy+IPdeaJA5UKZx9PEYAvjpAHEL7nw w8vctlqmOX56/FF6Q4t6AV3KUA4KjmH7vH8qs3d8yqAim/9xvO0q8moPExwpgFlYA1Ke Z2FZUCI9PWjXoMH5bqZ+BLremkdm4BtkZyoyNnSkm3NhvoeyM7hfWYwYjtHOnW1N6yxP XU6q4HDdi5cbT6mOLf7s201UvN5OitXTXpTxkeploOvHrz/Q3/NS/owQZWULThWK9hwK V+GAXogPLbFytqRwj+5BZNitBc1/tqC9ZdrRZMXNGChTWBRJEQ6U5vCkzwTs5rXwsfyW M8yw== X-Gm-Message-State: AOAM530DIgJX8S8H3k+PAF6tzYinSpK7GNOQcU484voUyXYNrCrAKDo8 lbA//vHIg/AHklxnjfu6r5DB1v5DFdI0GbIg5H4YuGh23MOmgxbOjLKRg9Pg5xKXQmuhtZNA88Z MkBD/sNLgcOuqKTJ42w== X-Received: by 2002:a05:6214:c69:b0:462:3c3c:b60e with SMTP id t9-20020a0562140c6900b004623c3cb60emr8052936qvj.117.1653398114901; Tue, 24 May 2022 06:15:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzPdf5lv+rOJmu4Gx7IXewh2fMuHA1jzJwNAFaG4urojOd2y/louIHmeE8vBvRQZx93bbnjOQ== X-Received: by 2002:a05:6214:c69:b0:462:3c3c:b60e with SMTP id t9-20020a0562140c6900b004623c3cb60emr8052906qvj.117.1653398114611; Tue, 24 May 2022 06:15:14 -0700 (PDT) Received: from t14s.localdomain (c-73-69-212-193.hsd1.ma.comcast.net. [73.69.212.193]) by smtp.gmail.com with ESMTPSA id a68-20020a37b147000000b006a33fc1113csm6244516qkf.23.2022.05.24.06.15.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 May 2022 06:15:13 -0700 (PDT) Message-ID: Subject: Re: [PATCH 05/10] d: add 'final' and 'override' to gcc/d/*.cc 'visit' impls From: David Malcolm To: Iain Buclaw , gcc-patches@gcc.gnu.org Date: Tue, 24 May 2022 09:15:12 -0400 In-Reply-To: <1653396934.mszzm5qg39.astroid@pulse.none> References: <20220523192834.3785673-1-dmalcolm@redhat.com> <20220523192834.3785673-6-dmalcolm@redhat.com> <1653396934.mszzm5qg39.astroid@pulse.none> User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00, BODY_8BITS, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 May 2022 13:15:18 -0000 On Tue, 2022-05-24 at 14:56 +0200, Iain Buclaw wrote: > Excerpts from David Malcolm via Gcc-patches's message of Mai 23, 2022 > 9:28 pm: > > gcc/d/ChangeLog: > >         * decl.cc: Add "final" and "override" to all "visit" vfunc > > decls > >         as appropriate. > >         * expr.cc: Likewise. > >         * toir.cc: Likewise. > >         * typeinfo.cc: Likewise. > >         * types.cc: Likewise. > > > > Signed-off-by: David Malcolm > > > Thanks David! > > Looks OK to me. > > Iain. Thanks; I've pushed it to trunk as r13-736-g442cf0977a2993. FWIW, to repeat something I said in the cover letter, I tried hacking - Werror=suggest-override into the Makefile whilst I was creating the patches, and IIRC there were a bunch of them in the gcc/d/dmd subdirectory - but that code is copied from the D community upstream, right? So maybe if that D parser C++ code requires a C++11 compiler, perhaps they might want to add "final" and "override" specifiers to it as appropriate, to better document the intent of the decls? Hope this is constructive Dave