From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 2FE7D3881D31 for ; Mon, 13 Feb 2023 13:24:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2FE7D3881D31 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 31DCOQTp003446 for ; Mon, 13 Feb 2023 13:24:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=70eBxYUWGxB7otkcEX6fpdqlDChtFemrCpzmLksNIuE=; b=lGjKYlBhADWUFOYV0vK1g8RAuDy5ddTaFYcAbXiB6zIXO3pvcSUE/YculMgPpXWVQsjc VsZplSe5buWNzFOuVTaaZIeVcv3YGBc8Rx/8mk8Ay6mF09OnrjiRK0IUeCdEfgGnQGTx LfYXHNFbfN887PrTyvVy1quzKR5jfFhG3m66c+CtckTheblUbVctn64npx9IGyyapSVx ghUhh9JPknmIdPHpd0yxfvMoVpPrhjkTvxdotorinw7nnaMXlErjo9kVIXjPkp+BccMo zX2BU0ybTV8FTWCbUGiJRAalOY69wC9HyE8Qm0IYTHtUSiTDQiY0V/G792s6qOrMNhWZ yg== Received: from ppma03ams.nl.ibm.com (62.31.33a9.ip4.static.sl-reverse.com [169.51.49.98]) by mx0b-001b2d01.pphosted.com (PPS) with ESMTPS id 3nqn6dshs4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 13 Feb 2023 13:24:55 +0000 Received: from pps.filterd (ppma03ams.nl.ibm.com [127.0.0.1]) by ppma03ams.nl.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 31DDAkSx018185 for ; Mon, 13 Feb 2023 13:24:53 GMT Received: from smtprelay01.fra02v.mail.ibm.com ([9.218.2.227]) by ppma03ams.nl.ibm.com (PPS) with ESMTPS id 3np2n6jp88-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 13 Feb 2023 13:24:53 +0000 Received: from smtpav07.fra02v.mail.ibm.com (smtpav07.fra02v.mail.ibm.com [10.20.54.106]) by smtprelay01.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 31DDOoZ545416956 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 13 Feb 2023 13:24:50 GMT Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 09EE620043; Mon, 13 Feb 2023 13:24:50 +0000 (GMT) Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C6BE520040; Mon, 13 Feb 2023 13:24:49 +0000 (GMT) Received: from [9.171.75.53] (unknown [9.171.75.53]) by smtpav07.fra02v.mail.ibm.com (Postfix) with ESMTP; Mon, 13 Feb 2023 13:24:49 +0000 (GMT) Message-ID: Date: Mon, 13 Feb 2023 14:24:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH] IBM zSystems: Do not propagate scheduler state across basic blocks [PR108102] Content-Language: en-US To: Stefan Schulze Frielinghaus , rdapp@linux.ibm.com, gcc-patches@gcc.gnu.org References: <20230211155934.3539787-1-stefansf@linux.ibm.com> From: Andreas Krebbel In-Reply-To: <20230211155934.3539787-1-stefansf@linux.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: lIgU1WkZJ3FA62Q5q9dsJKRsmNbi7pZx X-Proofpoint-ORIG-GUID: lIgU1WkZJ3FA62Q5q9dsJKRsmNbi7pZx X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22 definitions=2023-02-13_09,2023-02-13_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 mlxscore=0 malwarescore=0 suspectscore=0 bulkscore=0 mlxlogscore=999 adultscore=0 spamscore=0 lowpriorityscore=0 phishscore=0 priorityscore=1501 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2302130117 X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2/11/23 16:59, Stefan Schulze Frielinghaus wrote: > So far we propagate scheduler state across basic blocks within EBBs and > reset the state otherwise. In certain circumstances the entry block of > an EBB might be empty, i.e., no_real_insns_p is true. In those cases > scheduler state is not reset and subsequently wrong state is propagated > to following blocks of the same EBB. > > Since the performance benefit of tracking state across basic blocks is > questionable on modern hardware, simply reset the state for each basic > block. > > Fix also resetting f{p,x}d_longrunning. > > Bootstrapped and regtested on IBM zSystems. Ok for mainline? > > gcc/ChangeLog: > > * config/s390/s390.cc (s390_bb_fallthru_entry_likely): Remove. > (struct s390_sched_state): Initialise to zero. > (s390_sched_variable_issue): For better debuggability also emit > the current side. > (s390_sched_init): Unconditionally reset scheduler state. Ok. Thanks! Andreas